You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Roman Shaposhnik <rv...@apache.org> on 2015/06/15 22:21:29 UTC

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34814/
-----------------------------------------------------------

(Updated June 15, 2015, 8:21 p.m.)


Review request for geode.


Changes
-------

Publishing an updated patch


Bugs: GEODE-38
    https://issues.apache.org/jira/browse/GEODE-38


Repository: geode


Description
-------

Gfsh launcher script implies an init file can be used. This was possible in GF 6.6, but wasn't implemented in the transition to the new Gfsh in GF 7.0 onwards.
>From "gemfire-assembly/src/main/dist/bin/gfsh.bat " :
"
#
Copy default .gfshrc to the home directory. Uncomment if needed.
#
#if [ ! -f $HOME/.gemfire/.gfsh2rc ]; then
cp $GEMFIRE/defaultConfigs/.gemfire/.gfsh2rc $HOME
#fi
"
If this file is specified, it is currently ignored.


Diffs (updated)
-----

  gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java d9a396a 
  gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java d7dba5a 
  gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfigInitFileJUnitTest.java PRE-CREATION 
  gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshInitFileJUnitTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/34814/diff/


Testing
-------


Thanks,

Roman Shaposhnik