You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2012/10/04 20:47:48 UTC
[jira] [Created] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Ted Yu created HBASE-6948:
-----------------------------
Summary: shell create table script cannot handle split key which is expressed in raw bytes
Key: HBASE-6948
URL: https://issues.apache.org/jira/browse/HBASE-6948
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.2
Reporter: Ted Yu
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470673#comment-13470673 ]
Hadoop QA commented on HBASE-6948:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12548026/HBASE-6948-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 81 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3016//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3016//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3016//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3016//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3016//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3016//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3016//console
This message is automatically generated.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475492#comment-13475492 ]
Ted Yu commented on HBASE-6948:
-------------------------------
Now that HBASE-3444 is resolved, this patch should be good to go, right ?
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Tianying Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tianying Chang updated HBASE-6948:
----------------------------------
I found this bug whiling working on migrating data into a table with less regions. HBase shell create table passed the wrong splt key. I have the patch ready and tested on my cluster.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Tianying Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tianying Chang updated HBASE-6948:
----------------------------------
@stack Due to the jira https://issues.apache.org/jira/browse/HBASE-3444, toByteBinary cannot handle this corner case. So I think this fix should be blocked until HBASE-3444 is fixed.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Tianying Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tianying Chang updated HBASE-6948:
----------------------------------
Attachment: HBASE-6948-trunk.patch
patch for trunk attached.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Tianying Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tianying Chang updated HBASE-6948:
----------------------------------
Attachment: HBASE-6948-trunk.patch
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu reassigned HBASE-6948:
-----------------------------
Assignee: Tianying Chang
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Assignee: Tianying Chang
> Fix For: 0.96.0
>
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475493#comment-13475493 ]
Ted Yu commented on HBASE-6948:
-------------------------------
Now that HBASE-3444 is resolved, this patch should be good to go, right ?
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478440#comment-13478440 ]
Hudson commented on HBASE-6948:
-------------------------------
Integrated in HBase-TRUNK #3453 (See [https://builds.apache.org/job/HBase-TRUNK/3453/])
HBASE-6948 shell create table script cannot handle split key which is expressed in raw bytes (Tianying) (Revision 1399429)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Assignee: Tianying Chang
> Fix For: 0.96.0
>
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Tianying Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tianying Chang updated HBASE-6948:
----------------------------------
Attachment: HBASE-6948.patch
Fix the split key to be correct byte[]
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6948:
--------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6948:
--------------------------
Fix Version/s: 0.96.0
Intergrated to trunk.
Thanks for the review, Stack and Ram.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Assignee: Tianying Chang
> Fix For: 0.96.0
>
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478497#comment-13478497 ]
Hudson commented on HBASE-6948:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #225 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/225/])
HBASE-6948 shell create table script cannot handle split key which is expressed in raw bytes (Tianying) (Revision 1399429)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Assignee: Tianying Chang
> Fix For: 0.96.0
>
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470675#comment-13470675 ]
Ted Yu commented on HBASE-6948:
-------------------------------
{code}
Running org.apache.hadoop.hbase.client.TestShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 97.498 sec
{code}
Failed test is not related to this patch.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473832#comment-13473832 ]
stack commented on HBASE-6948:
------------------------------
The ruby shell has a means of passing binary data. If you do help in the shell, toward the end it show you show. We must be careful this change does not frustrate it. What happens if you pass "\x00". Do we end up with a row that has a single empty byte or do we get something else? (I used a binary editor -- vim -b hfilename -- to verify). If toStringBinary doesn't mangle a "\x00", I'd be good w/ this patch.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475495#comment-13475495 ]
Ted Yu commented on HBASE-6948:
-------------------------------
Pardon my network connection: I was clicking on 'Add' button without seeing the response.
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Tianying Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tianying Chang updated HBASE-6948:
----------------------------------
Attachment: (was: HBASE-6948-trunk.patch)
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473383#comment-13473383 ]
ramkrishna.s.vasudevan commented on HBASE-6948:
-----------------------------------------------
+1 on patch
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6948) shell create table script cannot
handle split key which is expressed in raw bytes
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475494#comment-13475494 ]
Ted Yu commented on HBASE-6948:
-------------------------------
Now that HBASE-3444 is resolved, this patch should be good to go, right ?
> shell create table script cannot handle split key which is expressed in raw bytes
> ---------------------------------------------------------------------------------
>
> Key: HBASE-6948
> URL: https://issues.apache.org/jira/browse/HBASE-6948
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Ted Yu
> Attachments: HBASE-6948.patch, HBASE-6948-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira