You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "uyivzola (via GitHub)" <gi...@apache.org> on 2026/09/09 18:21:31 UTC
[PR] feat(helm): support existing database credential secrets [superset]
uyivzola opened a new pull request, #44104:
URL: https://github.com/apache/superset/pull/44104
### SUMMARY
Adds `database.existingSecret` and `database.secretKeys` for password-only or username/password references. Credentials stay in the existing Kubernetes Secret; literal settings and full-URI precedence are preserved.
Addresses #42876. Complements #43214 without changing the TCP wait containers.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable (Helm configuration).
### TESTING INSTRUCTIONS
- `helm lint helm/superset` passed.
- `helm unittest helm/superset`: 125 tests passed, including 15 new cases.
- `pre-commit run` passed.
- ARM64 kind deployment with Superset 6.1.0 plus psycopg2, PostgreSQL 16 and Redis 7: initialized the database first, then enabled web/worker. Migration, upgrade, health/login endpoints, database queries and Celery ping passed. Credentials containing special characters worked.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #42876
- [ ] Required feature flags
- [ ] Changes UI
- [ ] Includes DB Migration
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(helm): support existing database credential secrets [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44104:
URL: https://github.com/apache/superset/pull/44104#issuecomment-5606697795
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(helm): support existing database credential secrets [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44104:
URL: https://github.com/apache/superset/pull/44104#issuecomment-5606720525
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 52d112cc387d8a862378cb840d3823446fb1d84e |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa1a3ac93b448000872c594 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44104--superset-docs-preview.netlify.app](https://deploy-preview-44104--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBDoMgEAXQu8y6pKhU0Rt4jM8wbU1aITALTePdy-5t3o9ySd-stBDdKBTs_G7mFOW4PwVqXO-n0UQoAqoYObaq2_4yVbiIthQlf9K5xtZGoMMAnofgnLfW-qnnx-zo-gM) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44104--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org