You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/08/26 20:51:09 UTC
Review Request 37806: Rpm: replace hyphens from version.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37806/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora-packaging
Description
-------
I mixed deb and RPM up in the previous round, it's RPM that needs a hyphen replacement.
Diffs
-----
builder/deb/ubuntu-trusty/build.sh 87c2bc0a75e8f33b63de9d3df0f438e13a2e1eed
builder/rpm/centos-7/build.sh 9e8eae94a09d013d01ea405ecb2e554d348e2ce8
Diff: https://reviews.apache.org/r/37806/diff/
Testing
-------
Discovered this in jenkins, successfully ran the commands that jenkins will run:
```
./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0-SNAPSHOT.2015.08.25.tar.gz 0.10.0-SNAPSHOT.2015.08.25
./build-artifact.sh builder/deb/ubuntu-trusty ~/apache-aurora-0.10.0-SNAPSHOT.2015.08.25.tar.gz 0.10.0-SNAPSHOT.2015.08.25
```
Thanks,
Bill Farner
Re: Review Request 37806: Rpm: replace hyphens from version.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37806/#review96574
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 26, 2015, 6:51 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37806/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 6:51 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> I mixed deb and RPM up in the previous round, it's RPM that needs a hyphen replacement.
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/build.sh 87c2bc0a75e8f33b63de9d3df0f438e13a2e1eed
> builder/rpm/centos-7/build.sh 9e8eae94a09d013d01ea405ecb2e554d348e2ce8
>
> Diff: https://reviews.apache.org/r/37806/diff/
>
>
> Testing
> -------
>
> Discovered this in jenkins, successfully ran the commands that jenkins will run:
>
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0-SNAPSHOT.2015.08.25.tar.gz 0.10.0-SNAPSHOT.2015.08.25
> ./build-artifact.sh builder/deb/ubuntu-trusty ~/apache-aurora-0.10.0-SNAPSHOT.2015.08.25.tar.gz 0.10.0-SNAPSHOT.2015.08.25
> ```
>
>
> Thanks,
>
> Bill Farner
>
>