You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/11/04 04:03:58 UTC
[kudu-CR] [server] fix compilation under RHEL/CentOS 6
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16696
Change subject: [server] fix compilation under RHEL/CentOS 6
......................................................................
[server] fix compilation under RHEL/CentOS 6
It seems the version of the OpenSSL library used to work around
versioned symbols in RHEL/CentOS 6.5+ doesn't contain declaration
of FIPS_mode() function in openssl/crypto.h file. That breaks the
compilation after the introduction of the two changelist mentioned
below. This patch fixes the compilation breakage, adding
openssl/fips.h header file when necessary.
This is a follow-up to changelists 46231c52f and 6d2c79a4f.
Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
---
M CMakeLists.txt
M src/kudu/security/openssl_util.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
4 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/16696/1
--
To view, visit http://gerrit.cloudera.org:8080/16696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
Gerrit-Change-Number: 16696
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [server] fix compilation under RHEL/CentOS 6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16696 )
Change subject: [server] fix compilation under RHEL/CentOS 6
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16696/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/16696/1/CMakeLists.txt@1070
PS1, Line 1070: WORKAROUND
> nit: maybe we could be more descriptive, like KUDU_OPENSSL_REQUIRE_FIPS_HEA
Done
--
To view, visit http://gerrit.cloudera.org:8080/16696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
Gerrit-Change-Number: 16696
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Nov 2020 05:00:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [server] fix compilation under RHEL/CentOS 6
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16696 )
Change subject: [server] fix compilation under RHEL/CentOS 6
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
Gerrit-Change-Number: 16696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Nov 2020 05:02:00 +0000
Gerrit-HasComments: No
[kudu-CR] [server] fix compilation under RHEL/CentOS 6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16696 )
Change subject: [server] fix compilation under RHEL/CentOS 6
......................................................................
[server] fix compilation under RHEL/CentOS 6
It seems the version of the OpenSSL library used to work around
versioned symbols in RHEL/CentOS 6.5+ doesn't contain declaration
of FIPS_mode() function in openssl/crypto.h file. That breaks the
compilation after the introduction of the two changelist mentioned
below. This patch fixes the compilation breakage, adding
openssl/fips.h header file when necessary.
This is a follow-up to changelists 46231c52f and 6d2c79a4f.
Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
Reviewed-on: http://gerrit.cloudera.org:8080/16696
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M src/kudu/security/openssl_util.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
4 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
Gerrit-Change-Number: 16696
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [server] fix compilation under RHEL/CentOS 6
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16696 )
Change subject: [server] fix compilation under RHEL/CentOS 6
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16696/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/16696/1/CMakeLists.txt@1070
PS1, Line 1070: WORKAROUND
nit: maybe we could be more descriptive, like KUDU_OPENSSL_REQUIRE_FIPS_HEADER or somesuch?
--
To view, visit http://gerrit.cloudera.org:8080/16696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
Gerrit-Change-Number: 16696
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Nov 2020 04:43:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [server] fix compilation under RHEL/CentOS 6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16696
to look at the new patch set (#2).
Change subject: [server] fix compilation under RHEL/CentOS 6
......................................................................
[server] fix compilation under RHEL/CentOS 6
It seems the version of the OpenSSL library used to work around
versioned symbols in RHEL/CentOS 6.5+ doesn't contain declaration
of FIPS_mode() function in openssl/crypto.h file. That breaks the
compilation after the introduction of the two changelist mentioned
below. This patch fixes the compilation breakage, adding
openssl/fips.h header file when necessary.
This is a follow-up to changelists 46231c52f and 6d2c79a4f.
Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
---
M CMakeLists.txt
M src/kudu/security/openssl_util.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
4 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/16696/2
--
To view, visit http://gerrit.cloudera.org:8080/16696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3714365801f7de4e4768f4c4e2cf063ff5a65c57
Gerrit-Change-Number: 16696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)