[GitHub] [maven] gnodet commented on a diff in pull request #835: [MNG-6609] expose packaging via property "project.packaging"

[GitBox <gi...@apache.org>]

gnodet commented on code in PR #835:
URL: https://github.com/apache/maven/pull/835#discussion_r1001591928


##########
maven-model-builder/src/main/java/org/apache/maven/model/profile/ProfileActivationContext.java:
##########
@@ -30,6 +30,12 @@
  */
 public interface ProfileActivationContext
 {
+    /**
+     * Key of the property containing the project's packaging.
+     * Available in {@link #getUserProperties()}.
+     * @since 4.0 
+     */
+    String PROPERTY_NAME_PACKAGING = "project.packaging";

Review Comment:
   Shouldn't that be `packaging` to align with https://github.com/apache/maven/blob/2a9f39336cec1d8e52d30cc48503d51ed8672536/maven-model-builder/src/main/java/org/apache/maven/model/path/ProfileActivationFilePathInterpolator.java#L75-L82
   I think the same reasoning apply, we don't support all `project.*` properties...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org