You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/04/28 06:05:59 UTC
[GitHub] carbondata pull request #2247: [CARBONDATA-2414][Doc] Optimize documents for...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2247
[CARBONDATA-2414][Doc] Optimize documents for sort column bounds
Optimize documents for sort column bounds
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`Updated document`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`NA`
- How it is tested? Please attach test report.
`NA`
- Is it a performance related change? Please attach the performance test report.
`NA`
- Any additional information to help reviewers in testing this change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0428_opt_doc_sort_column_bounds
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2247
----
commit 4e93e831a2f71fca4bf31dcb12a76b098eff7332
Author: xuchuanyin <xu...@...>
Date: 2018-04-28T06:03:22Z
Optimize documents for sort column bounds
----
---
[GitHub] carbondata pull request #2247: [CARBONDATA-2414][Doc] Optimize documents for...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2247#discussion_r184844059
--- Diff: docs/data-management-on-carbondata.md ---
@@ -488,14 +488,17 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
- **SORT COLUMN BOUNDS:** Range bounds for sort columns.
+ Suppose the table is created with 'SORT_COLUMNS'='col1,col2,col3'. During data loading, we can specify the following option to enhance data loading performance.
--- End diff --
Still not be easy to understand, can you please give a real example?
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2247
LGTM
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2247
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4604/
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2247
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5498/
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2247
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4336/
---
[GitHub] carbondata pull request #2247: [CARBONDATA-2414][Doc] Optimize documents for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2247
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2247
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5501/
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2247
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4332/
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2247
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4600/
---
[GitHub] carbondata issue #2247: [CARBONDATA-2414][Doc] Optimize documents for sort c...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2247
@chenliang613 Please review the updated document
---