You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/21 19:54:11 UTC

[GitHub] [beam] y1chi commented on a change in pull request #13584: [BEAM-9637] Add all runners to Python --runner help text.

y1chi commented on a change in pull request #13584:
URL: https://github.com/apache/beam/pull/13584#discussion_r546899847



##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -414,13 +414,30 @@ class StandardOptions(PipelineOptions):
 
   DEFAULT_RUNNER = 'DirectRunner'
 
+  ALL_KNOWN_RUNNERS = (
+      'apache_beam.runners.dataflow.dataflow_runner.DataflowRunner',
+      'apache_beam.runners.direct.direct_runner.BundleBasedDirectRunner',
+      'apache_beam.runners.direct.direct_runner.DirectRunner',
+      'apache_beam.runners.direct.direct_runner.SwitchingDirectRunner',

Review comment:
       I believe DirectRunner is aliased to SwitchingDirectRunner by default, should we only expose DirectRunner?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org