You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/05/17 23:24:41 UTC
[PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
kevinjqliu opened a new pull request, #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #1325.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2888635608
One question, should we remove this function as part of the 0.5.0 release or perhaps change it to `since = "0.5.0"`
https://github.com/apache/iceberg-rust/blame/cfe2a980b27cda744fab8e78b4550b167b4d4d45/crates/iceberg/src/io/file_io.rs#L98
This was introduced in #1275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2911019657
thanks for the review @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2888639823
I also have the changes for `CHANGELOG.md` and `DEPENDENCIES.rust.tsv` queued up. Should I include those in this PR or a followup PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2893006769
Added `CHANGELOG.md` and `DEPENDENCIES.rust.tsv`
Feel free to merge this and i'll push the RC tag once its merge :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2889759164
> One question, should we remove this function as part of the 0.5.0 release or perhaps change it to `since = "0.5.0"`
>
> https://github.com/apache/iceberg-rust/blame/cfe2a980b27cda744fab8e78b4550b167b4d4d45/crates/iceberg/src/io/file_io.rs#L98
>
> This was introduced in #1275
It's marked as deprecated, so I think it's better to keep it for a while so that downstream users have time to migrate them?
> I also have the changes for CHANGELOG.md and DEPENDENCIES.rust.tsv queued up. Should I include those in this PR or a followup PR?
This seems like a small pr, so I'm fine with including them together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #1345:
URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2892788886
cc @kevinjqliu Are we going to merge this or we should hold on a while for CHANGELOG.md and DEPENDENCIES.rust.tsv?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org