You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2025/02/26 13:47:22 UTC
[PR] SOLR-17633 Add matomo script to ref-guide [solr]
janhoy opened a new pull request, #3217:
URL: https://github.com/apache/solr/pull/3217
https://issues.apache.org/jira/browse/SOLR-17633
Adds matomo tracking to ref guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17633 Add matomo script to ref-guide [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3217:
URL: https://github.com/apache/solr/pull/3217#issuecomment-2833706291
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17633 Add matomo script to ref-guide [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #3217:
URL: https://github.com/apache/solr/pull/3217#discussion_r1971625911
##########
solr/solr-ref-guide/ui-src/partials/head-icons.hbs:
##########
@@ -1,3 +1,20 @@
<!-- Solr Changes - Start -->
<link rel="icon" href="{{{uiRootPath}}}/img/favicon.ico" type="image/x-icon">
+ {{#if env.MATOMO_ENABLED}}
+ <script>
Review Comment:
I piggy-backed on `head-icons.hbs` instead of customizing `head.hbs`. See https://gitlab.com/antora/antora-ui-default/-/blob/master/src/partials/head.hbs for the default template. I could of course fork `head.hbs`, add a new `head-matomo.hbs` to the end to separate it more. But the `head-icons` script is already the last in <head> and already customized, so an easier choice. I can be persuaded otherwise though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17633 Add matomo script to ref-guide [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #3217:
URL: https://github.com/apache/solr/pull/3217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17633 Add matomo script to ref-guide [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #3217:
URL: https://github.com/apache/solr/pull/3217#discussion_r1971650510
##########
solr/solr-ref-guide/ui-src/partials/head-icons.hbs:
##########
@@ -1,3 +1,20 @@
<!-- Solr Changes - Start -->
<link rel="icon" href="{{{uiRootPath}}}/img/favicon.ico" type="image/x-icon">
+ {{#if env.MATOMO_ENABLED}}
+ <script>
Review Comment:
So I did some more research, and turns out the [head-scripts.hbs](https://gitlab.com/antora/antora-ui-default/-/blob/master/src/partials/head-scripts.hbs) template only contained some google-analytics stuff that we don't want anyway, so I moved our matomo script there instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org