You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/26 17:24:19 UTC

[GitHub] [beam] ccciudatu edited a comment on pull request #13415: [BEAM-11337] Make the ThriftCoder class visible from outside its package

ccciudatu edited a comment on pull request #13415:
URL: https://github.com/apache/beam/pull/13415#issuecomment-734413926


   @chrlarsen I see what you mean, I noticed the check in `ThriftIO.ReadFiles.withProtocol()`.
   However, I'm not sure it's the responsibility of the `ThriftCoder` class to keep track of the limitations of each protocol, especially as one can provide their own custom protocol for which we have no way to assess the capabilities.
   
   It would be nice to ensure that once cannot shoot themselves in the foot and we can probably move/copy the above check in the public static method and only let the non-public constructor accept anything (for the write path). But I'm not sure it's worth it...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org