You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/26 10:55:36 UTC

[GitHub] [pulsar] yuruguo opened a new pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

yuruguo opened a new pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797


   Fixes #11775 
   
   ### Motivation
   Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption
   
   ### Modifications
    judge whether `--subscriptions size` and `--num-subscriptions` are equal in exclusive or non-exclusive mode
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906799519


   If there is no problem, can you merge it? @eolivelli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-908948215


   Can you @eolivelli @hangc0276 @gaoran10  assign this issue to me? And put the corresponding `Labels`(Maybe `component/client`, `component/test`, `type/bug`, `release/2.8.2`)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo removed a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-912157729


   If there is no problem, can you merge it? @merlimat @eolivelli @sijie  @codelipenghui @tuteng @315157973 @hangc0276  Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-912157729


   If there is no problem, can you merge it? @merlimat @eolivelli @codelipenghui @hangc0276 @gaoran10  Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-908948215


   Can you @eolivelli @hangc0276 @gaoran10  assign this issue to me? And put the corresponding `Labels`(Maybe `component/client`, `component/test`, `type/bug`, `release/2.8.2`)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo removed a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906487862


   > LGTM
   
   Thx!Could you approve the `workflows awaiting approval` below?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906487862


   > LGTM
   
   Thx!Could you approve the `workflows awaiting approval` below?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-909904455


   If there is no problem, can you merge it? @eolivelli @codelipenghui @hangc0276 Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906799519


   If there is no problem, can you merge it? @eolivelli @merlimat @gaoran10 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli merged pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-908948215


   Can you @eolivelli @hangc0276 @gaoran10  assign this issue to me? And put the corresponding `Labels`(Maybe `component/client`, `component/test`, `release/2.8.2`)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when -ss size is less than -ns in consumption

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-916962938


   it is not a critical problem, mostly a usability fix.
   I don't think it is worth to pick it to a released branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-913730375


   If no problem, can you merge it? @merlimat @eolivelli @sijie @codelipenghui @tuteng @315157973 @hangc0276 Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-912157729


   If there is no problem, can you merge it? @merlimat @eolivelli @sijie  @codelipenghui @315157973 @hangc0276  Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906757773


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906799519






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906799519


   PTAL @merlimat  @codelipenghui @hangc0276  @gaoran10 , thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-909904455


   If there is no problem, can you merge it? @eolivelli @codelipenghui @hangc0276 Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-912157729


   If there is no problem, can you merge it? @merlimat @eolivelli @sijie  @codelipenghui @tuteng @315157973 @hangc0276  Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when -ss size is less than -ns in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-916539219


   Should this patch be cherry-picked to the `branch-2.8`? @codelipenghui 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo removed a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-909904455


   If there is no problem, can you merge it? @eolivelli @codelipenghui @hangc0276 Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo edited a comment on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-906799519


   If there is no problem, can you merge it? @eolivelli @merlimat 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] yuruguo commented on pull request #11797: [testclient] Fix IndexOutOfBoundsException when --subscriptions size is less than --num-subscriptions in consumption

Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11797:
URL: https://github.com/apache/pulsar/pull/11797#issuecomment-908948215


   Can you @eolivelli @hangc0276 @gaoran10  assign this issue to me? And put the corresponding `Labels`(Maybe `component/client`, `component/test`, `release/2.8.2`)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org