You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/10 12:29:04 UTC
[GitHub] [superset] michael-s-molina commented on a change in pull request #15624: refactor: icon to icons for homepage and card compompents
michael-s-molina commented on a change in pull request #15624:
URL: https://github.com/apache/superset/pull/15624#discussion_r667333581
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -116,16 +118,16 @@ const getEntityTitle = (entity: ActivityObject) => {
return entity.item_title || UNTITLED;
};
-const getEntityIconName = (entity: ActivityObject) => {
- if ('sql' in entity) return 'sql';
+const getEntityIcons = (entity: ActivityObject) => {
Review comment:
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org