[jira] [Created] (HBASE-28408) Confusing logging during backup restore

["Dieter De Paepe (Jira)" <ji...@apache.org>]

Dieter De Paepe created HBASE-28408:
---------------------------------------

             Summary: Confusing logging during backup restore
                 Key: HBASE-28408
                 URL: https://issues.apache.org/jira/browse/HBASE-28408
             Project: HBase
          Issue Type: Bug
          Components: backup&restore
    Affects Versions: 2.6.0
            Reporter: Dieter De Paepe


Encountered this while experimenting with the backup/restore functionality.

My setup was as follows:
 * Took several backups (Full1, inc2, inc3)
 * Changed an entry in the "lily_tenant_acme:LILY_SETTINGS" table
 * Attempt a restore (to test if my changed entry is reverted):

{code:java}
$ hbase restore -conf backup-conf.xml s3a://backuprestore-experiments/hbase backup_1709123740345 -t "lily_tenant_acme:LILY_SETTINGS" -m "lily_tenant_acme:LILY_SETTINGS-restored1" -o

24/02/28 16:15:41 WARN org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil: The addDependencyJars(Configuration, Class<?>...) method has been deprecated since it is easy to use incorrectly. Most users should rely on addDependencyJars(Job) instead. See HBASE-8386 for more details.
24/02/28 16:15:58 WARN org.apache.hadoop.hbase.tool.LoadIncrementalHFiles: Skipping non-directory hdfs://hdfsns/user/lily/hbase-staging/bulk_output-lily_tenant_acme-LILY_SETTINGS-restored1-1709136941410/_SUCCESS
24/02/28 16:15:59 WARN org.apache.hadoop.hbase.backup.impl.RestoreTablesClient: Nothing has changed, so there is no need to restore 'lily_tenant_acme:LILY_SETTINGS'
{code}
Based on the final logging line, I presumed my restore operation had failed.

After some investigation however, I found that this was not the case: my change was reverted as expected.

Some code investigation learned me this log message is shown because I was restoring backup `inc3`, and there were no changes between `full1` and `inc3`.

I suggest rephrasing this log message, and changing it to a INFO level.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)