You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Anand Nadar <na...@gmail.com> on 2024/02/20 19:44:15 UTC

Review Request 74899: RANGER-4630: Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74899/
-----------------------------------------------------------

Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary.


Bugs: RANGER-4630
    https://issues.apache.org/jira/browse/RANGER-4630


Repository: ranger


Description
-------

Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java d1568bbac 
  security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 529472a31 
  security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 01ff442fb 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java 989ea2259 
  security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java f22963f3c 


Diff: https://reviews.apache.org/r/74899/diff/1/


Testing
-------

Validated multiple tag resource id search in tags/resources/paginated api
Validated search by tagServiceName in tagresourcemaps/paginated api


Thanks,

Anand Nadar


Re: Review Request 74899: RANGER-4630: Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74899/#review226226
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java
Lines 42 (patched)
<https://reviews.apache.org/r/74899/#comment314472>

    svce => svcr


- Madhan Neethiraj


On Feb. 20, 2024, 7:44 p.m., Anand Nadar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74899/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2024, 7:44 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4630
>     https://issues.apache.org/jira/browse/RANGER-4630
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java d1568bbac 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 529472a31 
>   security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 01ff442fb 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java 989ea2259 
>   security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java f22963f3c 
> 
> 
> Diff: https://reviews.apache.org/r/74899/diff/1/
> 
> 
> Testing
> -------
> 
> Validated multiple tag resource id search in tags/resources/paginated api
> Validated search by tagServiceName in tagresourcemaps/paginated api
> 
> 
> Thanks,
> 
> Anand Nadar
> 
>


Re: Review Request 74899: RANGER-4630: Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74899/#review226229
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 21, 2024, 3:21 a.m., Anand Nadar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74899/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2024, 3:21 a.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4630
>     https://issues.apache.org/jira/browse/RANGER-4630
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java d1568bbac 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 529472a31 
>   security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 01ff442fb 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java 989ea2259 
>   security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java f22963f3c 
> 
> 
> Diff: https://reviews.apache.org/r/74899/diff/2/
> 
> 
> Testing
> -------
> 
> Validated multiple tag resource id search in tags/resources/paginated api
> Validated search by tagServiceName in tagresourcemaps/paginated api
> 
> 
> Thanks,
> 
> Anand Nadar
> 
>


Re: Review Request 74899: RANGER-4630: Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api

Posted by Anand Nadar <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74899/
-----------------------------------------------------------

(Updated Feb. 21, 2024, 3:21 a.m.)


Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary.


Bugs: RANGER-4630
    https://issues.apache.org/jira/browse/RANGER-4630


Repository: ranger


Description
-------

Added support for multiple tag resource id search in resources/paginated api, and by tagServiceName in tagresourcemaps/paginated api


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java d1568bbac 
  security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 529472a31 
  security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 01ff442fb 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java 989ea2259 
  security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java f22963f3c 


Diff: https://reviews.apache.org/r/74899/diff/2/

Changes: https://reviews.apache.org/r/74899/diff/1-2/


Testing
-------

Validated multiple tag resource id search in tags/resources/paginated api
Validated search by tagServiceName in tagresourcemaps/paginated api


Thanks,

Anand Nadar