You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/07 14:48:36 UTC

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #451: feat(route): add publish and offline to route

liuxiran opened a new pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
    issue #437 fe , depends on pr https://github.com/apache/apisix-dashboard/pull/450
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   in frontend we add `status` to route:
   1. add `status` in create route step1
   ![image](https://user-images.githubusercontent.com/2561857/92398480-37e08380-f15b-11ea-870c-5fbbb46cffa4.png)
   
   choose `enable`, means to publish route(create route both in mysql and apisix), and the route can be use now;
   choose `disable`, means to create route offline(create route onlyl in mysql), the route could not be used
   
   1. in route table,we add `status` column, and add `publish` `offline` button
   ![image1](https://user-images.githubusercontent.com/2561857/92398724-acb3bd80-f15b-11ea-8740-86262088ddc6.png)
   
   the `published` route could be `offline` with the `offline` button; and the `offline` route could be `published` with the `publish` button.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486130770



##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       do we need to add a boolean flag in route? 
   
   https://github.com/apache/apisix/blob/master/doc/admin-api.md#route
   
   we'll remove mysql soon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-688579137


   @membphis Please take a look at those screenshots above :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-690846699


   Please resolve those conflicts :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-690846699


   Please resolve those conflicts :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] moonming commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689280915


   ![图片](https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png)
   You may have misunderstood what I mean. I hope the description here is more clear


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486745396



##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       If moved `status` to abisix, it could be a good extension as a basis for route lifecycle management, and if not, `status` only a a new field of the route table in the current mysql, which is not associated with other tables, it would be easier to migrate in new manager api  .

##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       If moved `status` to abisix, it could be a good extension as a basis for route lifecycle management, and if not, `status` is only a new field of the route table in the current mysql, which is not associated with other tables, it would be easier to migrate in new manager api  :).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486745396



##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       If moved `status` to abisix, it could be a good extension as a basis for route lifecycle management, and if not, `status` only a a new field of the route table in the current mysql, which is not associated with other tables, it would be easier to migrate in new manager api  .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485298935



##########
File path: src/pages/Route/transform.ts
##########
@@ -53,11 +53,17 @@ export const transformStepData = ({
     protocols = protocols.concat('websocket');
   }
 
+  let { status } = step1Data;
+  if (step1Data.status === undefined) {

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485298486



##########
File path: src/pages/Route/service.ts
##########
@@ -50,8 +50,8 @@ export const fetchList = ({ current = 1, pageSize = 10 }, search: string) => {
 };
 
 export const remove = (rid: number) => request(`/routes/${rid}`, { method: 'DELETE' });
-export const offline = (rid: number) => request(`/offlineroutes/${rid}`, { method: 'PUT' });
-export const publish = (rid: number) => request(`/publishroutes/${rid}`, { method: 'PUT' });
+export const offline = (rid: number) => request(`/routes/${rid}/offline`, { method: 'PUT' });
+export const publish = (rid: number) => request(`/routes/${rid}/publish`, { method: 'PUT' });

Review comment:
       LGTM, and it seems to need a new PR on manager api.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-688820433


   This PR should wait for #450 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r484855909



##########
File path: src/pages/Route/transform.ts
##########
@@ -53,11 +53,17 @@ export const transformStepData = ({
     protocols = protocols.concat('websocket');
   }
 
+  let { status } = step1Data;
+  if (step1Data.status === undefined) {

Review comment:
       status should be always a number or string flag I think, why this will have the `undefined` case? 🤔

##########
File path: src/pages/Route/service.ts
##########
@@ -50,6 +50,8 @@ export const fetchList = ({ current = 1, pageSize = 10 }, search: string) => {
 };
 
 export const remove = (rid: number) => request(`/routes/${rid}`, { method: 'DELETE' });
+export const offline = (rid: number) => request(`/offlineroutes/${rid}`, { method: 'PUT' });
+export const publish = (rid: number) => request(`/publishroutes/${rid}`, { method: 'PUT' });

Review comment:
       Not a good Pathname for this module,  I would prefer using `PUT /routes/${rid}/offline` if possible.
   

##########
File path: src/pages/Route/components/Step1/MetaView.tsx
##########
@@ -43,6 +43,15 @@ const MetaView: React.FC<Props> = ({ disabled }) => {
           disabled={disabled}
         />
       </Form.Item>
+      {!isEdit ? (

Review comment:
       we could use `&&` here

##########
File path: src/pages/Route/Create.tsx
##########
@@ -14,21 +14,21 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import React, { useState, useEffect } from 'react';
-import { Card, Steps, Form } from 'antd';
+import React, { useEffect, useState } from 'react';
+import { Card, Form, Steps } from 'antd';
 import { PageHeaderWrapper } from '@ant-design/pro-layout';
 import { history, useIntl } from 'umi';
 import { transformer as chartTransformer } from '@api7-dashboard/pluginchart';
 
 import ActionBar from '@/components/ActionBar';
 
 import {
+  checkHostWithSSL,
+  checkUniqueName,
   create,
   fetchItem,
-  update,
-  checkUniqueName,
   fetchUpstreamItem,
-  checkHostWithSSL,
+  update,

Review comment:
       I don't see any changes here except the import order, if there have no needs, please keep the previous order.

##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,8 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    env: string;

Review comment:
       Does this is a form field or?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] moonming commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689293720


   LGTM
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   liuxiran <no...@github.com> 于2020年9月9日周三 上午11:56写道：
   
   > [image: 图片]
   > <https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png>
   > You may have misunderstood what I mean. I hope the description here is
   > more clear
   >
   > How about published after creation here？
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689285571>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBKZQ7ZBSHHZJIBATJY3SE34IHANCNFSM4Q6LLBPQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-688612305


   OK, if there have no other critical issues about UI, I will review the codes soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486745396



##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       If moved `status` to abisix, it could be a good extension as a basis for route lifecycle management, and if not, `status` is only a new field of the route table in the current mysql, which is not associated with other tables, it would be easier to migrate in new manager api  :).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485288825



##########
File path: src/pages/Route/service.ts
##########
@@ -50,6 +50,8 @@ export const fetchList = ({ current = 1, pageSize = 10 }, search: string) => {
 };
 
 export const remove = (rid: number) => request(`/routes/${rid}`, { method: 'DELETE' });
+export const offline = (rid: number) => request(`/offlineroutes/${rid}`, { method: 'PUT' });
+export const publish = (rid: number) => request(`/publishroutes/${rid}`, { method: 'PUT' });

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485303868



##########
File path: src/pages/Route/service.ts
##########
@@ -50,8 +50,8 @@ export const fetchList = ({ current = 1, pageSize = 10 }, search: string) => {
 };
 
 export const remove = (rid: number) => request(`/routes/${rid}`, { method: 'DELETE' });
-export const offline = (rid: number) => request(`/offlineroutes/${rid}`, { method: 'PUT' });
-export const publish = (rid: number) => request(`/publishroutes/${rid}`, { method: 'PUT' });
+export const offline = (rid: number) => request(`/routes/${rid}/offline`, { method: 'PUT' });
+export const publish = (rid: number) => request(`/routes/${rid}/publish`, { method: 'PUT' });

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689285571


   > ![图片](https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png)
   > You may have misunderstood what I mean. I hope the description here is more clear
   
   How about `published after creation` here？
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689268753


   Waiting for #450 , DO NOT MERGE NOW.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] moonming commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-688604406


   > choose `enable`, means to publish route(create route both in mysql and apisix), and the route can be use now;
   
   it will be better if we can make it more clearly about `status`.
   others UI looks good for me.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485289231



##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,8 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    env: string;

Review comment:
       something need to remove:), already done.

##########
File path: src/pages/Route/components/Step1/MetaView.tsx
##########
@@ -43,6 +43,15 @@ const MetaView: React.FC<Props> = ({ disabled }) => {
           disabled={disabled}
         />
       </Form.Item>
+      {!isEdit ? (

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689309012


   @liuxiran could add the description under that field using Form item :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689272799


   > > choose `enable`, means to publish route(create route both in mysql and apisix), and the route can be use now;
   > 
   > it will be better if we can make it more clearly about `status`.
   
   At the beginning we have considered: `offline`, `designing`, `testing`, `published` and other states,  corresponding to published, all other states are kinds of offline status,  or would it be better  to change `offline` to `designing`?  @moonming 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689285571


   > ![图片](https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png)
   > You may have misunderstood what I mean. I hope the description here is more clear
   
   How about `published after creation` here？or add  a  tooltip to label: `publish`?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-690846699






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486745396



##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       If moved `status` to abisix, it could be a good extension as a basis for route lifecycle management, and if not, `status` only a a new field of the route table in the current mysql, which is not associated with other tables, it would be easier to migrate in new manager api  .

##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       If moved `status` to abisix, it could be a good extension as a basis for route lifecycle management, and if not, `status` is only a new field of the route table in the current mysql, which is not associated with other tables, it would be easier to migrate in new manager api  :).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org