You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/09 09:51:01 UTC

[GitHub] [pulsar] Jason918 commented on a change in pull request #14007: [PIP-132] Include message header size when check maxMessageSize for non-batch message on the client side.

Jason918 commented on a change in pull request #14007:
URL: https://github.com/apache/pulsar/pull/14007#discussion_r802473579



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -2074,6 +2115,24 @@ private void recoverProcessOpSendMsgFrom(ClientCnx cnx, MessageImpl from, long e
         }
     }
 
+    /**
+     *  Check final message size for non-batch and non-chunked messages only.
+     */
+    public boolean checkMaxMessageSize(OpSendMsg op) {

Review comment:
       Good point, this method name is confusing.
   Renamed this to `isMessageSizeExceeded`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org