[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #4518: [ISSUE #4463] fix broker is normal exit, but indexFile not flush disk

[GitBox <gi...@apache.org>]

absolute8511 commented on code in PR #4518:
URL: https://github.com/apache/rocketmq/pull/4518#discussion_r1053290434


##########
store/src/main/java/org/apache/rocketmq/store/index/IndexService.java:
##########
@@ -358,15 +358,21 @@ public void flush(final IndexFile f) {
 
         if (indexMsgTimestamp > 0) {
             this.defaultMessageStore.getStoreCheckpoint().setIndexMsgTimestamp(indexMsgTimestamp);
-            this.defaultMessageStore.getStoreCheckpoint().flush();
+            if (forceFlush) {
+                this.defaultMessageStore.getStoreCheckpoint().flush();
+            }
         }
     }
 
     public void start() {
 
     }
 
+    // fix issue 4463
     public void shutdown() {
-
+        if (!indexFileList.isEmpty()) {
+            final IndexFile indexFile = indexFileList.get(indexFileList.size() - 1);
+            flush(indexFile, false);

Review Comment:
   Why use false here while shutdown? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org