[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #13311: ARROW-16340: [Python] Move all Python related code into PyArrow

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on code in PR #13311:
URL: https://github.com/apache/arrow/pull/13311#discussion_r899110501


##########
cpp/cmake_modules/FindArrowPython.cmake:
##########
@@ -46,8 +46,9 @@ endif()
 find_package(Arrow ${find_package_arguments})
 
 if(ARROW_FOUND)
+  message(STATUS "CPYARROW_HOME: ${CPYARROW_HOME}")
   arrow_find_package(ARROW_PYTHON
-                     "${ARROW_HOME}"
+                     "${CPYARROW_HOME}"

Review Comment:
   > On long term we should probably have libarrow_python.so just be one of the shared objects constituting pyarrow.
   
   That's actually what is already happening, I think. The libarrow_python.so gets copied into the pyarrow directory (either the repo itself for an inplace build, or the build directory, before that one gets copied to site-packages for a normal install). 
   But so for building the cython extensions, we need to point to where libarrow_python.so can be found (which is now a different location as where libarrow.so can be found). And doing that with a argument to cmake seems a good way to do that? (alternatively we might need to edit the `arrow_find_package` to work with this new situation?)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org