You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ahlag (via GitHub)" <gi...@apache.org> on 2026/10/17 00:47:00 UTC

[PR] fix(arrow-select): keep row count in take for zero-width FixedSizeBinary [arrow-rs]

ahlag opened a new pull request, #11637:
URL: https://github.com/apache/arrow-rs/pull/11637

   # Which issue does this PR close?
   
   - Closes #11584.
   
   # Rationale for this change
   
   `take` on a `FixedSizeBinaryArray` of width 0 returned an empty array instead of one row per index (unless an index or value was null), because `FixedSizeBinaryArray::try_new` cannot infer the length from an empty values buffer.
   
   # What changes are included in this PR?
   
   `take_fixed_size_binary` builds the result with `try_new_with_len(..., indices.len())`, like #10914 did for zero-sized `FixedSizeList`.
   
   # Are these changes tested?
   
   Yes, `test_take_zero_sized_fixed_size_binary`, next to `test_take_zero_sized_fixed_size_list`. It fails without the fix.
   
   # Are there any significant user-facing changes?
   
   No.
   
   AI use: I used Claude Code to find the cause and write the fix and test. I reviewed the change and checked that the test fails without the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(arrow-select): keep row count in take for zero-width FixedSizeBinary [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #11637:
URL: https://github.com/apache/arrow-rs/pull/11637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org