[GitHub] [apisix] moonming commented on a diff in pull request #9341: chore(ci): remove 3rd keycloak docker image

["moonming (via GitHub)" <gi...@apache.org>]

moonming commented on code in PR #9341:
URL: https://github.com/apache/apisix/pull/9341#discussion_r1173250770


##########
ci/pod/keycloak/kcadm_configure_university.sh:
##########
@@ -0,0 +1,90 @@
+#!/usr/bin/env bash

Review Comment:
   why we need this file?



##########
ci/pod/docker-compose.plugin.yml:
##########
@@ -28,42 +28,26 @@ services:
     networks:
       apisix_net:
 
-
   ## keycloak
   apisix_keycloak:
-    image: sshniro/keycloak-apisix:1.0.0
-    environment:
-      KEYCLOAK_USER: admin
-      KEYCLOAK_PASSWORD: 123456
-    restart: unless-stopped
-    ports:
-      - "8090:8080"
-      - "8443:8443"
-    networks:
-      apisix_net:
-
-  ## keycloak
-  # The keycloak official has two types of docker images:
-  # * legacy WildFly distribution
-  # * new Quarkus based distribution
-  # Here we choose new version, because it's mainstream and
-  # supports kcadm.sh to init the container for test.
-  # The original keycloak service `apisix_keycloak` is
-  # third-party personal customized image and for OIDC test only.
-  # We should unify both containers in future.
-  apisix_keycloak_new:
-    container_name: apisix_keycloak_new
+    container_name: apisix_keycloak
     image: quay.io/keycloak/keycloak:18.0.2

Review Comment:
   why not use 21.0 or 21.1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org