You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/30 20:55:41 UTC

[jira] [Commented] (METRON-795) Install Metron REST with Ambari MPack

    [ https://issues.apache.org/jira/browse/METRON-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949806#comment-15949806 ] 

ASF GitHub Bot commented on METRON-795:
---------------------------------------

GitHub user merrimanr opened a pull request:

    https://github.com/apache/incubator-metron/pull/500

    METRON-795: Install Metron REST with Ambari MPack

    ## Contributor Comments
    This PR adds the metron-rest module to the Ambari MPack.  This can be tested by building the rpms and mpack and spinning up full-dev-platform.  Once the ansible script has finished, navigate to "Ambari > Services > Metron" and there should be an additional "Metron REST" component in the Summary.  The "Quick Links" tab will have a link to the REST Swagger UI that should be functional if the service is running.  All the Ambari lifecycle commands should work.  I also tested starting/stopping the service with the "service metron-rest start/stop" commands and verified Ambari correctly reports status.
    
    I ran into an issue with rpmlint complaining about missing chkconfig calls:
    
    ```
    The package contains an init script but doesn't contain a %post with a call to
    chkconfig
    ```
    
    I believe this is benign because Ambari managements the REST application lifecycle but I can't figure out how to suppress them yet.  Also considering adding a couple lines to the metron-rest README that references the MPack install path.  Credentials for the REST app are "user/password" (will also add that to the metron-rest README).
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron (Incubating).  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      bin/generate-md.sh
      mvn site:site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommened that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-795

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #500
    
----
commit 033988cbbfa4b5b061221d4e6d9d255aa3bc9596
Author: merrimanr <me...@gmail.com>
Date:   2017-03-24T00:45:38Z

    added metron-rest to rpm

commit 5bd738b2681f2f4b2ff1b6e620ee047c679c7c7a
Author: merrimanr <me...@gmail.com>
Date:   2017-03-24T01:06:50Z

    Fixed Provides

commit 2b1c88832254e4509e1bcd7e91c8ccb01f731a26
Author: merrimanr <me...@gmail.com>
Date:   2017-03-30T19:04:51Z

    Initial commit for METRON-795

commit 3fd0a5e6e7db2c40dde9e45f39685c13c04873f0
Author: merrimanr <me...@gmail.com>
Date:   2017-03-30T20:40:21Z

    Merge remote-tracking branch 'mirror/master' into METRON-795

----


> Install Metron REST with Ambari MPack
> -------------------------------------
>
>                 Key: METRON-795
>                 URL: https://issues.apache.org/jira/browse/METRON-795
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>
> The REST application should be included in the Ambari MPack.  This task includes creating a RPM file for the metron-rest module and installing it via Ambari MPack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)