[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1635: MINIFICPP-2185 Upgrade to Visual Studio 2022

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1635:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1635#discussion_r1302845569


##########
libminifi/include/core/PropertyType.h:
##########
@@ -138,7 +138,7 @@ class IntegerPropertyType : public PropertyType {
 
   [[nodiscard]] ValidationResult validate(const std::string &subject, const std::string &input) const override {
     try {
-      std::stoi(input);
+      (void) std::stoi(input);

Review Comment:
   `[[maybe_unused]]` needs a variable (or function etc) name, so it would be
   ```c++
       [[maybe_unused]] auto unused = std::stoi(input);
   ```
   Do you think that's better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org