You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/19 18:13:14 UTC

[GitHub] [tvm] jroesch commented on a change in pull request #9980: WIP: [VirtualMachine] fix raw pointer using by VirtualMachine

jroesch commented on a change in pull request #9980:
URL: https://github.com/apache/tvm/pull/9980#discussion_r788017534



##########
File path: include/tvm/runtime/object.h
##########
@@ -372,8 +372,8 @@ class ObjectPtr {
   template <typename U>
   ObjectPtr(const ObjectPtr<U>& other)  // NOLINT(*)
       : ObjectPtr(other.data_) {
-    static_assert(std::is_base_of<T, U>::value,
-                  "can only assign of child class ObjectPtr to parent");

Review comment:
       Agree with TQ this should not be remove




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org