You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/06/07 06:05:14 UTC
[bookkeeper] branch master updated:
RegionAwareEnsemblePlacementPolicy class should use super class's
minNumRacksPerWriteQuorum variable
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new b8a5289 RegionAwareEnsemblePlacementPolicy class should use super class's minNumRacksPerWriteQuorum variable
b8a5289 is described below
commit b8a5289a968e4afca2b7ef557fd978234c162b2f
Author: cguttapalem <cg...@salesforce.com>
AuthorDate: Wed Jun 6 23:05:07 2018 -0700
RegionAwareEnsemblePlacementPolicy class should use super class's minNumRacksPerWriteQuorum variable
Descriptions of the changes in this PR:
RegionAwareEnsemblePlacementPolicy class should use minNumRacksPerWriteQuorum
variable which is declared in its super class - RackawareEnsemblePlacementPolicyImpl,
since it is related to its super class.
Author: cguttapalem <cg...@salesforce.com>
Reviewers: Sijie Guo <si...@apache.org>
This closes #1484 from reddycharan/fixregpp
---
.../apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java | 2 +-
.../apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
index 92f8701..7416372 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
@@ -79,7 +79,7 @@ public class RackawareEnsemblePlacementPolicyImpl extends TopologyAwareEnsembleP
int maxWeightMultiple;
private Map<BookieNode, WeightedObject> bookieInfoMap = new HashMap<BookieNode, WeightedObject>();
private WeightedRandomSelection<BookieNode> weightedSelection;
- private int minNumRacksPerWriteQuorum;
+ protected int minNumRacksPerWriteQuorum;
public static final String REPP_DNS_RESOLVER_CLASS = "reppDnsResolverClass";
public static final String REPP_RANDOM_READ_REORDERING = "ensembleRandomReadReordering";
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java
index 6e2e742..6205174 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java
@@ -75,7 +75,6 @@ public class RegionAwareEnsemblePlacementPolicy extends RackawareEnsemblePlaceme
protected boolean enableValidation = true;
protected boolean enforceDurabilityInReplace = false;
protected Feature disableDurabilityFeature;
- protected int minNumRacksPerWriteQuorum;
RegionAwareEnsemblePlacementPolicy() {
super();
@@ -203,7 +202,6 @@ public class RegionAwareEnsemblePlacementPolicy extends RackawareEnsemblePlaceme
conf.getString(REPP_DISABLE_DURABILITY_FEATURE_NAME,
BookKeeperConstants.FEATURE_REPP_DISABLE_DURABILITY_ENFORCEMENT));
}
- this.minNumRacksPerWriteQuorum = conf.getMinNumRacksPerWriteQuorum();
return this;
}
--
To stop receiving notification emails like this one, please contact
sijie@apache.org.