You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2013/01/10 18:24:13 UTC
[jira] [Closed] (WICKET-4963) ComponentModel "setObject" methods
should take generic "T" type instead of "Object"
[ https://issues.apache.org/jira/browse/WICKET-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier closed WICKET-4963.
------------------------------
Resolution: Fixed
Fix Version/s: 6.5.0
Now completely generified. Thanks!
> ComponentModel "setObject" methods should take generic "T" type instead of "Object"
> -----------------------------------------------------------------------------------
>
> Key: WICKET-4963
> URL: https://issues.apache.org/jira/browse/WICKET-4963
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.4.0
> Reporter: Ota Hauptmann
> Priority: Trivial
> Fix For: 6.5.0
>
>
> ComponentModel implements public final void setObject(Object object), although the parameter should be "T object". This expansion of type seems to be useless and it looks like forgotten piece of code from Wicket version which did not support generics.
> The same issue is with protected setObject(Component component, Object object) and the private inner WrapModel.
> Note: This issue also causes an issue with IntelliJ IDEA, which reports a method clash of ComponentModel and IModel because of same erasure (when creating a subclass of ComponentModel). It is possibly IDEA bug, because compilers have no problem with it, but it doesn't change the fact that the setObject signature is at least strange.
> I have tried to find this in JIRA, but unsuccessfully (so please accept my apologies whether I missed it only). The only "info" I have found was this: http://osdir.com/ml/users-wicket.apache.org/2009-05/msg01176.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira