[GitHub] [shardingsphere] sandynz commented on a change in pull request #15260: [issue-15259] upgrade snakeyaml due to cve

[GitBox <gi...@apache.org>]

sandynz commented on a change in pull request #15260:
URL: https://github.com/apache/shardingsphere/pull/15260#discussion_r805527808



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/yaml/engine/representer/processor/NoneYamlTupleProcessor.java
##########
@@ -43,6 +44,7 @@ private boolean isNullNode(final Node valueNode) {
     }
     
     private NodeTuple processNoneTuple(final NodeTuple noneTuple) {
-        return new NodeTuple(noneTuple.getKeyNode(), new ScalarNode(Tag.STR, "", null, null, null));
+        return new NodeTuple(noneTuple.getKeyNode(),
+                new ScalarNode(Tag.STR, "", null, null, DumperOptions.ScalarStyle.PLAIN));

Review comment:
       Could be in one line.

##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/yaml/engine/fixture/YamlTupleProcessorFixture.java
##########
@@ -33,6 +34,7 @@ public String getTupleName() {
     @Override
     public NodeTuple process(final NodeTuple nodeTuple) {
         String value = ((ScalarNode) nodeTuple.getValueNode()).getValue();
-        return "null".equals(value) ? null : new NodeTuple(nodeTuple.getKeyNode(), new ScalarNode(Tag.STR, String.join("_", "converted", value), null, null, null));
+        return "null".equals(value) ? null : new NodeTuple(nodeTuple.getKeyNode(),
+                new ScalarNode(Tag.STR, String.join("_", "converted", value), null, null, DumperOptions.ScalarStyle.PLAIN));

Review comment:
       Could be in one line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org