You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/09/08 19:13:21 UTC

[GitHub] spark pull request #21273: [SPARK-17916][SQL] Fix empty string being parsed ...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21273#discussion_r216138533
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala ---
    @@ -164,7 +164,7 @@ class CSVOptions(
         writerSettings.setIgnoreLeadingWhitespaces(ignoreLeadingWhiteSpaceFlagInWrite)
         writerSettings.setIgnoreTrailingWhitespaces(ignoreTrailingWhiteSpaceFlagInWrite)
         writerSettings.setNullValue(nullValue)
    -    writerSettings.setEmptyValue(nullValue)
    +    writerSettings.setEmptyValue("\"\"")
    --- End diff --
    
    This needs an update in migration guide. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org