You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jrmccluskey (via GitHub)" <gi...@apache.org> on 2023/08/01 20:24:07 UTC
[GitHub] [beam] jrmccluskey commented on a diff in pull request #27703: [#24789] Make Prism the default Go SDK runner.
jrmccluskey commented on code in PR #27703:
URL: https://github.com/apache/beam/pull/27703#discussion_r1281115878
##########
sdks/go/test/integration/integration.go:
##########
@@ -136,6 +136,39 @@ var portableFilters = []string{
"TestSetStateClear",
}
+// TODO(lostluck): set up a specific run for these.
+var prismFilters = []string{
+ // The portable runner does not support the TestStream primitive
Review Comment:
```suggestion
// The prism runner does not support the TestStream primitive
```
##########
sdks/go/test/integration/integration.go:
##########
@@ -136,6 +136,39 @@ var portableFilters = []string{
"TestSetStateClear",
}
+// TODO(lostluck): set up a specific run for these.
+var prismFilters = []string{
+ // The portable runner does not support the TestStream primitive
+ "TestTestStream.*",
+ // The trigger and pane tests uses TestStream
+ "TestTrigger.*",
+ "TestPanes",
+ // TODO(https://github.com/apache/beam/issues/21058): Python portable runner times out on Kafka reads.
+ "TestKafkaIO.*",
+ // TODO(BEAM-13215): GCP IOs currently do not work in non-Dataflow portable runners.
+ "TestBigQueryIO.*",
+ "TestSpannerIO.*",
+ // The portable runner does not support self-checkpointing
+ "TestCheckpointing",
+ // The portable runner does not support pipeline drain for SDF.
+ "TestDrain",
+ // FhirIO currently only supports Dataflow runner
+ "TestFhirIO.*",
+ // OOMs currently only lead to heap dumps on Dataflow runner
+ "TestOomParDo",
+ // The portable runner does not support user state.
Review Comment:
```suggestion
// The prism runner does not support user state.
```
##########
sdks/go/test/integration/integration.go:
##########
@@ -136,6 +136,39 @@ var portableFilters = []string{
"TestSetStateClear",
}
+// TODO(lostluck): set up a specific run for these.
+var prismFilters = []string{
+ // The portable runner does not support the TestStream primitive
+ "TestTestStream.*",
+ // The trigger and pane tests uses TestStream
+ "TestTrigger.*",
+ "TestPanes",
+ // TODO(https://github.com/apache/beam/issues/21058): Python portable runner times out on Kafka reads.
+ "TestKafkaIO.*",
+ // TODO(BEAM-13215): GCP IOs currently do not work in non-Dataflow portable runners.
+ "TestBigQueryIO.*",
+ "TestSpannerIO.*",
+ // The portable runner does not support self-checkpointing
+ "TestCheckpointing",
+ // The portable runner does not support pipeline drain for SDF.
Review Comment:
```suggestion
// The prism runner does not support pipeline drain for SDF.
```
##########
sdks/go/test/integration/integration.go:
##########
@@ -136,6 +136,39 @@ var portableFilters = []string{
"TestSetStateClear",
}
+// TODO(lostluck): set up a specific run for these.
+var prismFilters = []string{
+ // The portable runner does not support the TestStream primitive
+ "TestTestStream.*",
+ // The trigger and pane tests uses TestStream
+ "TestTrigger.*",
+ "TestPanes",
+ // TODO(https://github.com/apache/beam/issues/21058): Python portable runner times out on Kafka reads.
Review Comment:
If this issue is present for prism you'll want a more specific error message
##########
sdks/go/test/integration/integration.go:
##########
@@ -136,6 +136,39 @@ var portableFilters = []string{
"TestSetStateClear",
}
+// TODO(lostluck): set up a specific run for these.
+var prismFilters = []string{
+ // The portable runner does not support the TestStream primitive
+ "TestTestStream.*",
+ // The trigger and pane tests uses TestStream
+ "TestTrigger.*",
+ "TestPanes",
+ // TODO(https://github.com/apache/beam/issues/21058): Python portable runner times out on Kafka reads.
+ "TestKafkaIO.*",
+ // TODO(BEAM-13215): GCP IOs currently do not work in non-Dataflow portable runners.
+ "TestBigQueryIO.*",
+ "TestSpannerIO.*",
+ // The portable runner does not support self-checkpointing
Review Comment:
```suggestion
// The prism runner does not support self-checkpointing
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org