You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "kz930 (via GitHub)" <gi...@apache.org> on 2026/09/02 23:31:53 UTC
[PR] test(verify): give every operator the same table to read [texera]
kz930 opened a new pull request, #8360:
URL: https://github.com/apache/texera/pull/8360
### What changes were proposed in this PR?
One table, thirty-four columns and fifteen rows, holding a column of every
type an operator can ask for and the awkward values each type admits: an empty
cell, a zero, a negative, a string that looks like a number, a date at a
boundary.
An operator that needs something the table cannot hold — a pair of tables
sharing a key, a numeric projection — names a projection of it rather than a
fixture of its own, so what every operator reads stays one thing.
### Any related issues, documentation, discussions?
Part of #8325, 6 of 15. It builds on #8327, which adds the trait and the translator, and on the verification pieces before it; each is sized to be read in one sitting rather than landing as one diff.
### How was this PR tested?
The tests in this change cover it. The whole set is exercised together once the last piece lands: every operator run through the engine and through its generated script, and the two answers compared.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(verify): give every operator the same table to read [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #8360:
URL: https://github.com/apache/texera/pull/8360#issuecomment-5767860572
Can you explain why do we need this change here? Why aren't they under the test folder? How is verify different from test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(verify): give every operator the same table to read [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8360:
URL: https://github.com/apache/texera/pull/8360#issuecomment-5517992251
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8360?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 94.11%. Comparing base ([`7976744`](https://app.codecov.io/gh/apache/texera/commit/797674477846b722cccd926b8928b3514b6a5993?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`52052df`](https://app.codecov.io/gh/apache/texera/commit/52052df84f2a7dae6c3ce7cc8426644d18e3c4f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8360 +/- ##
=========================================
Coverage 94.11% 94.11%
Complexity 4811 4811
=========================================
Files 1197 1197
Lines 48813 48813
Branches 5906 5906
=========================================
Hits 45939 45939
Misses 1420 1420
Partials 1454 1454
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [7976744](https://app.codecov.io/gh/apache/texera/commit/797674477846b722cccd926b8928b3514b6a5993?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.08% <ø> (ø)` | | Carriedforward from [7976744](https://app.codecov.io/gh/apache/texera/commit/797674477846b722cccd926b8928b3514b6a5993?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.00% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [7976744](https://app.codecov.io/gh/apache/texera/commit/797674477846b722cccd926b8928b3514b6a5993?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.86% <ø> (ø)` | | Carriedforward from [7976744](https://app.codecov.io/gh/apache/texera/commit/797674477846b722cccd926b8928b3514b6a5993?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.47% <ø> (ø)` | | Carriedforward from [7976744](https://app.codecov.io/gh/apache/texera/commit/797674477846b722cccd926b8928b3514b6a5993?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [7976744](https://app.codecov.io/gh/apache/texera/commit/797674477846b722cccd926b8928b3514b6a5993?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8360?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(verify): give every operator the same table to read [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8360:
URL: https://github.com/apache/texera/pull/8360#issuecomment-5517948915
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(verify): give every operator the same table to read [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #8360:
URL: https://github.com/apache/texera/pull/8360#issuecomment-5768188880
They are under the test folder. The path is `workflow-compiling-service/src/test/scala/org/apache/texera/amber/translator/verify/`, with its fixture in `src/test/resources/verify/`; `verify` is a package inside the test tree, not a separate source root, and nothing in it ships in main.
What it holds is ScalaTest specs like any other, with one difference in what they assert. The rest of the translator tests check the generated Python *text*. These run each operator twice, once through the Texera executor and once through its generated standalone script, and compare the two answers. That forks a real Python process, so those specs carry `@IntegrationTest` and CI routes them to a Python-provisioned job.
This PR is the input side of that: one table every operator reads, so a comparison is between two runs over the same data rather than two hand-written inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(verify): give every operator the same table to read [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8360:
URL: https://github.com/apache/texera/pull/8360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(verify): give every operator the same table to read [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #8360:
URL: https://github.com/apache/texera/pull/8360#issuecomment-5627932222
Carlos, this moved after your approval: seven fixture columns were renamed to hostile spellings, the canonical table gained a boolean column, and a fixture can now write the same columns with no rows under them. Would you take another look when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org