[GitHub] [kafka] omkreddy commented on a change in pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

[GitBox <gi...@apache.org>]

omkreddy commented on a change in pull request #8992:
URL: https://github.com/apache/kafka/pull/8992#discussion_r452092180



##########
File path: core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala
##########
@@ -74,48 +75,58 @@ class SaslClientsWithInvalidCredentialsTest extends IntegrationTestHarness with
   @Test
   def testProducerWithAuthenticationFailure(): Unit = {
     val producer = createProducer()
-    verifyAuthenticationException(sendOneRecord(producer, maxWaitMs = 10000))
-    verifyAuthenticationException(producer.partitionsFor(topic))
+    try {
+      verifyAuthenticationException(sendOneRecord(producer, maxWaitMs = 10000))
+      verifyAuthenticationException(producer.partitionsFor(topic))
 
-    createClientCredential()
-    verifyWithRetry(sendOneRecord(producer))
+      createClientCredential()
+      verifyWithRetry(sendOneRecord(producer))
+    } finally producer.close()

Review comment:
       @akatona84 Thanks for the PR.  Normally producer/consumer instances created in the test are closed in [IntegrationTestHarness.tearDown ](https://github.com/confluentinc/ce-kafka/blob/master/core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala#L152). many core tests extends `IntegrationTestHarness` class.
   Do we know, which tests were failed? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org