[jira] [Commented] (IGNITE-7222) DiscoverySpi based on Apache ZooKeeper

["Alexey Goncharuk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430281#comment-16430281 ] 

Alexey Goncharuk commented on IGNITE-7222:
------------------------------------------

Guys,

I see several TODOs left in the code, we should either fix them or create corresponding tickets with meaningful description before merge:
1) org.apache.ignite.spi.discovery.zk.internal.ZkDistributedCollectDataFuture#deleteFutureData
There is a swallowed exception, this should be fixed before merge
2) org.apache.ignite.spi.discovery.zk.internal.ZookeeperClient#requestOverhead
3) org.apache.ignite.spi.discovery.zk.internal.ZookeeperClient#createAll
4) org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoveryImpl#startJoin
5) org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoveryImpl#createAckEvent
6) org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoverySpiTest#checkZkNodesCleanup - Not sure what this TODO means.

 * ZkRuntimeState contains a bunch of package-private fields, however it looks like it used as a POJO. It it necessary or can it be replaced with getters/setters? Does not look in line with other Ignite code style
* ZookeeperDiscoveriSpiTest contains commented checks in afterTest. It should be either uncommented or removed

Also, since zookeeper discovery SPI is a public API class, it should be documented the same way as TcpDiscoverySpi, plus we need documentation on readme.io. Please create two separate tickets for this.

> DiscoverySpi based on Apache ZooKeeper
> --------------------------------------
>
>                 Key: IGNITE-7222
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7222
>             Project: Ignite
>          Issue Type: Task
>          Components: general
>            Reporter: Semen Boikov
>            Assignee: Semen Boikov
>            Priority: Major
>              Labels: iep-15
>             Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)