[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or cleanup

["Anthony Giardullo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670203#action_12670203 ] 

Anthony Giardullo commented on THRIFT-292:
------------------------------------------

I agree that it is much cleaner to remove this generated code.  However, the Makefiles now need to be changed in order to generate this code.  Currently, fb303 does not build (it will complain that 'py/fb303' is not found).  Even if I configure fb303 to generate the python code(ie --with-py), it will get generated in a different directory than the makefile expects.

fb303 is a dependency for Scribe (https://sourceforge.net/projects/scribeserver/), so I would appreciate it if we can fix fb303 so that it builds successfully.


> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
>                 Key: THRIFT-292
>                 URL: https://issues.apache.org/jira/browse/THRIFT-292
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Greg Stein
>            Priority: Blocker
>             Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.