You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by an...@apache.org on 2006/11/14 17:20:27 UTC

svn commit: r474851 - in /lenya/trunk/src/impl: java/org/apache/lenya/cms/publication/DocumentImpl.java java/org/apache/lenya/cms/publication/DocumentManagerImpl.java test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java

Author: andreas
Date: Tue Nov 14 08:20:26 2006
New Revision: 474851

URL: http://svn.apache.org/viewvc?view=rev&rev=474851
Log:
[minor change] updated javadocs

Modified:
    lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
    lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
    lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java

Modified: lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java?view=diff&rev=474851&r1=474850&r2=474851
==============================================================================
--- lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java (original)
+++ lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java Tue Nov 14 08:20:26 2006
@@ -598,7 +598,4 @@
         return this.area;
     }
 
-    public InputStream getInputStream() throws RepositoryException {
-        return getRepositoryNode().getInputStream();
-    }
 }

Modified: lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java?view=diff&rev=474851&r1=474850&r2=474851
==============================================================================
--- lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java (original)
+++ lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java Tue Nov 14 08:20:26 2006
@@ -817,8 +817,8 @@
         return document;
     }
 
-    public Document duplicateVersion(Document sourceDocument, String area, String language)
-    throws DocumentBuildException, DocumentException, PublicationException {
+    protected Document duplicateVersion(Document sourceDocument, String area, String language)
+            throws DocumentBuildException, DocumentException, PublicationException {
         Document document = add(sourceDocument.getFactory(),
                 sourceDocument.getResourceType(),
                 sourceDocument.getUUID(),
@@ -828,7 +828,6 @@
                 language,
                 sourceDocument.getSourceExtension());
         duplicateMetaData(sourceDocument, document);
-        
         return document;
     }
 

Modified: lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java?view=diff&rev=474851&r1=474850&r2=474851
==============================================================================
--- lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java (original)
+++ lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java Tue Nov 14 08:20:26 2006
@@ -27,12 +27,10 @@
 import org.apache.lenya.cms.publication.DocumentUtil;
 import org.apache.lenya.cms.publication.Publication;
 import org.apache.lenya.cms.publication.PublicationException;
-import org.apache.lenya.cms.publication.PublicationUtil;
 import org.apache.lenya.cms.repository.RepositoryUtil;
 import org.apache.lenya.cms.repository.Session;
 import org.apache.lenya.cms.site.SiteManager;
 import org.apache.lenya.cms.site.SiteStructure;
-import org.apache.lenya.cms.site.SiteUtil;
 import org.apache.lenya.transaction.TransactionException;
 
 /**
@@ -40,6 +38,12 @@
  */
 public class XLinkCollectionTest extends AbstractAccessControlTest {
 
+    /**
+     * @throws PublicationException
+     * @throws AccessControlException
+     * @throws TransactionException
+     * @throws ServiceException
+     */
     public void testXLinkCollection() throws PublicationException, AccessControlException,
             TransactionException, ServiceException {
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org


Re: svn commit: r474851 - in /lenya/trunk/src/impl: java/org/apache/lenya/cms/publication/DocumentImpl.java java/org/apache/lenya/cms/publication/DocumentManagerImpl.java test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java

Posted by Andreas Hartmann <an...@apache.org>.
Joern Nettingsmeier schrieb:
> looks like there is at least one functional change...
> accidental commit or wrong commit note?

Apparently I removed a method that was never used - the commit
note was not complete.

-- Andreas

> 
> andreas@apache.org wrote:
>> Author: andreas
>> Date: Tue Nov 14 08:20:26 2006
>> New Revision: 474851
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=474851
>> Log:
>> [minor change] updated javadocs
>>
>> Modified:
>>    
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
>>
>>    
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
>>
>>    
>> lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java
>>
>>
>> Modified:
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
>>
>> URL:
>> http://svn.apache.org/viewvc/lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java?view=diff&rev=474851&r1=474850&r2=474851
>>
>> ==============================================================================
>>
>> ---
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
>> (original)
>> +++
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
>> Tue Nov 14 08:20:26 2006
>> @@ -598,7 +598,4 @@
>>          return this.area;
>>      }
>>  
>> -    public InputStream getInputStream() throws RepositoryException {
>> -        return getRepositoryNode().getInputStream();
>> -    }
>>  }
>>
>> Modified:
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
>>
>> URL:
>> http://svn.apache.org/viewvc/lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java?view=diff&rev=474851&r1=474850&r2=474851
>>
>> ==============================================================================
>>
>> ---
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
>> (original)
>> +++
>> lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
>> Tue Nov 14 08:20:26 2006
>> @@ -817,8 +817,8 @@
>>          return document;
>>      }
>>  
>> -    public Document duplicateVersion(Document sourceDocument, String
>> area, String language)
>> -    throws DocumentBuildException, DocumentException,
>> PublicationException {
>> +    protected Document duplicateVersion(Document sourceDocument,
>> String area, String language)
>> +            throws DocumentBuildException, DocumentException,
>> PublicationException {
>>          Document document = add(sourceDocument.getFactory(),
>>                  sourceDocument.getResourceType(),
>>                  sourceDocument.getUUID(),
>> @@ -828,7 +828,6 @@
>>                  language,
>>                  sourceDocument.getSourceExtension());
>>          duplicateMetaData(sourceDocument, document);
>> -                 return document;
>>      }
>>  
>>
>> Modified:
>> lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java
>>
>> URL:
>> http://svn.apache.org/viewvc/lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java?view=diff&rev=474851&r1=474850&r2=474851
>>
>> ==============================================================================
>>
>> ---
>> lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java
>> (original)
>> +++
>> lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java
>> Tue Nov 14 08:20:26 2006
>> @@ -27,12 +27,10 @@
>>  import org.apache.lenya.cms.publication.DocumentUtil;
>>  import org.apache.lenya.cms.publication.Publication;
>>  import org.apache.lenya.cms.publication.PublicationException;
>> -import org.apache.lenya.cms.publication.PublicationUtil;
>>  import org.apache.lenya.cms.repository.RepositoryUtil;
>>  import org.apache.lenya.cms.repository.Session;
>>  import org.apache.lenya.cms.site.SiteManager;
>>  import org.apache.lenya.cms.site.SiteStructure;
>> -import org.apache.lenya.cms.site.SiteUtil;
>>  import org.apache.lenya.transaction.TransactionException;
>>  
>>  /**
>> @@ -40,6 +38,12 @@
>>   */
>>  public class XLinkCollectionTest extends AbstractAccessControlTest {
>>  
>> +    /**
>> +     * @throws PublicationException
>> +     * @throws AccessControlException
>> +     * @throws TransactionException
>> +     * @throws ServiceException
>> +     */
>>      public void testXLinkCollection() throws PublicationException,
>> AccessControlException,
>>              TransactionException, ServiceException {
>>  
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
>> For additional commands, e-mail: commits-help@lenya.apache.org
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r474851 - in /lenya/trunk/src/impl: java/org/apache/lenya/cms/publication/DocumentImpl.java java/org/apache/lenya/cms/publication/DocumentManagerImpl.java test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java

Posted by Joern Nettingsmeier <ne...@folkwang-hochschule.de>.
looks like there is at least one functional change...
accidental commit or wrong commit note?

andreas@apache.org wrote:
> Author: andreas
> Date: Tue Nov 14 08:20:26 2006
> New Revision: 474851
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=474851
> Log:
> [minor change] updated javadocs
> 
> Modified:
>     lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
>     lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
>     lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java
> 
> Modified: lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java
> URL: http://svn.apache.org/viewvc/lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java?view=diff&rev=474851&r1=474850&r2=474851
> ==============================================================================
> --- lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java (original)
> +++ lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentImpl.java Tue Nov 14 08:20:26 2006
> @@ -598,7 +598,4 @@
>          return this.area;
>      }
>  
> -    public InputStream getInputStream() throws RepositoryException {
> -        return getRepositoryNode().getInputStream();
> -    }
>  }
> 
> Modified: lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java
> URL: http://svn.apache.org/viewvc/lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java?view=diff&rev=474851&r1=474850&r2=474851
> ==============================================================================
> --- lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java (original)
> +++ lenya/trunk/src/impl/java/org/apache/lenya/cms/publication/DocumentManagerImpl.java Tue Nov 14 08:20:26 2006
> @@ -817,8 +817,8 @@
>          return document;
>      }
>  
> -    public Document duplicateVersion(Document sourceDocument, String area, String language)
> -    throws DocumentBuildException, DocumentException, PublicationException {
> +    protected Document duplicateVersion(Document sourceDocument, String area, String language)
> +            throws DocumentBuildException, DocumentException, PublicationException {
>          Document document = add(sourceDocument.getFactory(),
>                  sourceDocument.getResourceType(),
>                  sourceDocument.getUUID(),
> @@ -828,7 +828,6 @@
>                  language,
>                  sourceDocument.getSourceExtension());
>          duplicateMetaData(sourceDocument, document);
> -        
>          return document;
>      }
>  
> 
> Modified: lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java
> URL: http://svn.apache.org/viewvc/lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java?view=diff&rev=474851&r1=474850&r2=474851
> ==============================================================================
> --- lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java (original)
> +++ lenya/trunk/src/impl/test/org/apache/lenya/cms/publication/util/XLinkCollectionTest.java Tue Nov 14 08:20:26 2006
> @@ -27,12 +27,10 @@
>  import org.apache.lenya.cms.publication.DocumentUtil;
>  import org.apache.lenya.cms.publication.Publication;
>  import org.apache.lenya.cms.publication.PublicationException;
> -import org.apache.lenya.cms.publication.PublicationUtil;
>  import org.apache.lenya.cms.repository.RepositoryUtil;
>  import org.apache.lenya.cms.repository.Session;
>  import org.apache.lenya.cms.site.SiteManager;
>  import org.apache.lenya.cms.site.SiteStructure;
> -import org.apache.lenya.cms.site.SiteUtil;
>  import org.apache.lenya.transaction.TransactionException;
>  
>  /**
> @@ -40,6 +38,12 @@
>   */
>  public class XLinkCollectionTest extends AbstractAccessControlTest {
>  
> +    /**
> +     * @throws PublicationException
> +     * @throws AccessControlException
> +     * @throws TransactionException
> +     * @throws ServiceException
> +     */
>      public void testXLinkCollection() throws PublicationException, AccessControlException,
>              TransactionException, ServiceException {
>  
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
> For additional commands, e-mail: commits-help@lenya.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org