You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sureshsubbiah <gi...@git.apache.org> on 2015/10/22 00:57:13 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1549] [TRAFODION-1550...
GitHub user sureshsubbiah opened a pull request:
https://github.com/apache/incubator-trafodion/pull/140
[TRAFODION-1549] [TRAFODION-1550]
TRAFODION-1549 : Extends event_log_reader TMUDF to read DCS logs and overflow files from all components
TRAFODION-1550 : Improves performance of bulkloader by determining flush size based on row length
Other changes
Rework for TRAFODION-1279 suggested by Hans and not addressed in previous pull request
Rework for TRAFODION-1474 for a regression found by Weishiun Tsai
Fix for regress/hive/TEST020 occasional failure on build machine
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshsubbiah/incubator-trafodion jira_bugs4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #140
----
commit f8e41b956a8316c9847f36ea8c49746a99949b99
Author: Suresh Subbiah <su...@apache.org>
Date: 2015-10-21T22:53:57Z
[TRAFODION-1549] [TRAFODION-1550]
TRAFODION-1549 : Extends event_log_reader TMUDF to read DCS logs and overflow files from all components
TRAFODION-1550 : Improves performance of bulkloader by determining flush size based on row length
Other changes
Rework for TRAFODION-1279 suggested by Hans and not addressed in previous pull request
Rework for TRAFODION-1474 for a regression found by Weishiun Tsai
Fix for regress/hive/TEST020 occasional failure on build machine
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1549] [TRAFODION-1550...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/140#discussion_r42891264
--- Diff: core/sql/regress/hive/EXPECTED020 ---
@@ -132,24 +147,25 @@ S_STORE_SK (EXPR)
--- 1 row(s) selected.
>>
>>-- explain of join between 2 ORC tables
->>explain options 'f' select x.s_suite_number, y.s_street_name
+>>prepare XX from select x.s_suite_number, y.s_street_name
+> from hive.hive.store_orc x, hive.hive.store_orc y
+> where x.s_store_sk = y.s_store_sk;
-LC RC OP OPERATOR OPT DESCRIPTION CARD
----- ---- ---- -------------------- -------- -------------------- ---------
+--- SQL command prepared.
+>>execute explainIt;
-3 . 4 root 8.17E+004
-2 1 3 hybrid_hash_join 8.17E+004
-. . 2 hive_scan STORE_ORC 4.08E+003
-. . 1 hive_scan STORE_ORC 4.08E+003
+S OPERATOR LC RC TAB_NAME
+-- ---------------- -- -- ----------
---- SQL operation complete.
+04 ROOT 3 ?
+03 HYBRID_HASH_JOIN 2 1
+02 HIVE_SCAN ? ? .STORE_ORC
--- End diff --
Did you want the dot in front of the table name? (possible off-by-one error in the explainIt query text?) Can fix it later if desired.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1549] [TRAFODION-1550...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1549] [TRAFODION-1550...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/140#discussion_r42901300
--- Diff: core/sql/executor/ExHbaseAccess.h ---
@@ -342,10 +342,10 @@ class ExHbaseAccessTcb : public ex_tcb
void setRowID(char *rowId, Lng32 rowIdLen);
void allocateDirectBufferForJNI(UInt32 rowLen);
void allocateDirectRowBufferForJNI(short numCols,
- short maxRows = 1);
+ UInt16 maxRows = 1);
--- End diff --
This can't be changed to Unsigned because this number is sent to Java. There is no unsigned concept in java. Basically, we can't send more than 32767 rows in one buffer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---