You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/03 09:50:49 UTC
[GitHub] [inlong] thesumery opened a new pull request, #7134: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
thesumery opened a new pull request, #7134:
URL: https://github.com/apache/inlong/pull/7134
[INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
- Fixes #7089
### Motivation
*Separate the concept of node tag from the node table and extract the concept of task group*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #7134:
URL: https://github.com/apache/inlong/pull/7134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062252527
##########
inlong-manager/manager-test/src/main/resources/h2/apache_inlong_manager.sql:
##########
@@ -330,7 +330,7 @@ CREATE TABLE IF NOT EXISTS `stream_source`
`uuid` varchar(30) DEFAULT NULL COMMENT 'Mac uuid of the agent running the task',
`data_node_name` varchar(128) DEFAULT NULL COMMENT 'Node name, which links to data_node table',
`inlong_cluster_name` varchar(128) DEFAULT NULL COMMENT 'Cluster name of the agent running the task',
- `inlong_cluster_node_tag` varchar(512) DEFAULT NULL COMMENT 'Cluster node tag',
+ `inlong_cluster_node_group` varchar(512) DEFAULT NULL COMMENT 'Cluster node label',
Review Comment:
label -- > group
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/impl/AgentServiceTest.java:
##########
@@ -203,8 +203,8 @@ public void testTagMatch() {
saveSource("tag2,tag3");
saveSource("tag2,tag3");
saveSource("tag4");
- bindTag(true, "tag1");
- bindTag(true, "tag2");
+ bindGroup(true, "tag1");
Review Comment:
tag1 -- > group1
##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -347,7 +347,7 @@ CREATE TABLE IF NOT EXISTS `stream_source`
`uuid` varchar(30) DEFAULT NULL COMMENT 'Mac uuid of the agent running the task',
`data_node_name` varchar(128) DEFAULT NULL COMMENT 'Node name, which links to data_node table',
`inlong_cluster_name` varchar(128) DEFAULT NULL COMMENT 'Cluster name of the agent running the task',
- `inlong_cluster_node_tag` varchar(512) DEFAULT NULL COMMENT 'Cluster node tag',
+ `inlong_cluster_node_group` varchar(512) DEFAULT NULL COMMENT 'Cluster node label',
Review Comment:
label --> group
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/impl/AgentServiceTest.java:
##########
@@ -310,15 +310,15 @@ public void testRematchedWhenSuspend() {
@Test
public void testMismatchedWhenRestart() {
final Pair<String, String> groupStream = saveSource("tag1,tag3");
- bindTag(true, "tag1");
+ bindGroup(true, "tag1");
agent.pullTask();
agent.pullTask(); // report last success status
// suspend and restart
suspendSource(groupStream.getLeft(), groupStream.getRight());
restartSource(groupStream.getLeft(), groupStream.getRight());
- bindTag(false, "tag1");
+ bindGroup(false, "tag1");
Review Comment:
tag1 --> group1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7134: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1060433258
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/InlongLabelEntity.java:
##########
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import java.io.Serializable;
+import java.util.Date;
+
+public class InlongLabelEntity implements Serializable {
Review Comment:
Suggest to use `@Data`, `@EqualsAndHashCode(callSuper = true)`, etc
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/InlongLabelNodeRelationEntity.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import java.io.Serializable;
+
+public class InlongLabelNodeRelationEntity implements Serializable {
Review Comment:
Suggest to use `@Data`, `@EqualsAndHashCode(callSuper = true)`, etc
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongLabelEntityMapper.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.mapper;
+
+import org.apache.inlong.manager.dao.entity.InlongLabelEntity;
+
Review Comment:
Add`@Repository`.
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongLabelNodeRelationEntityMapper.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.mapper;
+
+import org.apache.ibatis.annotations.Param;
+import org.apache.inlong.manager.dao.entity.InlongLabelNodeRelationEntity;
+
+import java.util.List;
+
Review Comment:
Add`@Repository.`
##########
inlong-manager/manager-dao/src/main/resources/mappers/InlongLabelEntityMapper.xml:
##########
@@ -0,0 +1,71 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
+<mapper namespace="org.apache.inlong.manager.dao.mapper.InlongLabelEntityMapper">
+ <resultMap id="BaseResultMap" type="org.apache.inlong.manager.dao.entity.InlongLabelEntity">
+ <id column="id" jdbcType="INTEGER" property="id" />
+ <result column="label_name" jdbcType="VARCHAR" property="labelName" />
+ <result column="description" jdbcType="VARCHAR" property="description" />
+ <result column="in_charges" jdbcType="VARCHAR" property="inCharges" />
+ <result column="is_deleted" jdbcType="INTEGER" property="isDeleted" />
+ <result column="creator" jdbcType="VARCHAR" property="creator" />
+ <result column="modifier" jdbcType="VARCHAR" property="modifier" />
+ <result column="create_time" jdbcType="TIMESTAMP" property="createTime" />
+ <result column="modify_time" jdbcType="TIMESTAMP" property="modifyTime" />
+ <result column="version" jdbcType="INTEGER" property="version" />
+ </resultMap>
+ <resultMap extends="BaseResultMap" id="ResultMapWithBLOBs" type="org.apache.inlong.manager.dao.entity.InlongLabelEntity">
+ <result column="ext_params" jdbcType="LONGVARCHAR" property="extParams" />
+ </resultMap>
+ <sql id="Base_Column_List">
+ id, label_name, description, in_charges, is_deleted, creator, modifier, create_time,
+ modify_time, version
+ </sql>
+ <sql id="Blob_Column_List">
Review Comment:
Why `ext_params` are not put together with other parameters？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #7134: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1060472648
##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -158,6 +158,40 @@ CREATE TABLE IF NOT EXISTS `inlong_cluster_node`
) ENGINE = InnoDB
DEFAULT CHARSET = utf8mb4 COMMENT ='Inlong cluster node table';
+-- ----------------------------
+-- Table structure for inlong_label
+-- ----------------------------
+CREATE TABLE IF NOT EXISTS `inlong_label`
Review Comment:
Label is a word with no clear meaning. Can you give it a clear name according to the characteristics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062030204
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongClusterController.java:
##########
@@ -228,11 +228,11 @@ public Response<Boolean> deleteNode(@PathVariable Integer id) {
return Response.success(clusterService.deleteNode(id, LoginUserUtils.getLoginUser().getName()));
}
- @RequestMapping(value = "/cluster/node/bindTag")
+ @RequestMapping(value = "/cluster/node/bindLabel")
Review Comment:
bindNodeLabel, not bindNodeTag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #7134: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1060471703
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongClusterController.java:
##########
@@ -228,11 +228,11 @@ public Response<Boolean> deleteNode(@PathVariable Integer id) {
return Response.success(clusterService.deleteNode(id, LoginUserUtils.getLoginUser().getName()));
}
- @RequestMapping(value = "/cluster/node/bindTag")
+ @RequestMapping(value = "/cluster/node/bindLabel")
Review Comment:
Should the operation of binding the label be a separate operation class?
It is only associated with the file agent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #7134: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #7134:
URL: https://github.com/apache/inlong/pull/7134#issuecomment-1370397565
Please update https://github.com/apache/inlong/blob/master/inlong-manager/manager-web/sql/changes-1.5.0.sql at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
thesumery commented on PR #7134:
URL: https://github.com/apache/inlong/pull/7134#issuecomment-1370430159
> Please update https://github.com/apache/inlong/blob/master/inlong-manager/manager-web/sql/changes-1.5.0.sql at the same time.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062027011
##########
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/HeartbeatManager.java:
##########
@@ -228,7 +228,7 @@ private HeartbeatMsg buildHeartbeatMsg() {
heartbeatMsg.setInCharges(inCharges);
}
if (StringUtils.isNotBlank(nodeTag)) {
- heartbeatMsg.setNodeTag(nodeTag);
+ heartbeatMsg.setNodeLabel(nodeTag);
Review Comment:
Can there be a clear meaning of the name?
tag and lab are too general
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #7134: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1061094333
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongClusterController.java:
##########
@@ -228,11 +228,11 @@ public Response<Boolean> deleteNode(@PathVariable Integer id) {
return Response.success(clusterService.deleteNode(id, LoginUserUtils.getLoginUser().getName()));
}
- @RequestMapping(value = "/cluster/node/bindTag")
+ @RequestMapping(value = "/cluster/node/bindLabel")
Review Comment:
At present, the label is not bound to the file agent forcibly, and its association is also bound to the node.
And the design of the label is not just for collection tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062136995
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/SourceRequest.java:
##########
@@ -72,8 +72,8 @@ public class SourceRequest {
@ApiModelProperty("Inlong cluster name")
private String inlongClusterName;
- @ApiModelProperty("Inlong cluster node tag")
- private String inlongClusterNodeTag;
+ @ApiModelProperty("Inlong cluster node label")
Review Comment:
Add explanation above. like @ApiModelProperty(value = "MQ resource", notes = "in inlong group, TubeMQ corresponds to Topic, Pulsar corresponds to Namespace").
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/cluster/ClusterNodeBindLabelRequest.java:
##########
@@ -29,11 +29,11 @@
*/
@Data
@ApiModel("Cluster node bind and unbind tag request")
-public class ClusterNodeBindTagRequest {
+public class ClusterNodeBindLabelRequest {
@NotBlank(message = "Cluster nodeTag cannot be blank")
@ApiModelProperty(value = "Cluster node tag")
Review Comment:
Add explanation above. like `@ApiModelProperty(value = "MQ resource", notes = "in inlong group, TubeMQ corresponds to Topic, Pulsar corresponds to Namespace")`
##########
inlong-common/src/main/java/org/apache/inlong/common/heartbeat/HeartbeatMsg.java:
##########
@@ -78,7 +78,7 @@ public class HeartbeatMsg {
/**
* Tag of node, separated by commas(,)
Review Comment:
Uniform annotation and method name.
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/StreamSourceLabelNodeRelationEntity.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+/**
+ * Inlong label node relation entity.
Review Comment:
Unified annotation and class name.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterService.java:
##########
@@ -393,7 +393,7 @@ List<ClusterNodeResponse> listNodeByGroupId(
* @param operator current operator
Review Comment:
Uniform annotation and method name.
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/inner/client/InlongClusterClient.java:
##########
@@ -304,7 +304,7 @@ public Boolean deleteNode(Integer id) {
* @param request cluster info to be modified
Review Comment:
Uniform annotation and method name.
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/StreamSourceLabelEntity.java:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+import java.util.Date;
+
+/**
+ * Inlong label entity.
Review Comment:
Unified annotation and class name.
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/InlongClusterApi.java:
##########
@@ -101,5 +101,5 @@ Call<Response<List<ClusterNodeResponse>>> listNodeByGroupId(@Query("inlongGroupI
Call<Response<Boolean>> deleteNode(@Path("id") Integer id);
@POST("cluster/node/bindTag")
Review Comment:
Uniform url and method name.
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/cluster/ClusterNodeBindLabelRequest.java:
##########
@@ -29,11 +29,11 @@
*/
@Data
@ApiModel("Cluster node bind and unbind tag request")
Review Comment:
Unified annotation and method name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062137741
##########
inlong-common/src/main/java/org/apache/inlong/common/heartbeat/HeartbeatMsg.java:
##########
@@ -78,7 +78,7 @@ public class HeartbeatMsg {
/**
* Tag of node, separated by commas(,)
Review Comment:
Unified annotation and attribute name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #7134: [INLONG-7089][Agent] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1060468067
##########
inlong-manager/manager-dao/pom.xml:
##########
@@ -114,6 +114,11 @@
<artifactId>postgresql</artifactId>
<version>${postgresql.version}</version>
</dependency>
+ <dependency>
Review Comment:
mysql-connector-java is LGPL, NEED PROVIDED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062049599
##########
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/HeartbeatManager.java:
##########
@@ -228,7 +228,7 @@ private HeartbeatMsg buildHeartbeatMsg() {
heartbeatMsg.setInCharges(inCharges);
}
if (StringUtils.isNotBlank(nodeTag)) {
- heartbeatMsg.setNodeTag(nodeTag);
+ heartbeatMsg.setNodeLabel(nodeTag);
Review Comment:
Table name has alreay embodied its meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062146712
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/InlongClusterApi.java:
##########
@@ -101,5 +101,5 @@ Call<Response<List<ClusterNodeResponse>>> listNodeByGroupId(@Query("inlongGroupI
Call<Response<Boolean>> deleteNode(@Path("id") Integer id);
@POST("cluster/node/bindTag")
Review Comment:
Good issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062049599
##########
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/HeartbeatManager.java:
##########
@@ -228,7 +228,7 @@ private HeartbeatMsg buildHeartbeatMsg() {
heartbeatMsg.setInCharges(inCharges);
}
if (StringUtils.isNotBlank(nodeTag)) {
- heartbeatMsg.setNodeTag(nodeTag);
+ heartbeatMsg.setNodeLabel(nodeTag);
Review Comment:
Table name `stream_source_label` has alreay embodied its meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org