You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/17 17:52:46 UTC

[GitHub] [spark] dtenedor commented on pull request #38888: [SPARK-41405][SQL] Centralize the column resolution logic

dtenedor commented on PR #38888:
URL: https://github.com/apache/spark/pull/38888#issuecomment-1385808748

   Sorry for missing this earlier, late LGTM. Changes like this are moving in a good direction to move analysis logic closer to one pass. Ideally we could e.g. start making `ResolveReferences` immediately return an error if any unresolved reference could not be resolved, rather than waiting later until CheckAnalysis. We can make such improvements iteratively if we wish.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org