You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by Francesco Chicchiriccò <il...@apache.org> on 2022/08/24 11:16:43 UTC

[DISCUSS] Remove Camel Provisioning Manager

Hi all,
working for SYNCOPE-1692, which involves some changes in the provisioning process, I've realized that the Camel Provisioning Manager extension [1], while featuring some very smart code has probably never been used in any production deployment, at least none that I am aware of.

Over time, the cost of managing such (possibly unused) extension has become quite relevant, hence I am proposing to remove it from the master branch, so that next 3.0.0 release will not contain it anymore.

Thoughts?
Regards.

[1] https://github.com/apache/syncope/tree/master/ext/camel

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/


Re: [DISCUSS] Remove Camel Provisioning Manager

Posted by Francesco Chicchiriccò <il...@apache.org>.
On 24/08/22 15:58, Misagh Moayyed wrote:
> In general, I am in favor of this approach, but just to be on the safe
> side, would it make sense to deprecate the feature first? Just in case
> someone out there is using it, or would keeping the code around cause
> complications and maintenance issues?

Good point.

I think, however, that since we'd be doing that in a major release (e.g. 3.0) it could be enough to add a specific section in the release notes so that in case anyone exists that is running Syncope 2.1.x with Camel Provisioning Manager, they are made aware that this will need to be replaced, in case of upgrade to 3.0.0.

There are quite some breaking changes in such upgrade, the Camel Provisioning Manager would be just one more.

Regards.

> On Wed, Aug 24, 2022 at 4:16 AM Francesco Chicchiriccò
> <il...@apache.org> wrote:
>> Hi all,
>> working for SYNCOPE-1692, which involves some changes in the provisioning process, I've realized that the Camel Provisioning Manager extension [1], while featuring some very smart code has probably never been used in any production deployment, at least none that I am aware of.
>>
>> Over time, the cost of managing such (possibly unused) extension has become quite relevant, hence I am proposing to remove it from the master branch, so that next 3.0.0 release will not contain it anymore.
>>
>> Thoughts?
>> Regards.
>>
>> [1] https://github.com/apache/syncope/tree/master/ext/camel

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/


Re: [DISCUSS] Remove Camel Provisioning Manager

Posted by Misagh Moayyed <mi...@tirasa.net>.
In general, I am in favor of this approach, but just to be on the safe
side, would it make sense to deprecate the feature first? Just in case
someone out there is using it, or would keeping the code around cause
complications and maintenance issues?

On Wed, Aug 24, 2022 at 4:16 AM Francesco Chicchiriccò
<il...@apache.org> wrote:
>
> Hi all,
> working for SYNCOPE-1692, which involves some changes in the provisioning process, I've realized that the Camel Provisioning Manager extension [1], while featuring some very smart code has probably never been used in any production deployment, at least none that I am aware of.
>
> Over time, the cost of managing such (possibly unused) extension has become quite relevant, hence I am proposing to remove it from the master branch, so that next 3.0.0 release will not contain it anymore.
>
> Thoughts?
> Regards.
>
> [1] https://github.com/apache/syncope/tree/master/ext/camel
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>

Re: [DISCUSS] Remove Camel Provisioning Manager

Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
No objection from my side.

Regards
JB

On Wed, Aug 24, 2022 at 1:16 PM Francesco Chicchiriccò
<il...@apache.org> wrote:
>
> Hi all,
> working for SYNCOPE-1692, which involves some changes in the provisioning process, I've realized that the Camel Provisioning Manager extension [1], while featuring some very smart code has probably never been used in any production deployment, at least none that I am aware of.
>
> Over time, the cost of managing such (possibly unused) extension has become quite relevant, hence I am proposing to remove it from the master branch, so that next 3.0.0 release will not contain it anymore.
>
> Thoughts?
> Regards.
>
> [1] https://github.com/apache/syncope/tree/master/ext/camel
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>

Re: [DISCUSS] Remove Camel Provisioning Manager

Posted by Fabio Martelli <fa...@gmail.com>.
Hi Francesco, I completely agree with you.
I do think we should keep the entire project as simple as possible.
So, removing unused and quite useless extensions could be the right approach.

Regards,
F.

On Wed, Aug 24, 2022 at 1:16 PM Francesco Chicchiriccò
<il...@apache.org> wrote:
>
> Hi all,
> working for SYNCOPE-1692, which involves some changes in the provisioning process, I've realized that the Camel Provisioning Manager extension [1], while featuring some very smart code has probably never been used in any production deployment, at least none that I am aware of.
>
> Over time, the cost of managing such (possibly unused) extension has become quite relevant, hence I am proposing to remove it from the master branch, so that next 3.0.0 release will not contain it anymore.
>
> Thoughts?
> Regards.
>
> [1] https://github.com/apache/syncope/tree/master/ext/camel
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>

Re: [DISCUSS] Remove Camel Provisioning Manager

Posted by Francesco Chicchiriccò <il...@apache.org>.
FYI I went ahead and opened

https://github.com/apache/syncope/pull/371

with purpose of following up with action after discussion here.

About 2_1_X , I don't think we should change anything.
Regards.

On 25/08/22 09:24, Andrea Patricelli wrote:
> Hi all,
>
> Even if I agree with Misagh, I can confirm that even customers that were
> interested in the camel extension finally decided not to use it in favour
> of extending the default one.
> So agree on removing this feature on master.
> Just to know, we're going to upgrade camel deps and support it on branch
> 2.1.X right?
>
> Best regards,
> Andrea
>
> Il mer 24 ago 2022, 13:16 Francesco Chicchiriccò <il...@apache.org> ha
> scritto:
>
>> Hi all,
>> working for SYNCOPE-1692, which involves some changes in the provisioning
>> process, I've realized that the Camel Provisioning Manager extension [1],
>> while featuring some very smart code has probably never been used in any
>> production deployment, at least none that I am aware of.
>>
>> Over time, the cost of managing such (possibly unused) extension has
>> become quite relevant, hence I am proposing to remove it from the master
>> branch, so that next 3.0.0 release will not contain it anymore.
>>
>> Thoughts?
>> Regards.
>>
>> [1] https://github.com/apache/syncope/tree/master/ext/camel

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/


Re: [DISCUSS] Remove Camel Provisioning Manager

Posted by Andrea Patricelli <an...@tirasa.net>.
Hi all,

Even if I agree with Misagh, I can confirm that even customers that were
interested in the camel extension finally decided not to use it in favour
of extending the default one.
So agree on removing this feature on master.
Just to know, we're going to upgrade camel deps and support it on branch
2.1.X right?

Best regards,
Andrea

Il mer 24 ago 2022, 13:16 Francesco Chicchiriccò <il...@apache.org> ha
scritto:

> Hi all,
> working for SYNCOPE-1692, which involves some changes in the provisioning
> process, I've realized that the Camel Provisioning Manager extension [1],
> while featuring some very smart code has probably never been used in any
> production deployment, at least none that I am aware of.
>
> Over time, the cost of managing such (possibly unused) extension has
> become quite relevant, hence I am proposing to remove it from the master
> branch, so that next 3.0.0 release will not contain it anymore.
>
> Thoughts?
> Regards.
>
> [1] https://github.com/apache/syncope/tree/master/ext/camel
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>