[GitHub] [pinot] noon-stripe commented on a change in pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring

[GitBox <gi...@apache.org>]

noon-stripe commented on a change in pull request #8369:
URL: https://github.com/apache/pinot/pull/8369#discussion_r832562112



##########
File path: pinot-spi/src/test/java/org/apache/pinot/spi/config/table/IndexingConfigTest.java
##########
@@ -38,6 +38,12 @@ public void testSerDe()
     IndexingConfig indexingConfig = new IndexingConfig();
     indexingConfig.setLoadMode("MMAP");
     indexingConfig.setAggregateMetrics(true);
+    List<PreAggregationConfig> preAggregationConfigs =
+        Arrays.asList(
+            new PreAggregationConfig("c1", "SUM", "SUM_c1"),
+            new PreAggregationConfig("c2", "MIN", "MIN_c2"),
+            new PreAggregationConfig("c3", "MAX", "MAX_c2"));

Review comment:
       We're allowing the schema and table config to dictate the column name so it can be anything the user wants. In my tests (of the feature), I vary it up. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org