You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/31 21:18:11 UTC

[GitHub] [kafka] kowshik opened a new pull request #10454: MINOR: Rename LogUtils class in tests to LogTestUtils

kowshik opened a new pull request #10454:
URL: https://github.com/apache/kafka/pull/10454


   This PR is a precursor to the recovery logic refactor work (KAFKA-12553).
   
   I've renamed the file: `core/src/test/scala/unit/kafka/log/LogUtils.scala` to `core/src/test/scala/unit/kafka/log/LogTestUtils.scala`. Also I've renamed the underlying lass from `LogUtils` to `LogTestUtils`. This is going to help avoid a naming conflict with a new file called `LogUtils.scala` that I plan to introduce in `core/src/main/scala/kafka/log/` as part of the recovery logic refactor. The new file will also contain a bunch of static functions.
   
   **Tests:**
   Relying on existing tests to catch regressions (if any) since this is a simple change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao merged pull request #10454: MINOR: Rename LogUtils class in tests to LogTestUtils

Posted by GitBox <gi...@apache.org>.
junrao merged pull request #10454:
URL: https://github.com/apache/kafka/pull/10454


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kowshik commented on pull request #10454: MINOR: Rename LogUtils class in tests to LogTestUtils

Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #10454:
URL: https://github.com/apache/kafka/pull/10454#issuecomment-811472106


   cc @junrao @dhruvilshah3 -- this PR is ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org