You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/04/09 08:04:44 UTC
Review Request 33006: DRILL-2641: Move unrelated tests in exec/jdbc
module into appropriate modules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33006/
-----------------------------------------------------------
Review request for drill, Daniel Barclay, Hanifi Gunes, and Jason Altekruse.
Repository: drill-git
Description
-------
See DRILL-2641 for details.
Also:
- Update the tests to use the new test framework
- Remove duplicate tests (TestHiveScalarUDFs.java)
- Remove JDBC module dependency on Hive storage plugin module.
- Disabled few tests in jdbc.DatabaseMetaDataGetColumnsTest which were using Hive table for certails column types such as array, map, struct and union which are not possible as input types for filesystem tables. This test was blocking from removing exec/jdbc module dependency on contrib/storage-hive module.
Diffs
-----
contrib/storage-hive/core/src/main/resources/bootstrap-storage-plugins.json 5c7174e
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestInfoSchemaOnHiveStorage.java PRE-CREATION
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java PRE-CREATION
exec/jdbc/pom.xml 2385d74
exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 1a7b63d
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 2c1738c
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java 2c41e12
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 3534f35
exec/jdbc/src/test/resources/bootstrap-storage-plugins.json 548ec3d
Diff: https://reviews.apache.org/r/33006/diff/
Testing
-------
Thanks,
Venki Korukanti
Re: Review Request 33006: DRILL-2641: Move unrelated tests in
exec/jdbc module into appropriate modules
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33006/#review79820
-----------------------------------------------------------
exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java
<https://reviews.apache.org/r/33006/#comment129418>
Can you put that "////////" back?
(It separates the simpler types (creatable via CAST in the test's created view) from the complex types.)
- Daniel Barclay
On April 10, 2015, 5:51 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33006/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 5:51 p.m.)
>
>
> Review request for drill, Daniel Barclay, Hanifi Gunes, and Jason Altekruse.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> See DRILL-2641 for details.
>
> Also:
> - Update the tests to use the new test framework
> - Remove duplicate tests (TestHiveScalarUDFs.java)
> - Remove JDBC module dependency on Hive storage plugin module.
> - Disabled few tests in jdbc.DatabaseMetaDataGetColumnsTest which were using Hive table for certails column types such as array, map, struct and union which are not possible as input types for filesystem tables. This test was blocking from removing exec/jdbc module dependency on contrib/storage-hive module.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/main/resources/bootstrap-storage-plugins.json 5c7174e
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestInfoSchemaOnHiveStorage.java PRE-CREATION
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java PRE-CREATION
> exec/jdbc/pom.xml 2385d74
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 1a7b63d
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 2c1738c
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java 2c41e12
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 3534f35
> exec/jdbc/src/test/resources/bootstrap-storage-plugins.json 548ec3d
>
> Diff: https://reviews.apache.org/r/33006/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33006: DRILL-2641: Move unrelated tests in
exec/jdbc module into appropriate modules
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33006/
-----------------------------------------------------------
(Updated April 10, 2015, 5:51 p.m.)
Review request for drill, Daniel Barclay, Hanifi Gunes, and Jason Altekruse.
Repository: drill-git
Description
-------
See DRILL-2641 for details.
Also:
- Update the tests to use the new test framework
- Remove duplicate tests (TestHiveScalarUDFs.java)
- Remove JDBC module dependency on Hive storage plugin module.
- Disabled few tests in jdbc.DatabaseMetaDataGetColumnsTest which were using Hive table for certails column types such as array, map, struct and union which are not possible as input types for filesystem tables. This test was blocking from removing exec/jdbc module dependency on contrib/storage-hive module.
Diffs (updated)
-----
contrib/storage-hive/core/src/main/resources/bootstrap-storage-plugins.json 5c7174e
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestInfoSchemaOnHiveStorage.java PRE-CREATION
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java PRE-CREATION
exec/jdbc/pom.xml 2385d74
exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 1a7b63d
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 2c1738c
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java 2c41e12
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 3534f35
exec/jdbc/src/test/resources/bootstrap-storage-plugins.json 548ec3d
Diff: https://reviews.apache.org/r/33006/diff/
Testing
-------
Thanks,
Venki Korukanti
Re: Review Request 33006: DRILL-2641: Move unrelated tests in
exec/jdbc module into appropriate modules
Posted by Venki Korukanti <ve...@gmail.com>.
> On April 10, 2015, 5:20 p.m., Jason Altekruse wrote:
> > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java, line 39
> > <https://reviews.apache.org/r/33006/diff/1/?file=921328#file921328line39>
> >
> > You need to still call go() here to actually run the test.
Added go().
- Venki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33006/#review79700
-----------------------------------------------------------
On April 9, 2015, 6:04 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33006/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 6:04 a.m.)
>
>
> Review request for drill, Daniel Barclay, Hanifi Gunes, and Jason Altekruse.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> See DRILL-2641 for details.
>
> Also:
> - Update the tests to use the new test framework
> - Remove duplicate tests (TestHiveScalarUDFs.java)
> - Remove JDBC module dependency on Hive storage plugin module.
> - Disabled few tests in jdbc.DatabaseMetaDataGetColumnsTest which were using Hive table for certails column types such as array, map, struct and union which are not possible as input types for filesystem tables. This test was blocking from removing exec/jdbc module dependency on contrib/storage-hive module.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/main/resources/bootstrap-storage-plugins.json 5c7174e
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestInfoSchemaOnHiveStorage.java PRE-CREATION
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java PRE-CREATION
> exec/jdbc/pom.xml 2385d74
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 1a7b63d
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 2c1738c
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java 2c41e12
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 3534f35
> exec/jdbc/src/test/resources/bootstrap-storage-plugins.json 548ec3d
>
> Diff: https://reviews.apache.org/r/33006/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33006: DRILL-2641: Move unrelated tests in
exec/jdbc module into appropriate modules
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33006/#review79700
-----------------------------------------------------------
Ship it!
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
<https://reviews.apache.org/r/33006/#comment129228>
You need to still call go() here to actually run the test.
- Jason Altekruse
On April 9, 2015, 6:04 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33006/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 6:04 a.m.)
>
>
> Review request for drill, Daniel Barclay, Hanifi Gunes, and Jason Altekruse.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> See DRILL-2641 for details.
>
> Also:
> - Update the tests to use the new test framework
> - Remove duplicate tests (TestHiveScalarUDFs.java)
> - Remove JDBC module dependency on Hive storage plugin module.
> - Disabled few tests in jdbc.DatabaseMetaDataGetColumnsTest which were using Hive table for certails column types such as array, map, struct and union which are not possible as input types for filesystem tables. This test was blocking from removing exec/jdbc module dependency on contrib/storage-hive module.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/main/resources/bootstrap-storage-plugins.json 5c7174e
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestInfoSchemaOnHiveStorage.java PRE-CREATION
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java PRE-CREATION
> exec/jdbc/pom.xml 2385d74
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 1a7b63d
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 2c1738c
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java 2c41e12
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 3534f35
> exec/jdbc/src/test/resources/bootstrap-storage-plugins.json 548ec3d
>
> Diff: https://reviews.apache.org/r/33006/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venki Korukanti
>
>