You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:41:55 UTC
[GitHub] [airflow] crhyatt opened a new pull request #8500: [Airflow-3391] Upgrade pendulum to latest major version
crhyatt opened a new pull request #8500:
URL: https://github.com/apache/airflow/pull/8500
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #8500: [Airflow-3391] Upgrade pendulum to latest major version
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8500:
URL: https://github.com/apache/airflow/pull/8500#issuecomment-640222120
Hi. This change is fantastic! Could you do rebase, please? If you do it, please ping me here or on Slack I will gladly review this change. This library is a problem for my users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io edited a comment on issue #8500: [Airflow-3391] Upgrade pendulum to latest major version
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8500:
URL: https://github.com/apache/airflow/pull/8500#issuecomment-617405391
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=h1) Report
> Merging [#8500](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4054663769e3a3861773469469dd3efa7b383df8&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `27.27%`.
[](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8500 +/- ##
=========================================
- Coverage 6.22% 6.22% -0.01%
=========================================
Files 946 946
Lines 45695 45707 +12
=========================================
Hits 2846 2846
- Misses 42849 42861 +12
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/latest\_only\_operator.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbGF0ZXN0X29ubHlfb3BlcmF0b3IucHk=) | `0.00% <0.00%> (ø)` | |
| [...rflow/providers/google/cloud/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhcHJvYy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `0.00% <0.00%> (ø)` | |
| [airflow/utils/timezone.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lem9uZS5weQ==) | `52.08% <0.00%> (ø)` | |
| [airflow/www/decorators.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZGVjb3JhdG9ycy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `26.65% <20.00%> (ø)` | |
| [airflow/models/xcom.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMveGNvbS5weQ==) | `43.95% <100.00%> (ø)` | |
| [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `73.61% <100.00%> (ø)` | |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `0.00% <0.00%> (ø)` | |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=footer). Last update [887dea3...cf82cef](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] crhyatt closed pull request #8500: [Airflow-3391] Upgrade pendulum to latest major version
Posted by GitBox <gi...@apache.org>.
crhyatt closed pull request #8500:
URL: https://github.com/apache/airflow/pull/8500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io commented on issue #8500: [Airflow-3391] Upgrade pendulum to latest major version
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8500:
URL: https://github.com/apache/airflow/pull/8500#issuecomment-617405391
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=h1) Report
> Merging [#8500](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/96df427e07601e331afd6990ce7613b2026acfe0&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `27.27%`.
[](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8500 +/- ##
=========================================
- Coverage 6.23% 6.22% -0.01%
=========================================
Files 946 946
Lines 45661 45715 +54
=========================================
Hits 2846 2846
- Misses 42815 42869 +54
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/latest\_only\_operator.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbGF0ZXN0X29ubHlfb3BlcmF0b3IucHk=) | `0.00% <0.00%> (ø)` | |
| [...rflow/providers/google/cloud/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhcHJvYy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `0.00% <0.00%> (ø)` | |
| [airflow/utils/timezone.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lem9uZS5weQ==) | `52.08% <0.00%> (ø)` | |
| [airflow/www/decorators.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZGVjb3JhdG9ycy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `26.65% <20.00%> (ø)` | |
| [airflow/models/xcom.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMveGNvbS5weQ==) | `43.95% <100.00%> (ø)` | |
| [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `73.61% <100.00%> (ø)` | |
| [airflow/models/dagrun.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFncnVuLnB5) | `26.60% <0.00%> (-0.12%)` | :arrow_down: |
| [airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=footer). Last update [96df427...d0ce519](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io edited a comment on issue #8500: [Airflow-3391] Upgrade pendulum to latest major version
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8500:
URL: https://github.com/apache/airflow/pull/8500#issuecomment-617405391
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=h1) Report
> Merging [#8500](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/96df427e07601e331afd6990ce7613b2026acfe0&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `27.27%`.
[](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8500 +/- ##
=========================================
- Coverage 6.23% 6.22% -0.01%
=========================================
Files 946 946
Lines 45661 45715 +54
=========================================
Hits 2846 2846
- Misses 42815 42869 +54
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/latest\_only\_operator.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbGF0ZXN0X29ubHlfb3BlcmF0b3IucHk=) | `0.00% <0.00%> (ø)` | |
| [...rflow/providers/google/cloud/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhcHJvYy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `0.00% <0.00%> (ø)` | |
| [airflow/utils/timezone.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lem9uZS5weQ==) | `52.08% <0.00%> (ø)` | |
| [airflow/www/decorators.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZGVjb3JhdG9ycy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `26.65% <20.00%> (ø)` | |
| [airflow/models/xcom.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMveGNvbS5weQ==) | `43.95% <100.00%> (ø)` | |
| [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `73.61% <100.00%> (ø)` | |
| [airflow/models/dagrun.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFncnVuLnB5) | `26.60% <0.00%> (-0.12%)` | :arrow_down: |
| [airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=footer). Last update [96df427...d0ce519](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io edited a comment on pull request #8500: [Airflow-3391] Upgrade pendulum to latest major version
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8500:
URL: https://github.com/apache/airflow/pull/8500#issuecomment-617405391
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=h1) Report
> Merging [#8500](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4054663769e3a3861773469469dd3efa7b383df8&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `27.27%`.
[](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8500 +/- ##
=========================================
- Coverage 6.22% 6.22% -0.01%
=========================================
Files 946 946
Lines 45695 45707 +12
=========================================
Hits 2846 2846
- Misses 42849 42861 +12
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/latest\_only\_operator.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbGF0ZXN0X29ubHlfb3BlcmF0b3IucHk=) | `0.00% <0.00%> (ø)` | |
| [...rflow/providers/google/cloud/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhcHJvYy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `0.00% <0.00%> (ø)` | |
| [airflow/utils/timezone.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lem9uZS5weQ==) | `52.08% <0.00%> (ø)` | |
| [airflow/www/decorators.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZGVjb3JhdG9ycy5weQ==) | `0.00% <ø> (ø)` | |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `26.65% <20.00%> (ø)` | |
| [airflow/models/xcom.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMveGNvbS5weQ==) | `43.95% <100.00%> (ø)` | |
| [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `73.61% <100.00%> (ø)` | |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `0.00% <0.00%> (ø)` | |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/8500/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=footer). Last update [b6434de...d8bad7b](https://codecov.io/gh/apache/airflow/pull/8500?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] crhyatt commented on pull request #8500: [Airflow-3391] Upgrade pendulum to latest major version
Posted by GitBox <gi...@apache.org>.
crhyatt commented on pull request #8500:
URL: https://github.com/apache/airflow/pull/8500#issuecomment-640751169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org