You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/25 07:15:44 UTC
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich opened a new issue, #43: Add Scala 3 support
mdedetrich opened a new issue, #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43
Just pinging @pjfanning and @nvollmar , I am assigning this to myself so we don't duplicate work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on issue #43: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1562434561
I was under the impression that it was frowned on for libs to depend on features like CrossVersion.for3Use2_13.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on issue #43: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1562429053
I thought that this was achievable because Slick does not yet support Scala 3 - eg https://github.com/slick/slick/pull/2687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] nafg commented on issue #43: Add Scala 3 support
Posted by "nafg (via GitHub)" <gi...@apache.org>.
nafg commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1566074701
There isn't supposed to be one yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #43: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1566076450
> There isn't supposed to be one yet
I was talking about a call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #43: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1565946530
> I can get it done faster / sooner if I can work on it on a call with someone, like pair programming or live coding.
So for now the issue is just that I can't find the artifact for Scala 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] jtjeferreira commented on issue #43: Add Scala 3 support
Posted by "jtjeferreira (via GitHub)" <gi...@apache.org>.
jtjeferreira commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1655375516
I think this is no longer blocked since there `3.5.0-M4` release of slick has scala3 support: https://mvnrepository.com/artifact/com.typesafe.slick/slick_3/3.5.0-M4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #43: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1562437397
I never had this impression, at least from what I have seen its obviously idea to use a Scala 3 artifact if it exists but if it doesn't then `CrossVersion.for3Use2_13` should be used.
In any case I was trying to use `CrossVersion.for3Use2_13` on Slick to see how hard it would be to migrate the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #43: Add Scala 3 support
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #43: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1562431972
So Scala 3 can use Scala 2 artifacts and vice versa and this can be achieved by using `CrossVersion.for3Use2_13` or `CrossVersion.for2_13Use3` respectively (see https://docs.scala-lang.org/scala3/guides/migration/tooling-tour.html).
I already tried using `CrossVersion.for3Use2_13` but I got some issues from Slicks side with incompatible types from `Tuple.unapply` which may be resolved by using a Scala 3 artifact from Slick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on issue #43: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1655385305
@jtjeferreira there is already https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44. I guess the feeling is that we'd prefer to wait until slick 3.5.0 is released until we merge PR44.
The idea is to delay the release of pekko-persistence-jdbc until this is ready - and concentrate on releasing other modules instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #43: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1562440279
> An example - [akka/akka#31200](https://github.com/akka/akka/issues/31200) - which links to https://docs.scala-lang.org/scala3/guides/migration/compatibility-classpath.html#interoperability-overview and it has this disclaimer.
>
> ```
> Disclaimer for library maintainers
> Using the interoperability between Scala 2.13 and Scala 3 in a published library is generally not safe for your end-users.
>
> Unless you know exactly what you are doing, it is discouraged to publish a Scala 3 library that depends on a Scala 2.13 library (the scala-library being excluded) or vice versa. The reason is to prevent library users from ending up with two conflicting versions foo_2.13 and foo_3 of the same foo library in their classpath, this problem being unsolvable in some cases.
> ```
Ah thanks, well TIL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on issue #43: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1562437760
An example - https://github.com/akka/akka/issues/31200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] nafg commented on issue #43: Add Scala 3 support
Posted by "nafg (via GitHub)" <gi...@apache.org>.
nafg commented on issue #43:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/43#issuecomment-1565906636
I can get it done faster / sooner if I can do it on a call with someone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org