You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/05/31 16:41:40 UTC
[kudu-CR](branch-1.8.x) Change all dependency sources to https
Hello Mike Percy, Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13486
to review the following change.
Change subject: Change all dependency sources to https
......................................................................
Change all dependency sources to https
Some of our scripts and build tools used to pull dependencies using
unsecured HTTP protocol, changing these to use HTTPS instead for added
security.
Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
(cherry picked from commit a78b6517791b32a2410258f5bc1d0fea649d3887)
---
M README.adoc
M build-support/build_source_release.py
M build-support/release/README.adoc
M java/buildSrc/build.gradle
M java/kudu-jepsen/build.gradle
M thirdparty/package-llvm.sh
M thirdparty/vars.sh
7 files changed, 15 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/13486/1
--
To view, visit http://gerrit.cloudera.org:8080/13486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13486
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](branch-1.8.x) Change all dependency sources to https
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13486 )
Change subject: Change all dependency sources to https
......................................................................
Change all dependency sources to https
Some of our scripts and build tools used to pull dependencies using
unsecured HTTP protocol, changing these to use HTTPS instead for added
security.
Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
(cherry picked from commit a78b6517791b32a2410258f5bc1d0fea649d3887)
Reviewed-on: http://gerrit.cloudera.org:8080/13486
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
---
M README.adoc
M build-support/build_source_release.py
M build-support/release/README.adoc
M java/buildSrc/build.gradle
M java/kudu-jepsen/build.gradle
M thirdparty/package-llvm.sh
M thirdparty/vars.sh
7 files changed, 15 insertions(+), 14 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
Greg Solovyev: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/13486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13486
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](branch-1.8.x) Change all dependency sources to https
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/13486 )
Change subject: Change all dependency sources to https
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13486
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 31 May 2019 18:19:40 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Change all dependency sources to https
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13486 )
Change subject: Change all dependency sources to https
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13486
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 31 May 2019 16:48:31 +0000
Gerrit-HasComments: No