You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/28 03:50:10 UTC
[GitHub] [flink] DashShen opened a new pull request #12369: Flink 17678
DashShen opened a new pull request #12369:
URL: https://github.com/apache/flink/pull/12369
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/browse/FLINK-17678). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-17678] [Connectors/HBase] Title of the pull request", where *FLINK-17678* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Flink doesn't contains a hbase shade jar right now, so users have to add hbase dependency manually. This pull request is trying to solve this problem. Add a new flink-sql-connector-hbase modular likes flink-sql-connector-elasticsearch7.
## Brief change log
- Add new modular flink-sql-connector-hbase.
- Add new hbase end to end test.
## Verifying this change
This new modular flink-sql-connector-hbase only includes necessary dependencies that used to reading or writing data from/to hbase.
**NOTE**:
1. We do not shade hadoop dependencies into the jar. Becasuse flink-sql-connector-hive doesn't contains either, so we do this in similar way.
2. We shade all dependencies that hbase needed but except `org.apache.hadoop.hbase.codec.*` for preventing hbase client throw timeout exception . Because the hbase server can not find the shaded codec class to decoding data(byte[]).
3. We add a new end to end test of hbase. To execute this e2e test, the test script will download hbase.tar.gz and flink-shade-hadoop-uber jar. In this test script, we test correctness by using sql-client.sh
4. To avoid class not found exception, we replace the hbase-default.xml which excludes theses configuration such like:
```xml
<property>
<name>hbase.status.listener.class</name>
<value>org.apache.hadoop.hbase.client.ClusterStatusListener$MulticastListener</value>
<description>
Implementation of the status listener with a multicast message.
</description>
</property>
```
Because if we don't remove this property, hbase client will try to load the class that configured in hbase-default.xml. But actually , all these classes have already been shaded and can't be loaded by those default canonical name.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r437978305
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
@leonardBang ,Thks for ur advice. But I encountered a problem that how can I setup HADOOP_CLASSPATH before running sql-client.sh. Could you give me some suggestion. What I have done is below:
```java
AtomicReference<String> atomicHadoopClasspath = new AtomicReference<>("");
AutoClosableProcess.create(
hadoopDir.resolve(Paths.get("bin", "hadoop")).toString(), "classpath")
.setStdoutProcessor(atomicHadoopClasspath::set)
.runBlocking();
final String hadoopClasspath = atomicHadoopClasspath.get();
LOG.info("Hadoop Classpath: {}", hadoopClasspath);
// how setup HADOOP_CLASSPATH?
// I tried using AutoClosableProcess to run export HADOOP_CLASSPATH=<hadoopClasssPath>, but it doesn't work.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r440668815
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/hbase-default.xml
##########
@@ -0,0 +1,1558 @@
+<?xml version="1.0"?>
+<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<!--
+OVERVIEW
+The important configs. are listed near the top. You should change
+at least the setting for hbase.tmp.dir. Other settings will change
+dependent on whether you are running hbase in standalone mode or
+distributed. See the hbase reference guide for requirements and
+guidance making configuration.
+This file does not contain all possible configurations. The file would be
+much larger if it carried everything. The absent configurations will only be
+found through source code reading. The idea is that such configurations are
+exotic and only those who would go to the trouble of reading a particular
+section in the code would be knowledgeable or invested enough in ever wanting
+to alter such configurations, so we do not list them here. Listing all
+possible configurations would overwhelm and obscure the important.
+-->
+
+<configuration>
Review comment:
see https://issues.apache.org/jira/browse/FLINK-14359?focusedCommentId=16949271&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16949271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-644561250
> @wuchong Sorry, due to my personal physical reasons, I don't have enough time to finish this work recently.You can assign others to finish this. I'll be involved in community work later when my back pain recovery.
Sorry hear that, please take care of you first @DashShen .
I'd like to take over the next work and thanks for the great effort of the previous work.
Hope you recover soon.
Best regard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: Flink 17678
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f49fb611425fd075c0818233472ece2a4a824d71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] openinx commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438030578
##########
File path: flink-connectors/flink-sql-connector-hbase/pom.xml
##########
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <name>flink-sql-connector-hbase</name>
+
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.flink:flink-connector-hbase_${scala.binary.version}</include>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.zookeeper:zookeeper</include>
+ <include>org.apache.htrace:htrace-core</include>
+ <include>com.google.guava:guava</include>
+ <include>com.google.protobuf:protobuf-java</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>commons-logging:commons-logging</include>
+ <include>commons-lang:commons-lang</include>
+ <include>commons-configuration:commons-configuration</include>
+ <include>commons-codec:commons-codec</include>
+ <include>io.netty:netty-all</include>
+ </includes>
+ <excludes>
+ <exclude>org.apache.hbase:hbase-metrics*</exclude>
+ <exclude>org.apache.hbase:hbase-server*</exclude>
+ </excludes>
+ </artifactSet>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/services/com.fasterxml.**</exclude>
+ <exclude>META-INF/services/org.apache.hadoop.**</exclude>
+ <exclude>META-INF/services/javax.**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <!-- Force relocation of all HBase dependencies. -->
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.htrace</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.htrace</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.yammer.metrics</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-logging</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-logging</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-lang</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-lang</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-configuration</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-configuration</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-codec</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-codec</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty:netty-all</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.hbase</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.hbase</shadedPattern>
Review comment:
Seems the e2e test did not cover this issue , I guess we put the shaded hbase jar into the classpath of hbase server, so our region server could load the correct class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 923273e1eed813d62522fb270c250d207ce2a389 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e812cd62bcab9b71b1cb0fd1d86a10bb9795178 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-644514878
@wuchong Sorry, due to my personal physical reasons, I don't have enough time to finish this work recently.You can assignee others to finish this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-644514878
@wuchong Sorry, due to my personal physical reasons, I don't have enough time to finish this work recently.You can assign others to finish this. I'll be involved in community work later when my back pain recovery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r437978305
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
@leonardBang ,Thks for ur advice. But I encountered a problem that how can I setup HADOOP_CLASSPATH before running sql-client.sh. Could you give me some suggestion. What I have done is below:
```java
AtomicReference<String> atomicHadoopClasspath = new AtomicReference<>("");
AutoClosableProcess.create(
hadoopDir.resolve(Paths.get("bin", "hadoop")).toString(), "classpath")
.setStdoutProcessor(atomicHadoopClasspath::set)
.runBlocking();
final String hadoopClasspath = atomicHadoopClasspath.get();
LOG.info("Hadoop Classpath: {}", hadoopClasspath);
// how to setup HADOOP_CLASSPATH?
// I tried using AutoClosableProcess to run export HADOOP_CLASSPATH=<hadoopClasssPath>, but it doesn't work.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
}, {
"hash" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009",
"triggerID" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"triggerType" : "PUSH"
}, {
"hash" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102",
"triggerID" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e9def2db9b7b755f7b048e4ee99339a509e390b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009)
* 586cad86df6ee5de33537f735fa5c65cabebe260 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e812cd62bcab9b71b1cb0fd1d86a10bb9795178 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386)
* 21da7909b9b5bf9fd4963d592da500752ab7c295 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] openinx commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r437950123
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
+ * @param columnFamily columnFamily of the given data
+ * @param columnQualifier column qualifier of the given data
Review comment:
When build the package with this patch, I found that:
```
[ERROR] src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java:[55,12] (javadoc) JavadocMethod: Unused @param tag for 'columnQualifier'.
```
Seems the javadoc of `columnQualifier ` should be removed ? @DashShen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-644123352
Hi @DashShen , do you have time to update this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 39607521051aea24e2f4805a428bb1469745287d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
}, {
"hash" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009",
"triggerID" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"triggerType" : "PUSH"
}, {
"hash" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102",
"triggerID" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 586cad86df6ee5de33537f735fa5c65cabebe260 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 923273e1eed813d62522fb270c250d207ce2a389 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620)
* 39607521051aea24e2f4805a428bb1469745287d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r439389190
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/resources/hbase_source_sink_schema.yaml
##########
@@ -0,0 +1,57 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+tables:
+ - name: MyHBaseSource
+ type: source-table
+ connector:
Review comment:
Maybe currently we can not use new connector property keys in yaml, I'm fine with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r439916870
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/LocalStandaloneHBaseResource.java
##########
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.CommandLineWrapper;
+import org.apache.flink.tests.util.activation.OperatingSystemRestriction;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.util.OperatingSystem;
+
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Consumer;
+import java.util.stream.Collectors;
+
+/**
+ * {@link HBaseResource} that downloads hbase and set up a local hbase cluster.
+ */
+public class LocalStandaloneHBaseResource implements HBaseResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneHBaseResource.class);
+
+ private final TemporaryFolder tmp = new TemporaryFolder();
+
+ private final DownloadCache downloadCache = DownloadCache.get();
+ private Path hbaseDir;
+
+ LocalStandaloneHBaseResource() {
+ OperatingSystemRestriction.forbid(
+ String.format("The %s relies on UNIX utils and shell scripts.", getClass().getSimpleName()),
+ OperatingSystem.WINDOWS);
+ }
+
+ private static String getHBaseDownloadUrl() {
+ return "https://archive.apache.org/dist/hbase/1.4.3/hbase-1.4.3-bin.tar.gz";
+ }
+
+ @Override
+ public void before() throws Exception {
+ tmp.create();
+ downloadCache.before();
+
+ this.hbaseDir = tmp.newFolder("hbase").toPath().toAbsolutePath();
+ setupHBaseDist();
+ setupHBaseCluster();
+ }
+
+ private void setupHBaseDist() throws IOException {
+ final Path downloadDirectory = tmp.newFolder("getOrDownload").toPath();
+ final Path hbaseArchive = downloadCache.getOrDownload(getHBaseDownloadUrl(), downloadDirectory);
+
+ LOG.info("HBase localtion: {}", hbaseDir.toAbsolutePath());
+ AutoClosableProcess.runBlocking(CommandLineWrapper
+ .tar(hbaseArchive)
+ .extract()
+ .zipped()
+ .strip(1)
+ .targetDir(hbaseDir)
+ .build());
+
+ LOG.info("Configure {} as hbase.tmp.dir", hbaseDir.toAbsolutePath());
+ final String tmpDirConfig = "<configuration><property><name>hbase.tmp.dir</name><value>" + hbaseDir + "</value></property></configuration>";
+ Files.write(hbaseDir.resolve(Paths.get("conf", "hbase-site.xml")), tmpDirConfig.getBytes());
+ }
+
+ private void setupHBaseCluster() throws IOException {
+ LOG.info("Starting HBase cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "start-hbase.sh")).toString());
+
+ while (!isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to start");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+ }
+
+ @Override
+ public void afterTestSuccess() {
+ try {
+ LOG.info("Stopping HBase Cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "hbase-daemon.sh")).toString(),
+ "stop",
+ "master");
+
+ while (isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to stop");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+
+ } catch (IOException ioe) {
+ LOG.warn("Error while shutting down hbase.", ioe);
+ }
+ downloadCache.afterTestSuccess();
+ tmp.delete();
+ }
+
+ private static boolean isHBaseRunning() {
+ try {
+ final AtomicBoolean atomicHMasterStarted = new AtomicBoolean(false);
+ queryHMasterStatus(line -> atomicHMasterStarted.compareAndSet(false, line.contains("HMaster")));
+ return atomicHMasterStarted.get();
+ } catch (IOException ioe) {
+ return false;
+ }
+ }
+
+ private static void queryHMasterStatus(final Consumer<String> stdoutProcessor) throws IOException {
+ AutoClosableProcess
+ .create("jps")
Review comment:
Is it possible to check whether the master UI is availbe instead of jps? This is how we check Elasticsearch status. My concern is that you may see the process in `jps`, but the service it not up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r440668761
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,23 @@
+flink-sql-connector-hbase
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.hbase:hbase-common:1.4.3
+- org.apache.hbase:hbase-protocol:1.4.3
+- org.apache.hbase:hbase-procedure:1.4.3
+- org.apache.hbase:hbase-client:1.4.3
+- org.apache.hbase:hbase-prefix-tree:1.4.3
+- org.apache.htrace:htrace-core:3.1.0-incubating
+- org.apache.zookeeper:zookeeper:3.4.14
+- commons-codec:commons-codec:1.10
+- commons-configuration:commons-configuration:1.7
+- commons-lang:commons-lang:2.6
+- commons-logging:commons-logging:1.1.3
+- com.google.guava:guava:12.0.1
+- com.google.protobuf:protobuf-java:2.5.0
Review comment:
You are right. It is BSD.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21da7909b9b5bf9fd4963d592da500752ab7c295 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12369:
URL: https://github.com/apache/flink/pull/12369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08539af1e82e9ef40d9814fc4c787c9f66d3f33e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [Flink-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f49fb611425fd075c0818233472ece2a4a824d71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324)
* 518368f03c225bf1cdc2065382539f7f49f6c4e7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [Flink-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f49fb611425fd075c0818233472ece2a4a824d71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324)
* 518368f03c225bf1cdc2065382539f7f49f6c4e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21da7909b9b5bf9fd4963d592da500752ab7c295 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415)
* 08539af1e82e9ef40d9814fc4c787c9f66d3f33e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438127768
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
+ * @param columnFamily columnFamily of the given data
+ * @param columnQualifier column qualifier of the given data
Review comment:
I already fixed and will uploading later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r440667980
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,23 @@
+flink-sql-connector-hbase
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.hbase:hbase-common:1.4.3
+- org.apache.hbase:hbase-protocol:1.4.3
+- org.apache.hbase:hbase-procedure:1.4.3
+- org.apache.hbase:hbase-client:1.4.3
+- org.apache.hbase:hbase-prefix-tree:1.4.3
+- org.apache.htrace:htrace-core:3.1.0-incubating
+- org.apache.zookeeper:zookeeper:3.4.14
+- commons-codec:commons-codec:1.10
+- commons-configuration:commons-configuration:1.7
+- commons-lang:commons-lang:2.6
+- commons-logging:commons-logging:1.1.3
+- com.google.guava:guava:12.0.1
+- com.google.protobuf:protobuf-java:2.5.0
Review comment:
`protobuf-java` is not Apache Software License 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
}, {
"hash" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009",
"triggerID" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"triggerType" : "PUSH"
}, {
"hash" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102",
"triggerID" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"triggerType" : "PUSH"
}, {
"hash" : "36c655ad70e59179ad503796797333898a98fdce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3241",
"triggerID" : "36c655ad70e59179ad503796797333898a98fdce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 586cad86df6ee5de33537f735fa5c65cabebe260 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102)
* 36c655ad70e59179ad503796797333898a98fdce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 518368f03c225bf1cdc2065382539f7f49f6c4e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] openinx commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438030100
##########
File path: flink-connectors/flink-sql-connector-hbase/pom.xml
##########
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <name>flink-sql-connector-hbase</name>
+
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.flink:flink-connector-hbase_${scala.binary.version}</include>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.zookeeper:zookeeper</include>
+ <include>org.apache.htrace:htrace-core</include>
+ <include>com.google.guava:guava</include>
+ <include>com.google.protobuf:protobuf-java</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>commons-logging:commons-logging</include>
+ <include>commons-lang:commons-lang</include>
+ <include>commons-configuration:commons-configuration</include>
+ <include>commons-codec:commons-codec</include>
+ <include>io.netty:netty-all</include>
+ </includes>
+ <excludes>
+ <exclude>org.apache.hbase:hbase-metrics*</exclude>
+ <exclude>org.apache.hbase:hbase-server*</exclude>
+ </excludes>
+ </artifactSet>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/services/com.fasterxml.**</exclude>
+ <exclude>META-INF/services/org.apache.hadoop.**</exclude>
+ <exclude>META-INF/services/javax.**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <!-- Force relocation of all HBase dependencies. -->
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.htrace</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.htrace</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.yammer.metrics</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-logging</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-logging</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-lang</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-lang</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-configuration</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-configuration</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-codec</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-codec</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty:netty-all</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.hbase</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.hbase</shadedPattern>
Review comment:
I think here we should also exclude the class `org.apache.hadoop.hbase.CellScanner`, otherwise our `KeyValueCodec$KeyValueDecoder` will extend the `org.apache.flink.hbase.shaded.org.apache.hadoop.hbase.CellScanner` class, while the server side did not also have this class, it will throw the exception:
```
Caused by: org.apache.flink.runtime.JobException: Creating the input splits caused an error: java.lang.IncompatibleClassChangeError: Class org.apache.hadoop.hbase.codec.KeyValueCodec$KeyValueDecoder does not implement the requested interface org.apache.hadoop.hbase.CellScanner
at org.apache.flink.runtime.executiongraph.ExecutionJobVertex.<init>(ExecutionJobVertex.java:272)
at org.apache.flink.runtime.executiongraph.ExecutionGraph.attachJobGraph(ExecutionGraph.java:814)
at org.apache.flink.runtime.executiongraph.ExecutionGraphBuilder.buildGraph(ExecutionGraphBuilder.java:228)
at org.apache.flink.runtime.scheduler.SchedulerBase.createExecutionGraph(SchedulerBase.java:269)
at org.apache.flink.runtime.scheduler.SchedulerBase.createAndRestoreExecutionGraph(SchedulerBase.java:242)
at org.apache.flink.runtime.scheduler.SchedulerBase.<init>(SchedulerBase.java:229)
at org.apache.flink.runtime.scheduler.DefaultScheduler.<init>(DefaultScheduler.java:119)
at org.apache.flink.runtime.scheduler.DefaultSchedulerFactory.createInstance(DefaultSchedulerFactory.java:103)
at org.apache.flink.runtime.jobmaster.JobMaster.createScheduler(JobMaster.java:284)
at org.apache.flink.runtime.jobmaster.JobMaster.<init>(JobMaster.java:272)
at org.apache.flink.runtime.jobmaster.factories.DefaultJobMasterServiceFactory.createJobMasterService(DefaultJobMasterServiceFactory.java:98)
at org.apache.flink.runtime.jobmaster.factories.DefaultJobMasterServiceFactory.createJobMasterService(DefaultJobMasterServiceFactory.java:40)
at org.apache.flink.runtime.jobmaster.JobManagerRunnerImpl.<init>(JobManagerRunnerImpl.java:140)
at org.apache.flink.runtime.dispatcher.DefaultJobManagerRunnerFactory.createJobManagerRunner(DefaultJobManagerRunnerFactory.java:84)
at org.apache.flink.runtime.dispatcher.Dispatcher.lambda$createJobManagerRunner$6(Dispatcher.java:387)
... 7 more
Caused by: org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.IncompatibleClassChangeError: Class org.apache.hadoop.hbase.codec.KeyValueCodec$KeyValueDecoder does not implement the requested interface org.apache.hadoop.hbase.CellScanner
at org.apache.hadoop.hbase.client.RpcRetryingCaller.translateException(RpcRetryingCaller.java:248)
at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:221)
at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:388)
at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:362)
at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:142)
at org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IncompatibleClassChangeError: Class org.apache.hadoop.hbase.codec.KeyValueCodec$KeyValueDecoder does not implement the requested interface org.apache.hadoop.hbase.CellScanner
at org.apache.hadoop.hbase.protobuf.ResponseConverter.getResults(ResponseConverter.java:419)
at org.apache.hadoop.hbase.client.ScannerCallable.call(ScannerCallable.java:284)
at org.apache.hadoop.hbase.client.ScannerCallable.call(ScannerCallable.java:62)
at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:219)
... 7 more
End of exception on server side>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08539af1e82e9ef40d9814fc4c787c9f66d3f33e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423)
* 923273e1eed813d62522fb270c250d207ce2a389 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r440666999
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,13 @@
+flink-sql-connector-hbase
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.hbase:hbase-server:1.4.3
+- org.apache.zookeeper:zookeeper:3.4.10
+- org.apache.htrace:htrace-core:3.1.0-incubating
Review comment:
I have checked the LICENSE and looks good to me. But would be better if @rmetzger can verify it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r439999545
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
You can put the contents of `flink-yarn-tests/target/yarn.classpath` into HADOOP_CLASSPATH. The file contains the right dependencies of the Hadoop version defined by the PROFILE variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-639341500
Thanks a lot for ensuring that CI is passing. The community is quite busy with fixing the last bugs for the upcoming 1.11 release, that's why reviews are sometimes a bit delayed.
But I hope that somebody who's familiar with the SQL code will soon take a look at this PR.
Feel free to ping me again if nobody reacts within a week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 518368f03c225bf1cdc2065382539f7f49f6c4e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333)
* 5e812cd62bcab9b71b1cb0fd1d86a10bb9795178 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438563119
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/resources/hbase_source_sink_schema.yaml
##########
@@ -0,0 +1,57 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+tables:
+ - name: MyHBaseSource
+ type: source-table
+ connector:
Review comment:
@leonardBang I'm willing to use new approach to define connector property, but I find there is no difference in `org.apache.flink.table.client.config.Environment`, so the the way to write environment file is not change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r439409344
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
A simple way is to let the E2E test run in the environment with HADOOP profile, the default CI build should be [PROFILE](https://github.com/apache/flink/blob/master/azure-pipelines.yml#L69). IIUC, we do need to down load the shaded hadoop jar, the E2E test should run normally. Could you have a try ? @DashShen
And @rmetzger could you help confirm this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438129997
##########
File path: flink-connectors/flink-sql-connector-hbase/pom.xml
##########
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <name>flink-sql-connector-hbase</name>
+
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.flink:flink-connector-hbase_${scala.binary.version}</include>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.zookeeper:zookeeper</include>
+ <include>org.apache.htrace:htrace-core</include>
+ <include>com.google.guava:guava</include>
+ <include>com.google.protobuf:protobuf-java</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>commons-logging:commons-logging</include>
+ <include>commons-lang:commons-lang</include>
+ <include>commons-configuration:commons-configuration</include>
+ <include>commons-codec:commons-codec</include>
+ <include>io.netty:netty-all</include>
+ </includes>
+ <excludes>
+ <exclude>org.apache.hbase:hbase-metrics*</exclude>
+ <exclude>org.apache.hbase:hbase-server*</exclude>
+ </excludes>
+ </artifactSet>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/services/com.fasterxml.**</exclude>
+ <exclude>META-INF/services/org.apache.hadoop.**</exclude>
+ <exclude>META-INF/services/javax.**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <!-- Force relocation of all HBase dependencies. -->
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.htrace</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.htrace</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.yammer.metrics</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-logging</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-logging</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-lang</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-lang</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-configuration</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-configuration</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-codec</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-codec</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty:netty-all</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.hbase</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.hbase</shadedPattern>
Review comment:
@openinx according the current logic of e2e test, I just download the hbase tarball and unarchive it, there is no shade hbase jar exists in the classpath of hbase server. How can I reappear this problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-645209950
Continue to discuss in #12687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-639196851
@flinkbot approve all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] openinx commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r440660808
##########
File path: flink-connectors/flink-sql-connector-hbase/pom.xml
##########
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <name>flink-sql-connector-hbase</name>
+
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.flink:flink-connector-hbase_${scala.binary.version}</include>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.zookeeper:zookeeper</include>
+ <include>org.apache.htrace:htrace-core</include>
+ <include>com.google.guava:guava</include>
+ <include>com.google.protobuf:protobuf-java</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>commons-logging:commons-logging</include>
+ <include>commons-lang:commons-lang</include>
+ <include>commons-configuration:commons-configuration</include>
+ <include>commons-codec:commons-codec</include>
+ <include>io.netty:netty-all</include>
+ </includes>
+ <excludes>
+ <exclude>org.apache.hbase:hbase-metrics*</exclude>
+ <exclude>org.apache.hbase:hbase-server*</exclude>
+ </excludes>
+ </artifactSet>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/services/com.fasterxml.**</exclude>
+ <exclude>META-INF/services/org.apache.hadoop.**</exclude>
+ <exclude>META-INF/services/javax.**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <!-- Force relocation of all HBase dependencies. -->
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.htrace</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.htrace</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.yammer.metrics</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-logging</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-logging</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-lang</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-lang</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-configuration</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-configuration</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-codec</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-codec</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty:netty-all</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.hbase</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.hbase</shadedPattern>
Review comment:
Hi I read the codes in hbase [repo](https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java#L1909). If client passed the correct class name `org.apache.hadoop.hbase.CellScanner`, then the region server will load the correct class for it ( from its own classpath), so in theory this exception `java.lang.IncompatibleClassChangeError: Class org.apache.hadoop.hbase.codec.KeyValueCodec$KeyValueDecoder does not implement the requested interface org.apache.hadoop.hbase.CellScanner` shouldn't be thrown.
(I did not remember the way to reproduce this stacktrace now... ) Let's move this pull requests forward if the e2e test could pass.. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 923273e1eed813d62522fb270c250d207ce2a389 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620)
* 39607521051aea24e2f4805a428bb1469745287d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 518368f03c225bf1cdc2065382539f7f49f6c4e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333)
* 5e812cd62bcab9b71b1cb0fd1d86a10bb9795178 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438561409
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
@leonardBang I sitll use shade hadoop rather than set HADOOP_CLASSPATH. Because it's not easy to set system environment before submit sql job.Unlike what e2e test done before, we can use function `set_hadoop_classpath` in `common.sh` to configure HADOOP_CLASSPATH. So I think it's should be a new issue and just created on jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r439917272
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
+1 to remvoe Hadoop jar if we are running with Hadoop profile.
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/hbase-default.xml
##########
@@ -0,0 +1,1558 @@
+<?xml version="1.0"?>
+<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<!--
+OVERVIEW
+The important configs. are listed near the top. You should change
+at least the setting for hbase.tmp.dir. Other settings will change
+dependent on whether you are running hbase in standalone mode or
+distributed. See the hbase reference guide for requirements and
+guidance making configuration.
+This file does not contain all possible configurations. The file would be
+much larger if it carried everything. The absent configurations will only be
+found through source code reading. The idea is that such configurations are
+exotic and only those who would go to the trouble of reading a particular
+section in the code would be knowledgeable or invested enough in ever wanting
+to alter such configurations, so we do not list them here. Listing all
+possible configurations would overwhelm and obscure the important.
+-->
+
+<configuration>
Review comment:
Why do we need this file at client side?
##########
File path: flink-connectors/pom.xml
##########
@@ -57,6 +57,7 @@ under the License.
<module>flink-connector-gcp-pubsub</module>
<module>flink-connector-kinesis</module>
<module>flink-sql-connector-elasticsearch7</module>
+ <module>flink-sql-connector-hbase</module>
Review comment:
Move `<module>flink-sql-connector-hbase</module>` and `<module>flink-sql-connector-elasticsearch7</module>` into the following `sql-jars` profile.
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/resources/hbase_source_sink_schema.yaml
##########
@@ -0,0 +1,55 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+tables:
+ - name: MyHBaseSource
+ type: source-table
+ schema:
+ - name: rowkey
+ type: STRING
+ - name: a
+ type: ROW<c1 STRING>
+ - name: b
+ type: ROW<c1 STRING>
+ connector:
+ type: "hbase"
+ version: "1.4.3"
+ table-name: "source_table"
+ zookeeper:
+ quorum: "localhost:2181"
+ znode.parent: "/hbase"
+ - name: MyHBaseSink
+ type: sink-table
+ schema:
+ - name: rowkey
+ type: STRING
+ - name: a
+ type: ROW<c1 STRING>
+ - name: b
+ type: ROW<c1 STRING>
+ connector:
+ type: "hbase"
+ version: "1.4.3"
+ table-name: "sink_table"
+ zookeeper:
+ quorum: "localhost:2181"
+ znode.parent: "/hbase"
+ write.buffer-flush:
+ max-size: "2mb"
+ max-rows: 1000
Review comment:
We can use `max-rows: 1` to quickly flush the messages instead of waiting for 2 seconds.
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/LocalStandaloneHBaseResource.java
##########
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.CommandLineWrapper;
+import org.apache.flink.tests.util.activation.OperatingSystemRestriction;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.util.OperatingSystem;
+
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Consumer;
+import java.util.stream.Collectors;
+
+/**
+ * {@link HBaseResource} that downloads hbase and set up a local hbase cluster.
+ */
+public class LocalStandaloneHBaseResource implements HBaseResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneHBaseResource.class);
+
+ private final TemporaryFolder tmp = new TemporaryFolder();
+
+ private final DownloadCache downloadCache = DownloadCache.get();
+ private Path hbaseDir;
+
+ LocalStandaloneHBaseResource() {
+ OperatingSystemRestriction.forbid(
+ String.format("The %s relies on UNIX utils and shell scripts.", getClass().getSimpleName()),
+ OperatingSystem.WINDOWS);
+ }
+
+ private static String getHBaseDownloadUrl() {
+ return "https://archive.apache.org/dist/hbase/1.4.3/hbase-1.4.3-bin.tar.gz";
+ }
+
+ @Override
+ public void before() throws Exception {
+ tmp.create();
+ downloadCache.before();
+
+ this.hbaseDir = tmp.newFolder("hbase").toPath().toAbsolutePath();
+ setupHBaseDist();
+ setupHBaseCluster();
+ }
+
+ private void setupHBaseDist() throws IOException {
+ final Path downloadDirectory = tmp.newFolder("getOrDownload").toPath();
+ final Path hbaseArchive = downloadCache.getOrDownload(getHBaseDownloadUrl(), downloadDirectory);
+
+ LOG.info("HBase localtion: {}", hbaseDir.toAbsolutePath());
+ AutoClosableProcess.runBlocking(CommandLineWrapper
+ .tar(hbaseArchive)
+ .extract()
+ .zipped()
+ .strip(1)
+ .targetDir(hbaseDir)
+ .build());
+
+ LOG.info("Configure {} as hbase.tmp.dir", hbaseDir.toAbsolutePath());
+ final String tmpDirConfig = "<configuration><property><name>hbase.tmp.dir</name><value>" + hbaseDir + "</value></property></configuration>";
+ Files.write(hbaseDir.resolve(Paths.get("conf", "hbase-site.xml")), tmpDirConfig.getBytes());
+ }
+
+ private void setupHBaseCluster() throws IOException {
+ LOG.info("Starting HBase cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "start-hbase.sh")).toString());
+
+ while (!isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to start");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+ }
+
+ @Override
+ public void afterTestSuccess() {
+ try {
+ LOG.info("Stopping HBase Cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "hbase-daemon.sh")).toString(),
+ "stop",
+ "master");
+
+ while (isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to stop");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+
+ } catch (IOException ioe) {
+ LOG.warn("Error while shutting down hbase.", ioe);
+ }
+ downloadCache.afterTestSuccess();
+ tmp.delete();
+ }
+
+ private static boolean isHBaseRunning() {
+ try {
+ final AtomicBoolean atomicHMasterStarted = new AtomicBoolean(false);
+ queryHMasterStatus(line -> atomicHMasterStarted.compareAndSet(false, line.contains("HMaster")));
+ return atomicHMasterStarted.get();
+ } catch (IOException ioe) {
+ return false;
+ }
+ }
+
+ private static void queryHMasterStatus(final Consumer<String> stdoutProcessor) throws IOException {
+ AutoClosableProcess
+ .create("jps")
Review comment:
???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21da7909b9b5bf9fd4963d592da500752ab7c295 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415)
* 08539af1e82e9ef40d9814fc4c787c9f66d3f33e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-644879549
Let us keep going in https://github.com/apache/flink/pull/12369
CC @wuchong @JingsongLi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
}, {
"hash" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009",
"triggerID" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"triggerType" : "PUSH"
}, {
"hash" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102",
"triggerID" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"triggerType" : "PUSH"
}, {
"hash" : "36c655ad70e59179ad503796797333898a98fdce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "36c655ad70e59179ad503796797333898a98fdce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 586cad86df6ee5de33537f735fa5c65cabebe260 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102)
* 36c655ad70e59179ad503796797333898a98fdce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
}, {
"hash" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009",
"triggerID" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"triggerType" : "PUSH"
}, {
"hash" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102",
"triggerID" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"triggerType" : "PUSH"
}, {
"hash" : "36c655ad70e59179ad503796797333898a98fdce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3241",
"triggerID" : "36c655ad70e59179ad503796797333898a98fdce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36c655ad70e59179ad503796797333898a98fdce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438561409
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
@leonardBang I sitll use shade hadoop rather than set HADOOP_CLASSPATH. Because it's not easy to set system environment before submit sql job.Unlike what e2e test done before, we can use function `set_hadoop_classpath` in `common.sh` to configure HADOOP_CLASSPATH. So I think it's should be a new issue and just created on jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r439409344
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
A simple way is to let the E2E test run in the environment with HADOOP profile, the default CI build should be [PROFILE](https://github.com/apache/flink/blob/master/azure-pipelines.yml#L69). IIUC, we do not need to down load the shaded hadoop jar, the E2E test should run normally. Could you have a try ? @DashShen
And @rmetzger could you help confirm this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-644514878
@wuchong Sorry, due to my personal physical reasons, I don't have enough time to finish this work recently.You can assignee others to finish this. I'll be involved in community work later when my back pain recovery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e812cd62bcab9b71b1cb0fd1d86a10bb9795178 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386)
* 21da7909b9b5bf9fd4963d592da500752ab7c295 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12369: Flink 17678
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f49fb611425fd075c0818233472ece2a4a824d71 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r436652977
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
+ * @param columnFamily columnFamily of the given data
+ * @param key key of the given data
+ * @param value value of the given data
+ * @throws IOException
+ */
+ void putData(String tableName, String rowKey, String columnFamily, String key, String value) throws IOException;
+
+ /**
+ * Returns the configured HBaseResource implementation, or a {@link LocalStandaloneHBaseResource} if none is configured.
+ *
+ * @return configured HbaseResource, or {@link LocalStandaloneHBaseResource} is none is configured
Review comment:
```suggestion
* @return configured HbaseResource, or {@link LocalStandaloneHBaseResource} if none is configured
```
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
Could we use download Hadoop and set HADOOP_CLASSPATH to replace using shaded Hadoop jar? because Flink does not recommend using shaded Hadoop jar Starting from Flink 1.11
##########
File path: flink-connectors/pom.xml
##########
@@ -58,6 +58,7 @@ under the License.
<module>flink-connector-kinesis</module>
<module>flink-sql-connector-elasticsearch7</module>
<module>flink-connector-base</module>
+ <module>flink-sql-connector-hbase</module>
Review comment:
we can move to front of flink-connector-base to keep the order
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/LocalStandaloneHBaseResource.java
##########
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.CommandLineWrapper;
+import org.apache.flink.tests.util.activation.OperatingSystemRestriction;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.util.OperatingSystem;
+
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Consumer;
+
+/**
+ * {@link HBaseResource} that downloads hbase and set up a local hbase cluster.
+ */
+public class LocalStandaloneHBaseResource implements HBaseResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneHBaseResource.class);
+
+ private final TemporaryFolder tmp = new TemporaryFolder();
+
+ private final DownloadCache downloadCache = DownloadCache.get();
+ private Path hbaseDir;
+
+ LocalStandaloneHBaseResource() {
+ OperatingSystemRestriction.forbid(
+ String.format("The %s relies on UNIX utils and shell scripts.", getClass().getSimpleName()),
+ OperatingSystem.WINDOWS);
+ }
+
+ private static String getHBaseDownloadUrl() {
+ return "http://archive.apache.org/dist/hbase/1.4.3/hbase-1.4.3-bin.tar.gz";
Review comment:
```suggestion
return "https://archive.apache.org/dist/hbase/1.4.3/hbase-1.4.3-bin.tar.gz";
```
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
Review comment:
row key
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
+ * @param columnFamily columnFamily of the given data
+ * @param key key of the given data
+ * @param value value of the given data
+ * @throws IOException
+ */
+ void putData(String tableName, String rowKey, String columnFamily, String key, String value) throws IOException;
+
+ /**
+ * Returns the configured HBaseResource implementation, or a {@link LocalStandaloneHBaseResource} if none is configured.
+ *
+ * @return configured HbaseResource, or {@link LocalStandaloneHBaseResource} is none is configured
Review comment:
And also help update `KafkaResource` too ^_^
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
+ * @param columnFamily columnFamily of the given data
+ * @param key key of the given data
Review comment:
key -> columnQualifier?
columnQualifier columnQualifier of the given data ?
```suggestion
* @param columnQualifier column qualifier of the given data
```
HBase always uses **RowKey : column family : column qualifier** to describe the schema
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/LocalStandaloneHBaseResource.java
##########
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.CommandLineWrapper;
+import org.apache.flink.tests.util.activation.OperatingSystemRestriction;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.util.OperatingSystem;
+
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Consumer;
+
+/**
+ * {@link HBaseResource} that downloads hbase and set up a local hbase cluster.
+ */
+public class LocalStandaloneHBaseResource implements HBaseResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneHBaseResource.class);
+
+ private final TemporaryFolder tmp = new TemporaryFolder();
+
+ private final DownloadCache downloadCache = DownloadCache.get();
+ private Path hbaseDir;
+
+ LocalStandaloneHBaseResource() {
+ OperatingSystemRestriction.forbid(
+ String.format("The %s relies on UNIX utils and shell scripts.", getClass().getSimpleName()),
+ OperatingSystem.WINDOWS);
+ }
+
+ private static String getHBaseDownloadUrl() {
+ return "http://archive.apache.org/dist/hbase/1.4.3/hbase-1.4.3-bin.tar.gz";
+ }
+
+ @Override
+ public void before() throws Exception {
+ tmp.create();
+ downloadCache.before();
+
+ this.hbaseDir = tmp.newFolder("hbase").toPath().toAbsolutePath();
+ setupHBaseDist();
+ setupHBaseCluster();
+ }
+
+ private void setupHBaseDist() throws IOException {
+ final Path downloadDirectory = tmp.newFolder("getOrDownload").toPath();
+ final Path hbaseArchive = downloadCache.getOrDownload(getHBaseDownloadUrl(), downloadDirectory);
+
+ LOG.info("HBase localtion: {}", hbaseDir.toAbsolutePath());
+ AutoClosableProcess.runBlocking(CommandLineWrapper
+ .tar(hbaseArchive)
+ .extract()
+ .zipped()
+ .strip(1)
+ .targetDir(hbaseDir)
+ .build());
+
+ LOG.info("Configure {} as hbase.tmp.dir", hbaseDir.toAbsolutePath());
+ final String tmpDirConfig = "<configuration><property><name>hbase.tmp.dir</name><value>" + hbaseDir + "</value></property></configuration>";
+ Files.write(hbaseDir.resolve(Paths.get("conf", "hbase-site.xml")), tmpDirConfig.getBytes());
+ }
+
+ private void setupHBaseCluster() throws IOException {
+ LOG.info("Starting HBase cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "start-hbase.sh")).toString());
+
+ while (!isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to start");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+ }
+
+ @Override
+ public void afterTestSuccess() {
+ try {
+ LOG.info("Stopping HBase Cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "hbase-daemon.sh")).toString(),
+ "stop",
+ "master");
+
+ while (isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to stop");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+
+ } catch (IOException ioe) {
+ LOG.warn("Error while shutting down hbase.", ioe);
+ }
+ downloadCache.afterTestSuccess();
+ tmp.delete();
+ }
+
+ private static boolean isHBaseRunning() {
+ try {
+ final AtomicBoolean atomicHMasterStarted = new AtomicBoolean(false);
+ queryHMasterStatus(line -> atomicHMasterStarted.compareAndSet(false, line.contains("HMaster")));
+ return atomicHMasterStarted.get();
+ } catch (IOException ioe) {
+ return false;
+ }
+ }
+
+ private static void queryHMasterStatus(final Consumer<String> stdoutProcessor) throws IOException {
+ AutoClosableProcess
+ .create("jps")
+ .setStdoutProcessor(stdoutProcessor)
+ .runBlocking();
+ }
+
+ @Override
+ public void createTable(String tableName, String... columnFamilies) throws IOException {
+ final StringBuilder createTableBuilder = new StringBuilder();
+ createTableBuilder.append("create").append(" ");
+ createTableBuilder.append(String.format("'%s'", tableName)).append(",");
+ for (final String columnFamily : columnFamilies) {
+ createTableBuilder
+ .append(String.format("{NAME=>'%s'}", columnFamily))
+ .append(",");
+ }
+
+ // Remove last illegal comma
+ createTableBuilder.deleteCharAt(createTableBuilder.lastIndexOf(","));
Review comment:
can simplify to:
```
createTableBuilder.append(Arrays.stream(columnFamilies)
.map(cf -> String.format("{NAME=>'%s'}", cf))
.collect(Collectors.joining(",")));
```
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
+ * @param columnFamily columnFamily of the given data
+ * @param key key of the given data
+ * @param value value of the given data
+ * @throws IOException
+ */
+ void putData(String tableName, String rowKey, String columnFamily, String key, String value) throws IOException;
Review comment:
String key -> String columnQualifier, and also update its subclass
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/LocalStandaloneHBaseResource.java
##########
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.CommandLineWrapper;
+import org.apache.flink.tests.util.activation.OperatingSystemRestriction;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.util.OperatingSystem;
+
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Consumer;
+
+/**
+ * {@link HBaseResource} that downloads hbase and set up a local hbase cluster.
+ */
+public class LocalStandaloneHBaseResource implements HBaseResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneHBaseResource.class);
+
+ private final TemporaryFolder tmp = new TemporaryFolder();
+
+ private final DownloadCache downloadCache = DownloadCache.get();
+ private Path hbaseDir;
+
+ LocalStandaloneHBaseResource() {
+ OperatingSystemRestriction.forbid(
+ String.format("The %s relies on UNIX utils and shell scripts.", getClass().getSimpleName()),
+ OperatingSystem.WINDOWS);
+ }
+
+ private static String getHBaseDownloadUrl() {
+ return "http://archive.apache.org/dist/hbase/1.4.3/hbase-1.4.3-bin.tar.gz";
+ }
+
+ @Override
+ public void before() throws Exception {
+ tmp.create();
+ downloadCache.before();
+
+ this.hbaseDir = tmp.newFolder("hbase").toPath().toAbsolutePath();
+ setupHBaseDist();
+ setupHBaseCluster();
+ }
+
+ private void setupHBaseDist() throws IOException {
+ final Path downloadDirectory = tmp.newFolder("getOrDownload").toPath();
+ final Path hbaseArchive = downloadCache.getOrDownload(getHBaseDownloadUrl(), downloadDirectory);
+
+ LOG.info("HBase localtion: {}", hbaseDir.toAbsolutePath());
+ AutoClosableProcess.runBlocking(CommandLineWrapper
+ .tar(hbaseArchive)
+ .extract()
+ .zipped()
+ .strip(1)
+ .targetDir(hbaseDir)
+ .build());
+
+ LOG.info("Configure {} as hbase.tmp.dir", hbaseDir.toAbsolutePath());
+ final String tmpDirConfig = "<configuration><property><name>hbase.tmp.dir</name><value>" + hbaseDir + "</value></property></configuration>";
+ Files.write(hbaseDir.resolve(Paths.get("conf", "hbase-site.xml")), tmpDirConfig.getBytes());
+ }
+
+ private void setupHBaseCluster() throws IOException {
+ LOG.info("Starting HBase cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "start-hbase.sh")).toString());
+
+ while (!isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to start");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+ }
+
+ @Override
+ public void afterTestSuccess() {
+ try {
+ LOG.info("Stopping HBase Cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "hbase-daemon.sh")).toString(),
+ "stop",
+ "master");
+
+ while (isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to stop");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+
+ } catch (IOException ioe) {
+ LOG.warn("Error while shutting down hbase.", ioe);
+ }
+ downloadCache.afterTestSuccess();
+ tmp.delete();
+ }
+
+ private static boolean isHBaseRunning() {
+ try {
+ final AtomicBoolean atomicHMasterStarted = new AtomicBoolean(false);
+ queryHMasterStatus(line -> atomicHMasterStarted.compareAndSet(false, line.contains("HMaster")));
+ return atomicHMasterStarted.get();
+ } catch (IOException ioe) {
+ return false;
+ }
+ }
+
+ private static void queryHMasterStatus(final Consumer<String> stdoutProcessor) throws IOException {
+ AutoClosableProcess
+ .create("jps")
+ .setStdoutProcessor(stdoutProcessor)
+ .runBlocking();
+ }
+
+ @Override
+ public void createTable(String tableName, String... columnFamilies) throws IOException {
+ final StringBuilder createTableBuilder = new StringBuilder();
+ createTableBuilder.append("create").append(" ");
+ createTableBuilder.append(String.format("'%s'", tableName)).append(",");
+ for (final String columnFamily : columnFamilies) {
+ createTableBuilder
+ .append(String.format("{NAME=>'%s'}", columnFamily))
+ .append(",");
+ }
+
+ // Remove last illegal comma
+ createTableBuilder.deleteCharAt(createTableBuilder.lastIndexOf(","));
+
+ executeHBaseShell(createTableBuilder.toString());
+ }
+
+ @Override
+ public List<String> scanTable(String tableName) throws IOException {
+ final List<String> result = new ArrayList<>();
+ executeHBaseShell(String.format("scan '%s'", tableName), line -> {
+ if (line.contains("value=")) {
+ result.add(line);
+ }
+ });
+ return result;
+ }
+
+ @Override
+ public void putData(String tableName, String rowKey, String columnFamily, String key, String value) throws IOException {
+ final StringBuilder putDataBuilder = new StringBuilder();
+ putDataBuilder
+ .append("put").append(" ")
+ .append(String.format("'%s'", tableName)).append(",")
+ .append(String.format("'%s'", rowKey)).append(",")
+ .append(String.format("'%s:%s'", columnFamily, key)).append(",")
+ .append(String.format("'%s'", value));
+
+ executeHBaseShell(putDataBuilder.toString());
Review comment:
```
executeHBaseShell(String.format(
"put '%s','%s','%s':'%s', '%s'", tableName, rowKey, columnFamily, columnQualifier, value));
```
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,13 @@
+flink-sql-connector-hbase
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.hbase:hbase-server:1.4.3
+- org.apache.zookeeper:zookeeper:3.4.10
+- org.apache.htrace:htrace-core:3.1.0-incubating
+
+
Review comment:
redundant empty lines
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/resources/hbase_source_sink_schema.yaml
##########
@@ -0,0 +1,57 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+tables:
+ - name: MyHBaseSource
+ type: source-table
+ connector:
Review comment:
Could we use new connector property keys which implements in FLIP-122 so that the e2e test can cover new HBase connector rather than legacy ?
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/LocalStandaloneHBaseResource.java
##########
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.CommandLineWrapper;
+import org.apache.flink.tests.util.activation.OperatingSystemRestriction;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.util.OperatingSystem;
+
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Consumer;
+
+/**
+ * {@link HBaseResource} that downloads hbase and set up a local hbase cluster.
+ */
+public class LocalStandaloneHBaseResource implements HBaseResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneHBaseResource.class);
+
+ private final TemporaryFolder tmp = new TemporaryFolder();
+
+ private final DownloadCache downloadCache = DownloadCache.get();
+ private Path hbaseDir;
+
+ LocalStandaloneHBaseResource() {
+ OperatingSystemRestriction.forbid(
+ String.format("The %s relies on UNIX utils and shell scripts.", getClass().getSimpleName()),
+ OperatingSystem.WINDOWS);
+ }
+
+ private static String getHBaseDownloadUrl() {
+ return "http://archive.apache.org/dist/hbase/1.4.3/hbase-1.4.3-bin.tar.gz";
+ }
+
+ @Override
+ public void before() throws Exception {
+ tmp.create();
+ downloadCache.before();
+
+ this.hbaseDir = tmp.newFolder("hbase").toPath().toAbsolutePath();
+ setupHBaseDist();
+ setupHBaseCluster();
+ }
+
+ private void setupHBaseDist() throws IOException {
+ final Path downloadDirectory = tmp.newFolder("getOrDownload").toPath();
+ final Path hbaseArchive = downloadCache.getOrDownload(getHBaseDownloadUrl(), downloadDirectory);
+
+ LOG.info("HBase localtion: {}", hbaseDir.toAbsolutePath());
+ AutoClosableProcess.runBlocking(CommandLineWrapper
+ .tar(hbaseArchive)
+ .extract()
+ .zipped()
+ .strip(1)
+ .targetDir(hbaseDir)
+ .build());
+
+ LOG.info("Configure {} as hbase.tmp.dir", hbaseDir.toAbsolutePath());
+ final String tmpDirConfig = "<configuration><property><name>hbase.tmp.dir</name><value>" + hbaseDir + "</value></property></configuration>";
+ Files.write(hbaseDir.resolve(Paths.get("conf", "hbase-site.xml")), tmpDirConfig.getBytes());
+ }
+
+ private void setupHBaseCluster() throws IOException {
+ LOG.info("Starting HBase cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "start-hbase.sh")).toString());
+
+ while (!isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to start");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+ }
+
+ @Override
+ public void afterTestSuccess() {
+ try {
+ LOG.info("Stopping HBase Cluster");
+ AutoClosableProcess.runBlocking(
+ hbaseDir.resolve(Paths.get("bin", "hbase-daemon.sh")).toString(),
+ "stop",
+ "master");
+
+ while (isHBaseRunning()) {
+ try {
+ LOG.info("Waiting for HBase to stop");
+ Thread.sleep(500L);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ break;
+ }
+ }
+
+ } catch (IOException ioe) {
+ LOG.warn("Error while shutting down hbase.", ioe);
+ }
+ downloadCache.afterTestSuccess();
+ tmp.delete();
+ }
+
+ private static boolean isHBaseRunning() {
+ try {
+ final AtomicBoolean atomicHMasterStarted = new AtomicBoolean(false);
+ queryHMasterStatus(line -> atomicHMasterStarted.compareAndSet(false, line.contains("HMaster")));
+ return atomicHMasterStarted.get();
+ } catch (IOException ioe) {
+ return false;
+ }
+ }
+
+ private static void queryHMasterStatus(final Consumer<String> stdoutProcessor) throws IOException {
+ AutoClosableProcess
+ .create("jps")
+ .setStdoutProcessor(stdoutProcessor)
+ .runBlocking();
+ }
+
+ @Override
+ public void createTable(String tableName, String... columnFamilies) throws IOException {
+ final StringBuilder createTableBuilder = new StringBuilder();
+ createTableBuilder.append("create").append(" ");
+ createTableBuilder.append(String.format("'%s'", tableName)).append(",");
+ for (final String columnFamily : columnFamilies) {
+ createTableBuilder
+ .append(String.format("{NAME=>'%s'}", columnFamily))
+ .append(",");
+ }
+
+ // Remove last illegal comma
+ createTableBuilder.deleteCharAt(createTableBuilder.lastIndexOf(","));
+
+ executeHBaseShell(createTableBuilder.toString());
+ }
+
+ @Override
+ public List<String> scanTable(String tableName) throws IOException {
+ final List<String> result = new ArrayList<>();
+ executeHBaseShell(String.format("scan '%s'", tableName), line -> {
+ if (line.contains("value=")) {
+ result.add(line);
+ }
+ });
+ return result;
+ }
+
+ @Override
+ public void putData(String tableName, String rowKey, String columnFamily, String key, String value) throws IOException {
Review comment:
String key -> String columnQualifier
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/main/java/org/apache/flink/tests/util/hbase/HBaseResource.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.util.FactoryUtils;
+import org.apache.flink.util.ExternalResource;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Generic interface for interacting with HBase.
+ */
+public interface HBaseResource extends ExternalResource {
+
+ /**
+ * Creates a table with the given name and column families.
+ *
+ * @param tableName desired table name
+ * @param columnFamilies column family to create
+ * @throws IOException
+ */
+ void createTable(String tableName, String... columnFamilies) throws IOException;
+
+ /**
+ * Scan the given HBase table.
+ *
+ * @param tableName table desired to scan
+ * @throws IOException
+ */
+ List<String> scanTable(String tableName) throws IOException;
+
+ /**
+ * Put the given data to the given table.
+ *
+ * @param tableName table to put data
+ * @param rowKey rowKey of the given data
+ * @param columnFamily columnFamily of the given data
Review comment:
column family
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/hbase-default.xml
##########
@@ -0,0 +1,1442 @@
+<?xml version="1.0"?>
+<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<!--
+OVERVIEW
+The important configs. are listed near the top. You should change
+at least the setting for hbase.tmp.dir. Other settings will change
+dependent on whether you are running hbase in standalone mode or
+distributed. See the hbase reference guide for requirements and
+guidance making configuration.
+This file does not contain all possible configurations. The file would be
+much larger if it carried everything. The absent configurations will only be
+found through source code reading. The idea is that such configurations are
+exotic and only those who would go to the trouble of reading a particular
+section in the code would be knowledgeable or invested enough in ever wanting
+to alter such configurations, so we do not list them here. Listing all
+possible configurations would overwhelm and obscure the important.
+-->
+
+<configuration>
+ <!--Configs you will likely change are listed here at the top of the file.
+ -->
+ <property>
+ <name>hbase.tmp.dir</name>
+ <value>${java.io.tmpdir}/hbase-${user.name}</value>
+ <description>Temporary directory on the local filesystem.
+ Change this setting to point to a location more permanent
+ than '/tmp', the usual resolve for java.io.tmpdir, as the
+ '/tmp' directory is cleared on machine restart.</description>
+ </property>
+ <property>
+ <name>hbase.rootdir</name>
+ <value>${hbase.tmp.dir}/hbase</value>
+ <description>The directory shared by region servers and into
+ which HBase persists. The URL should be 'fully-qualified'
+ to include the filesystem scheme. For example, to specify the
+ HDFS directory '/hbase' where the HDFS instance's namenode is
+ running at namenode.example.org on port 9000, set this value to:
+ hdfs://namenode.example.org:9000/hbase. By default, we write
+ to whatever ${hbase.tmp.dir} is set too -- usually /tmp --
+ so change this configuration or else all data will be lost on
+ machine restart.</description>
+ </property>
+ <property >
+ <name>hbase.fs.tmp.dir</name>
+ <value>/user/${user.name}/hbase-staging</value>
+ <description>A staging directory in default file system (HDFS)
+ for keeping temporary data.
+ </description>
+ </property>
+ <property >
+ <name>hbase.bulkload.staging.dir</name>
+ <value>${hbase.fs.tmp.dir}</value>
+ <description>A staging directory in default file system (HDFS)
+ for bulk loading.
+ </description>
+ </property>
+ <property >
+ <name>hbase.cluster.distributed</name>
+ <value>false</value>
+ <description>The mode the cluster will be in. Possible values are
+ false for standalone mode and true for distributed mode. If
+ false, startup will run all HBase and ZooKeeper daemons together
+ in the one JVM.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.quorum</name>
+ <value>localhost</value>
+ <description>Comma separated list of servers in the ZooKeeper ensemble
+ (This config. should have been named hbase.zookeeper.ensemble).
+ For example, "host1.mydomain.com,host2.mydomain.com,host3.mydomain.com".
+ By default this is set to localhost for local and pseudo-distributed modes
+ of operation. For a fully-distributed setup, this should be set to a full
+ list of ZooKeeper ensemble servers. If HBASE_MANAGES_ZK is set in hbase-env.sh
+ this is the list of servers which hbase will start/stop ZooKeeper on as
+ part of cluster start/stop. Client-side, we will take this list of
+ ensemble members and put it together with the hbase.zookeeper.clientPort
+ config. and pass it into zookeeper constructor as the connectString
+ parameter.</description>
+ </property>
+ <!--The above are the important configurations for getting hbase up
+ and running -->
+
+ <property>
+ <name>zookeeper.recovery.retry.maxsleeptime</name>
+ <value>60000</value>
+ <description>Max sleep time before retry zookeeper operations in milliseconds,
+ a max time is needed here so that sleep time won't grow unboundedly
+ </description>
+ </property>
+ <property>
+ <name>hbase.local.dir</name>
+ <value>${hbase.tmp.dir}/local/</value>
+ <description>Directory on the local filesystem to be used
+ as a local storage.</description>
+ </property>
+
+ <!--Master configurations-->
+ <property >
+ <name>hbase.master.port</name>
+ <value>16000</value>
+ <description>The port the HBase Master should bind to.</description>
+ </property>
+ <property>
+ <name>hbase.master.info.port</name>
+ <value>16010</value>
+ <description>The port for the HBase Master web UI.
+ Set to -1 if you do not want a UI instance run.</description>
+ </property>
+ <property>
+ <name>hbase.master.info.bindAddress</name>
+ <value>0.0.0.0</value>
+ <description>The bind address for the HBase Master web UI
+ </description>
+ </property>
+ <property>
+ <name>hbase.master.logcleaner.ttl</name>
+ <value>600000</value>
+ <description>Maximum time a WAL can stay in the .oldlogdir directory,
+ after which it will be cleaned by a Master thread.</description>
+ </property>
+ <property>
+ <name>hbase.master.infoserver.redirect</name>
+ <value>true</value>
+ <description>Whether or not the Master listens to the Master web
+ UI port (hbase.master.info.port) and redirects requests to the web
+ UI server shared by the Master and RegionServer.</description>
+ </property>
+
+ <!--RegionServer configurations-->
+ <property>
+ <name>hbase.regionserver.port</name>
+ <value>16020</value>
+ <description>The port the HBase RegionServer binds to.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.info.port</name>
+ <value>16030</value>
+ <description>The port for the HBase RegionServer web UI
+ Set to -1 if you do not want the RegionServer UI to run.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.info.bindAddress</name>
+ <value>0.0.0.0</value>
+ <description>The address for the HBase RegionServer web UI</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.info.port.auto</name>
+ <value>false</value>
+ <description>Whether or not the Master or RegionServer
+ UI should search for a port to bind to. Enables automatic port
+ search if hbase.regionserver.info.port is already in use.
+ Useful for testing, turned off by default.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.handler.count</name>
+ <value>30</value>
+ <description>Count of RPC Listener instances spun up on RegionServers.
+ Same property is used by the Master for count of master handlers.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.callqueue.handler.factor</name>
+ <value>0.1</value>
+ <description>Factor to determine the number of call queues.
+ A value of 0 means a single queue shared between all the handlers.
+ A value of 1 means that each handler has its own queue.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.callqueue.read.ratio</name>
+ <value>0</value>
+ <description>Split the call queues into read and write queues.
+ The specified interval (which should be between 0.0 and 1.0)
+ will be multiplied by the number of call queues.
+ A value of 0 indicate to not split the call queues, meaning that both read and write
+ requests will be pushed to the same set of queues.
+ A value lower than 0.5 means that there will be less read queues than write queues.
+ A value of 0.5 means there will be the same number of read and write queues.
+ A value greater than 0.5 means that there will be more read queues than write queues.
+ A value of 1.0 means that all the queues except one are used to dispatch read requests.
+
+ Example: Given the total number of call queues being 10
+ a read.ratio of 0 means that: the 10 queues will contain both read/write requests.
+ a read.ratio of 0.3 means that: 3 queues will contain only read requests
+ and 7 queues will contain only write requests.
+ a read.ratio of 0.5 means that: 5 queues will contain only read requests
+ and 5 queues will contain only write requests.
+ a read.ratio of 0.8 means that: 8 queues will contain only read requests
+ and 2 queues will contain only write requests.
+ a read.ratio of 1 means that: 9 queues will contain only read requests
+ and 1 queues will contain only write requests.
+ </description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.callqueue.scan.ratio</name>
+ <value>0</value>
+ <description>Given the number of read call queues, calculated from the total number
+ of call queues multiplied by the callqueue.read.ratio, the scan.ratio property
+ will split the read call queues into small-read and long-read queues.
+ A value lower than 0.5 means that there will be less long-read queues than short-read queues.
+ A value of 0.5 means that there will be the same number of short-read and long-read queues.
+ A value greater than 0.5 means that there will be more long-read queues than short-read queues
+ A value of 0 or 1 indicate to use the same set of queues for gets and scans.
+
+ Example: Given the total number of read call queues being 8
+ a scan.ratio of 0 or 1 means that: 8 queues will contain both long and short read requests.
+ a scan.ratio of 0.3 means that: 2 queues will contain only long-read requests
+ and 6 queues will contain only short-read requests.
+ a scan.ratio of 0.5 means that: 4 queues will contain only long-read requests
+ and 4 queues will contain only short-read requests.
+ a scan.ratio of 0.8 means that: 6 queues will contain only long-read requests
+ and 2 queues will contain only short-read requests.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.msginterval</name>
+ <value>3000</value>
+ <description>Interval between messages from the RegionServer to Master
+ in milliseconds.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.logroll.period</name>
+ <value>3600000</value>
+ <description>Period at which we will roll the commit log regardless
+ of how many edits it has.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.logroll.errors.tolerated</name>
+ <value>2</value>
+ <description>The number of consecutive WAL close errors we will allow
+ before triggering a server abort. A setting of 0 will cause the
+ region server to abort if closing the current WAL writer fails during
+ log rolling. Even a small value (2 or 3) will allow a region server
+ to ride over transient HDFS errors.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.global.memstore.size</name>
+ <value></value>
+ <description>Maximum size of all memstores in a region server before new
+ updates are blocked and flushes are forced. Defaults to 40% of heap (0.4).
+ Updates are blocked and flushes are forced until size of all memstores
+ in a region server hits hbase.regionserver.global.memstore.size.lower.limit.
+ The default value in this configuration has been intentionally left emtpy in order to
+ honor the old hbase.regionserver.global.memstore.upperLimit property if present.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.global.memstore.size.lower.limit</name>
+ <value></value>
+ <description>Maximum size of all memstores in a region server before flushes are forced.
+ Defaults to 95% of hbase.regionserver.global.memstore.size (0.95).
+ A 100% value for this value causes the minimum possible flushing to occur when updates are
+ blocked due to memstore limiting.
+ The default value in this configuration has been intentionally left emtpy in order to
+ honor the old hbase.regionserver.global.memstore.lowerLimit property if present.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.optionalcacheflushinterval</name>
+ <value>3600000</value>
+ <description>
+ Maximum amount of time an edit lives in memory before being automatically flushed.
+ Default 1 hour. Set it to 0 to disable automatic flushing.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.dns.interface</name>
+ <value>default</value>
+ <description>The name of the Network Interface from which a region server
+ should report its IP address.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.dns.nameserver</name>
+ <value>default</value>
+ <description>The host name or IP address of the name server (DNS)
+ which a region server should use to determine the host name used by the
+ master for communication and display purposes.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.regionSplitLimit</name>
+ <value>1000</value>
+ <description>
+ Limit for the number of regions after which no more region splitting should take place.
+ This is not hard limit for the number of regions but acts as a guideline for the regionserver
+ to stop splitting after a certain limit. Default is set to 1000.
+ </description>
+ </property>
+
+ <!--ZooKeeper configuration-->
+ <property>
+ <name>zookeeper.session.timeout</name>
+ <value>90000</value>
+ <description>ZooKeeper session timeout in milliseconds. It is used in two different ways.
+ First, this value is used in the ZK client that HBase uses to connect to the ensemble.
+ It is also used by HBase when it starts a ZK server and it is passed as the 'maxSessionTimeout'. See
+ http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#ch_zkSessions.
+ For example, if a HBase region server connects to a ZK ensemble that's also managed by HBase, then the
+ session timeout will be the one specified by this configuration. But, a region server that connects
+ to an ensemble managed with a different configuration will be subjected that ensemble's maxSessionTimeout. So,
+ even though HBase might propose using 90 seconds, the ensemble can have a max timeout lower than this and
+ it will take precedence. The current default that ZK ships with is 40 seconds, which is lower than HBase's.
+ </description>
+ </property>
+ <property>
+ <name>zookeeper.znode.parent</name>
+ <value>/hbase</value>
+ <description>Root ZNode for HBase in ZooKeeper. All of HBase's ZooKeeper
+ files that are configured with a relative path will go under this node.
+ By default, all of HBase's ZooKeeper file path are configured with a
+ relative path, so they will all go under this directory unless changed.</description>
+ </property>
+ <property>
+ <name>zookeeper.znode.acl.parent</name>
+ <value>acl</value>
+ <description>Root ZNode for access control lists.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.dns.interface</name>
+ <value>default</value>
+ <description>The name of the Network Interface from which a ZooKeeper server
+ should report its IP address.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.dns.nameserver</name>
+ <value>default</value>
+ <description>The host name or IP address of the name server (DNS)
+ which a ZooKeeper server should use to determine the host name used by the
+ master for communication and display purposes.</description>
+ </property>
+ <!--
+ The following three properties are used together to create the list of
+ host:peer_port:leader_port quorum servers for ZooKeeper.
+ -->
+ <property>
+ <name>hbase.zookeeper.peerport</name>
+ <value>2888</value>
+ <description>Port used by ZooKeeper peers to talk to each other.
+ See http://hadoop.apache.org/zookeeper/docs/r3.1.1/zookeeperStarted.html#sc_RunningReplicatedZooKeeper
+ for more information.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.leaderport</name>
+ <value>3888</value>
+ <description>Port used by ZooKeeper for leader election.
+ See http://hadoop.apache.org/zookeeper/docs/r3.1.1/zookeeperStarted.html#sc_RunningReplicatedZooKeeper
+ for more information.</description>
+ </property>
+ <!-- End of properties used to generate ZooKeeper host:port quorum list. -->
+ <property>
+ <name>hbase.zookeeper.useMulti</name>
+ <value>true</value>
+ <description>Instructs HBase to make use of ZooKeeper's multi-update functionality.
+ This allows certain ZooKeeper operations to complete more quickly and prevents some issues
+ with rare Replication failure scenarios (see the release note of HBASE-2611 for an example).
+ IMPORTANT: only set this to true if all ZooKeeper servers in the cluster are on version 3.4+
+ and will not be downgraded. ZooKeeper versions before 3.4 do not support multi-update and
+ will not fail gracefully if multi-update is invoked (see ZOOKEEPER-1495).</description>
+ </property>
+ <property>
+ <name>hbase.config.read.zookeeper.config</name>
+ <value>false</value>
+ <description>
+ Set to true to allow HBaseConfiguration to read the
+ zoo.cfg file for ZooKeeper properties. Switching this to true
+ is not recommended, since the functionality of reading ZK
+ properties from a zoo.cfg file has been deprecated.</description>
+ </property>
+ <!--
+ Beginning of properties that are directly mapped from ZooKeeper's zoo.cfg.
+ All properties with an "hbase.zookeeper.property." prefix are converted for
+ ZooKeeper's configuration. Hence, if you want to add an option from zoo.cfg,
+ e.g. "initLimit=10" you would append the following to your configuration:
+ <property>
+ <name>hbase.zookeeper.property.initLimit</name>
+ <value>10</value>
+ </property>
+ -->
+ <property>
+ <name>hbase.zookeeper.property.initLimit</name>
+ <value>10</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The number of ticks that the initial synchronization phase can take.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.syncLimit</name>
+ <value>5</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The number of ticks that can pass between sending a request and getting an
+ acknowledgment.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.dataDir</name>
+ <value>${hbase.tmp.dir}/zookeeper</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The directory where the snapshot is stored.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.clientPort</name>
+ <value>2181</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The port at which the clients will connect.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.maxClientCnxns</name>
+ <value>300</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ Limit on number of concurrent connections (at the socket level) that a
+ single client, identified by IP address, may make to a single member of
+ the ZooKeeper ensemble. Set high to avoid zk connection issues running
+ standalone and pseudo-distributed.</description>
+ </property>
+ <!-- End of properties that are directly mapped from ZooKeeper's zoo.cfg -->
+
+ <!--Client configurations-->
+ <property>
+ <name>hbase.client.write.buffer</name>
+ <value>2097152</value>
+ <description>Default size of the HTable client write buffer in bytes.
+ A bigger buffer takes more memory -- on both the client and server
+ side since server instantiates the passed write buffer to process
+ it -- but a larger buffer size reduces the number of RPCs made.
+ For an estimate of server-side memory-used, evaluate
+ hbase.client.write.buffer * hbase.regionserver.handler.count</description>
+ </property>
+ <property>
+ <name>hbase.client.pause</name>
+ <value>100</value>
+ <description>General client pause value. Used mostly as value to wait
+ before running a retry of a failed get, region lookup, etc.
+ See hbase.client.retries.number for description of how we backoff from
+ this initial pause amount and how this pause works w/ retries.</description>
+ </property>
+ <property>
+ <name>hbase.client.pause.cqtbe</name>
+ <value></value>
+ <description>Whether or not to use a special client pause for
+ CallQueueTooBigException (cqtbe). Set this property to a higher value
+ than hbase.client.pause if you observe frequent CQTBE from the same
+ RegionServer and the call queue there keeps full</description>
+ </property>
+ <property>
+ <name>hbase.client.retries.number</name>
+ <value>35</value>
+ <description>Maximum retries. Used as maximum for all retryable
+ operations such as the getting of a cell's value, starting a row update,
+ etc. Retry interval is a rough function based on hbase.client.pause. At
+ first we retry at this interval but then with backoff, we pretty quickly reach
+ retrying every ten seconds. See HConstants#RETRY_BACKOFF for how the backup
+ ramps up. Change this setting and hbase.client.pause to suit your workload.</description>
+ </property>
+ <property>
+ <name>hbase.client.max.total.tasks</name>
+ <value>100</value>
+ <description>The maximum number of concurrent mutation tasks a single HTable instance will
+ send to the cluster.</description>
+ </property>
+ <property>
+ <name>hbase.client.max.perserver.tasks</name>
+ <value>5</value>
+ <description>The maximum number of concurrent mutation tasks a single HTable instance will
+ send to a single region server.</description>
+ </property>
+ <property>
+ <name>hbase.client.max.perregion.tasks</name>
+ <value>1</value>
+ <description>The maximum number of concurrent mutation tasks the client will
+ maintain to a single Region. That is, if there is already
+ hbase.client.max.perregion.tasks writes in progress for this region, new puts
+ won't be sent to this region until some writes finishes.</description>
+ </property>
+ <property>
+ <name>hbase.client.perserver.requests.threshold</name>
+ <value>2147483647</value>
+ <description>The max number of concurrent pending requests for one server in all client threads
+ (process level). Exceeding requests will be thrown ServerTooBusyException immediately to prevent
+ user's threads being occupied and blocked by only one slow region server. If you use a fix
+ number of threads to access HBase in a synchronous way, set this to a suitable value which is
+ related to the number of threads will help you. See
+ https://issues.apache.org/jira/browse/HBASE-16388 for details.</description>
+ </property>
+ <property>
+ <name>hbase.client.scanner.caching</name>
+ <value>2147483647</value>
+ <description>Number of rows that we try to fetch when calling next
+ on a scanner if it is not served from (local, client) memory. This configuration
+ works together with hbase.client.scanner.max.result.size to try and use the
+ network efficiently. The default value is Integer.MAX_VALUE by default so that
+ the network will fill the chunk size defined by hbase.client.scanner.max.result.size
+ rather than be limited by a particular number of rows since the size of rows varies
+ table to table. If you know ahead of time that you will not require more than a certain
+ number of rows from a scan, this configuration should be set to that row limit via
+ Scan#setCaching. Higher caching values will enable faster scanners but will eat up more
+ memory and some calls of next may take longer and longer times when the cache is empty.
+ Do not set this value such that the time between invocations is greater than the scanner
+ timeout; i.e. hbase.client.scanner.timeout.period</description>
+ </property>
+ <property>
+ <name>hbase.client.keyvalue.maxsize</name>
+ <value>10485760</value>
+ <description>Specifies the combined maximum allowed size of a KeyValue
+ instance. This is to set an upper boundary for a single entry saved in a
+ storage file. Since they cannot be split it helps avoiding that a region
+ cannot be split any further because the data is too large. It seems wise
+ to set this to a fraction of the maximum region size. Setting it to zero
+ or less disables the check.</description>
+ </property>
+ <property>
+ <name>hbase.server.keyvalue.maxsize</name>
+ <value>10485760</value>
+ <description>Maximum allowed size of an individual cell, inclusive of value and all key
+ components. A value of 0 or less disables the check.
+ The default value is 10MB.
+ This is a safety setting to protect the server from OOM situations.
+ </description>
+ </property>
+ <property>
+ <name>hbase.client.scanner.timeout.period</name>
+ <value>60000</value>
+ <description>Client scanner lease period in milliseconds.</description>
+ </property>
+ <property>
+ <name>hbase.client.localityCheck.threadPoolSize</name>
+ <value>2</value>
+ </property>
+
+ <!--Miscellaneous configuration-->
+ <property>
+ <name>hbase.bulkload.retries.number</name>
+ <value>10</value>
+ <description>Maximum retries. This is maximum number of iterations
+ to atomic bulk loads are attempted in the face of splitting operations
+ 0 means never give up.</description>
+ </property>
+ <property>
+ <name>hbase.master.balancer.maxRitPercent</name>
+ <value>1.0</value>
+ <description>The max percent of regions in transition when balancing.
+ The default value is 1.0. So there are no balancer throttling. If set this config to 0.01,
+ It means that there are at most 1% regions in transition when balancing.
+ Then the cluster's availability is at least 99% when balancing.</description>
+ </property>
+ <property>
+ <name>hbase.balancer.period
+ </name>
+ <value>300000</value>
+ <description>Period at which the region balancer runs in the Master.</description>
+ </property>
+ <property>
+ <name>hbase.normalizer.period</name>
+ <value>1800000</value>
+ <description>Period at which the region normalizer runs in the Master.</description>
+ </property>
+ <property>
+ <name>hbase.regions.slop</name>
+ <value>0.001</value>
+ <description>Rebalance if any regionserver has average + (average * slop) regions.
+ The default value of this parameter is 0.001 in StochasticLoadBalancer (the default load balancer),
+ while the default is 0.2 in other load balancers (i.e., SimpleLoadBalancer).</description>
+ </property>
+ <property>
+ <name>hbase.server.thread.wakefrequency</name>
+ <value>10000</value>
+ <description>Time to sleep in between searches for work (in milliseconds).
+ Used as sleep interval by service threads such as log roller.</description>
+ </property>
+ <property>
+ <name>hbase.server.versionfile.writeattempts</name>
+ <value>3</value>
+ <description>
+ How many time to retry attempting to write a version file
+ before just aborting. Each attempt is seperated by the
+ hbase.server.thread.wakefrequency milliseconds.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.memstore.flush.size</name>
+ <value>134217728</value>
+ <description>
+ Memstore will be flushed to disk if size of the memstore
+ exceeds this number of bytes. Value is checked by a thread that runs
+ every hbase.server.thread.wakefrequency.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.percolumnfamilyflush.size.lower.bound</name>
+ <value>16777216</value>
+ <description>
+ If FlushLargeStoresPolicy is used, then every time that we hit the
+ total memstore limit, we find out all the column families whose memstores
+ exceed this value, and only flush them, while retaining the others whose
+ memstores are lower than this limit. If none of the families have their
+ memstore size more than this, all the memstores will be flushed
+ (just as usual). This value should be less than half of the total memstore
+ threshold (hbase.hregion.memstore.flush.size).
+ </description>
+ </property>
+ <property>
+ <name>hbase.hregion.preclose.flush.size</name>
+ <value>5242880</value>
+ <description>
+ If the memstores in a region are this size or larger when we go
+ to close, run a "pre-flush" to clear out memstores before we put up
+ the region closed flag and take the region offline. On close,
+ a flush is run under the close flag to empty memory. During
+ this time the region is offline and we are not taking on any writes.
+ If the memstore content is large, this flush could take a long time to
+ complete. The preflush is meant to clean out the bulk of the memstore
+ before putting up the close flag and taking the region offline so the
+ flush that runs under the close flag has little to do.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.memstore.block.multiplier</name>
+ <value>4</value>
+ <description>
+ Block updates if memstore has hbase.hregion.memstore.block.multiplier
+ times hbase.hregion.memstore.flush.size bytes. Useful preventing
+ runaway memstore during spikes in update traffic. Without an
+ upper-bound, memstore fills such that when it flushes the
+ resultant flush files take a long time to compact or split, or
+ worse, we OOME.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.memstore.mslab.enabled</name>
+ <value>true</value>
+ <description>
+ Enables the MemStore-Local Allocation Buffer,
+ a feature which works to prevent heap fragmentation under
+ heavy write loads. This can reduce the frequency of stop-the-world
+ GC pauses on large heaps.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.max.filesize</name>
+ <value>10737418240</value>
+ <description>
+ Maximum HStoreFile size. If any one of a column families' HStoreFiles has
+ grown to exceed this value, the hosting HRegion is split in two.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.majorcompaction</name>
+ <value>604800000</value>
+ <description>The time (in miliseconds) between 'major' compactions of all
+ HStoreFiles in a region. Default: Set to 7 days. Major compactions tend to
+ happen exactly when you need them least so enable them such that they run at
+ off-peak for your deploy; or, since this setting is on a periodicity that is
+ unlikely to match your loading, run the compactions via an external
+ invocation out of a cron job or some such.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.majorcompaction.jitter</name>
+ <value>0.50</value>
+ <description>Jitter outer bound for major compactions.
+ On each regionserver, we multiply the hbase.region.majorcompaction
+ interval by some random fraction that is inside the bounds of this
+ maximum. We then add this + or - product to when the next
+ major compaction is to run. The idea is that major compaction
+ does happen on every regionserver at exactly the same time. The
+ smaller this number, the closer the compactions come together.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.compactionThreshold</name>
+ <value>3</value>
+ <description>
+ If more than this number of HStoreFiles in any one HStore
+ (one HStoreFile is written per flush of memstore) then a compaction
+ is run to rewrite all HStoreFiles files as one. Larger numbers
+ put off compaction but when it runs, it takes longer to complete.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.flusher.count</name>
+ <value>2</value>
+ <description>
+ The number of flush threads. With less threads, the memstore flushes will be queued. With
+ more threads, the flush will be executed in parallel, increasing the hdfs load. This can
+ lead as well to more compactions.
+ </description>
+ </property>
+ <property>
+ <name>hbase.hstore.blockingStoreFiles</name>
+ <value>10</value>
+ <description>
+ If more than this number of StoreFiles in any one Store
+ (one StoreFile is written per flush of MemStore) then updates are
+ blocked for this HRegion until a compaction is completed, or
+ until hbase.hstore.blockingWaitTime has been exceeded.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.blockingWaitTime</name>
+ <value>90000</value>
+ <description>
+ The time an HRegion will block updates for after hitting the StoreFile
+ limit defined by hbase.hstore.blockingStoreFiles.
+ After this time has elapsed, the HRegion will stop blocking updates even
+ if a compaction has not been completed.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.compaction.max</name>
+ <value>10</value>
+ <description>Max number of HStoreFiles to compact per 'minor' compaction.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.compaction.kv.max</name>
+ <value>10</value>
+ <description>How many KeyValues to read and then write in a batch when flushing
+ or compacting. Do less if big KeyValues and problems with OOME.
+ Do more if wide, small rows.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.time.to.purge.deletes</name>
+ <value>0</value>
+ <description>The amount of time to delay purging of delete markers with future timestamps. If
+ unset, or set to 0, all delete markers, including those with future timestamps, are purged
+ during the next major compaction. Otherwise, a delete marker is kept until the major compaction
+ which occurs after the marker's timestamp plus the value of this setting, in milliseconds.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.majorcompaction.pagecache.drop</name>
+ <value>true</value>
+ <description>Specifies whether to drop pages read/written into the system page cache by
+ major compactions. Setting it to true helps prevent major compactions from
+ polluting the page cache, which is almost always required, especially for clusters
+ with low/moderate memory to storage ratio.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.minorcompaction.pagecache.drop</name>
+ <value>true</value>
+ <description>Specifies whether to drop pages read/written into the system page cache by
+ minor compactions. Setting it to true helps prevent minor compactions from
+ polluting the page cache, which is most beneficial on clusters with low
+ memory to storage ratio or very write heavy clusters. You may want to set it to
+ false under moderate to low write workload when bulk of the reads are
+ on the most recently written data.</description>
+ </property>
+ <property>
+ <name>hbase.storescanner.parallel.seek.enable</name>
+ <value>false</value>
+ <description>
+ Enables StoreFileScanner parallel-seeking in StoreScanner,
+ a feature which can reduce response latency under special conditions.</description>
+ </property>
+ <property>
+ <name>hbase.storescanner.parallel.seek.threads</name>
+ <value>10</value>
+ <description>
+ The default thread pool size if parallel-seeking feature enabled.</description>
+ </property>
+ <property>
+ <name>hfile.block.cache.size</name>
+ <value>0.4</value>
+ <description>Percentage of maximum heap (-Xmx setting) to allocate to block cache
+ used by HFile/StoreFile. Default of 0.4 means allocate 40%.
+ Set to 0 to disable but it's not recommended; you need at least
+ enough cache to hold the storefile indices.</description>
+ </property>
+ <property>
+ <name>hfile.block.index.cacheonwrite</name>
+ <value>false</value>
+ <description>This allows to put non-root multi-level index blocks into the block
+ cache at the time the index is being written.</description>
+ </property>
+ <property>
+ <name>hfile.index.block.max.size</name>
+ <value>131072</value>
+ <description>When the size of a leaf-level, intermediate-level, or root-level
+ index block in a multi-level block index grows to this size, the
+ block is written out and a new block is started.</description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.ioengine</name>
+ <value></value>
+ <description>Where to store the contents of the bucketcache. One of: heap,
+ offheap, or file. If a file, set it to file:PATH_TO_FILE. See
+ http://hbase.apache.org/book.html#offheap.blockcache for more information.
+ </description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.combinedcache.enabled</name>
+ <value>true</value>
+ <description>Whether or not the bucketcache is used in league with the LRU
+ on-heap block cache. In this mode, indices and blooms are kept in the LRU
+ blockcache and the data blocks are kept in the bucketcache.</description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.size</name>
+ <value></value>
+ <description>A float that EITHER represents a percentage of total heap memory
+ size to give to the cache (if < 1.0) OR, it is the total capacity in
+ megabytes of BucketCache. Default: 0.0</description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.bucket.sizes</name>
+ <value></value>
+ <description>A comma-separated list of sizes for buckets for the bucketcache.
+ Can be multiple sizes. List block sizes in order from smallest to largest.
+ The sizes you use will depend on your data access patterns.
+ Must be a multiple of 256 else you will run into
+ 'java.io.IOException: Invalid HFile block magic' when you go to read from cache.
+ If you specify no values here, then you pick up the default bucketsizes set
+ in code (See BucketAllocator#DEFAULT_BUCKET_SIZES).
+ </description>
+ </property>
+ <property>
+ <name>hfile.format.version</name>
+ <value>3</value>
+ <description>The HFile format version to use for new files.
+ Version 3 adds support for tags in hfiles (See http://hbase.apache.org/book.html#hbase.tags).
+ Distributed Log Replay requires that tags are enabled. Also see the configuration
+ 'hbase.replication.rpc.codec'.
+ </description>
+ </property>
+ <property>
+ <name>hfile.block.bloom.cacheonwrite</name>
+ <value>false</value>
+ <description>Enables cache-on-write for inline blocks of a compound Bloom filter.</description>
+ </property>
+ <property>
+ <name>io.storefile.bloom.block.size</name>
+ <value>131072</value>
+ <description>The size in bytes of a single block ("chunk") of a compound Bloom
+ filter. This size is approximate, because Bloom blocks can only be
+ inserted at data block boundaries, and the number of keys per data
+ block varies.</description>
+ </property>
+ <property>
+ <name>hbase.rs.cacheblocksonwrite</name>
+ <value>false</value>
+ <description>Whether an HFile block should be added to the block cache when the
+ block is finished.</description>
+ </property>
+ <property>
+ <name>hbase.rpc.timeout</name>
+ <value>60000</value>
+ <description>This is for the RPC layer to define how long (millisecond) HBase client applications
+ take for a remote call to time out. It uses pings to check connections
+ but will eventually throw a TimeoutException.</description>
+ </property>
+ <property>
+ <name>hbase.client.operation.timeout</name>
+ <value>1200000</value>
+ <description>Operation timeout is a top-level restriction (millisecond) that makes sure a
+ blocking operation in Table will not be blocked more than this. In each operation, if rpc
+ request fails because of timeout or other reason, it will retry until success or throw
+ RetriesExhaustedException. But if the total time being blocking reach the operation timeout
+ before retries exhausted, it will break early and throw SocketTimeoutException.</description>
+ </property>
+ <property>
+ <name>hbase.cells.scanned.per.heartbeat.check</name>
+ <value>10000</value>
+ <description>The number of cells scanned in between heartbeat checks. Heartbeat
+ checks occur during the processing of scans to determine whether or not the
+ server should stop scanning in order to send back a heartbeat message to the
+ client. Heartbeat messages are used to keep the client-server connection alive
+ during long running scans. Small values mean that the heartbeat checks will
+ occur more often and thus will provide a tighter bound on the execution time of
+ the scan. Larger values mean that the heartbeat checks occur less frequently
+ </description>
+ </property>
+ <property>
+ <name>hbase.rpc.shortoperation.timeout</name>
+ <value>10000</value>
+ <description>This is another version of "hbase.rpc.timeout". For those RPC operation
+ within cluster, we rely on this configuration to set a short timeout limitation
+ for short operation. For example, short rpc timeout for region server's trying
+ to report to active master can benefit quicker master failover process.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.client.tcpnodelay</name>
+ <value>true</value>
+ <description>Set no delay on rpc socket connections. See
+ http://docs.oracle.com/javase/1.5.0/docs/api/java/net/Socket.html#getTcpNoDelay()</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.hostname</name>
+ <value></value>
+ <description>This config is for experts: don't set its value unless you really know what you are doing.
+ When set to a non-empty value, this represents the (external facing) hostname for the underlying server.
+ See https://issues.apache.org/jira/browse/HBASE-12954 for details.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.hostname.disable.master.reversedns</name>
+ <value>false</value>
+ <description>This config is for experts: don't set its value unless you really know what you are doing.
+ When set to true, regionserver will use the current node hostname for the servername and HMaster will
+ skip reverse DNS lookup and use the hostname sent by regionserver instead. Note that this config and
+ hbase.regionserver.hostname are mutually exclusive. See https://issues.apache.org/jira/browse/HBASE-18226
+ for more details.</description>
+ </property>
+ <!-- The following properties configure authentication information for
+ HBase processes when using Kerberos security. There are no default
+ values, included here for documentation purposes -->
+ <property>
+ <name>hbase.master.keytab.file</name>
+ <value></value>
+ <description>Full path to the kerberos keytab file to use for logging in
+ the configured HMaster server principal.</description>
+ </property>
+ <property>
+ <name>hbase.master.kerberos.principal</name>
+ <value></value>
+ <description>Ex. "hbase/_HOST@EXAMPLE.COM". The kerberos principal name
+ that should be used to run the HMaster process. The principal name should
+ be in the form: user/hostname@DOMAIN. If "_HOST" is used as the hostname
+ portion, it will be replaced with the actual hostname of the running
+ instance.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.keytab.file</name>
+ <value></value>
+ <description>Full path to the kerberos keytab file to use for logging in
+ the configured HRegionServer server principal.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.kerberos.principal</name>
+ <value></value>
+ <description>Ex. "hbase/_HOST@EXAMPLE.COM". The kerberos principal name
+ that should be used to run the HRegionServer process. The principal name
+ should be in the form: user/hostname@DOMAIN. If "_HOST" is used as the
+ hostname portion, it will be replaced with the actual hostname of the
+ running instance. An entry for this principal must exist in the file
+ specified in hbase.regionserver.keytab.file</description>
+ </property>
+ <!-- Additional configuration specific to HBase security -->
+ <property>
+ <name>hadoop.policy.file</name>
+ <value>hbase-policy.xml</value>
+ <description>The policy configuration file used by RPC servers to make
+ authorization decisions on client requests. Only used when HBase
+ security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.superuser</name>
+ <value></value>
+ <description>List of users or groups (comma-separated), who are allowed
+ full privileges, regardless of stored ACLs, across the cluster.
+ Only used when HBase security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.auth.key.update.interval</name>
+ <value>86400000</value>
+ <description>The update interval for master key for authentication tokens
+ in servers in milliseconds. Only used when HBase security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.auth.token.max.lifetime</name>
+ <value>604800000</value>
+ <description>The maximum lifetime in milliseconds after which an
+ authentication token expires. Only used when HBase security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.client.fallback-to-simple-auth-allowed</name>
+ <value>false</value>
+ <description>When a client is configured to attempt a secure connection, but attempts to
+ connect to an insecure server, that server may instruct the client to
+ switch to SASL SIMPLE (unsecure) authentication. This setting controls
+ whether or not the client will accept this instruction from the server.
+ When false (the default), the client will not allow the fallback to SIMPLE
+ authentication, and will abort the connection.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.fallback-to-simple-auth-allowed</name>
+ <value>false</value>
+ <description>When a server is configured to require secure connections, it will
+ reject connection attempts from clients using SASL SIMPLE (unsecure) authentication.
+ This setting allows secure servers to accept SASL SIMPLE connections from clients
+ when the client requests. When false (the default), the server will not allow the fallback
+ to SIMPLE authentication, and will reject the connection. WARNING: This setting should ONLY
+ be used as a temporary measure while converting clients over to secure authentication. It
+ MUST BE DISABLED for secure operation.</description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.enabled</name>
+ <value>true</value>
+ <description>Enables or disables coprocessor loading. If 'false'
+ (disabled), any other coprocessor related configuration will be ignored.
+ </description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.user.enabled</name>
+ <value>true</value>
+ <description>Enables or disables user (aka. table) coprocessor loading.
+ If 'false' (disabled), any table coprocessor attributes in table
+ descriptors will be ignored. If "hbase.coprocessor.enabled" is 'false'
+ this setting has no effect.
+ </description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.region.classes</name>
+ <value></value>
+ <description>A comma-separated list of Coprocessors that are loaded by
+ default on all tables. For any override coprocessor method, these classes
+ will be called in order. After implementing your own Coprocessor, just put
+ it in HBase's classpath and add the fully qualified class name here.
+ A coprocessor can also be loaded on demand by setting HTableDescriptor.</description>
+ </property>
+ <property>
+ <name>hbase.rest.port</name>
+ <value>8080</value>
+ <description>The port for the HBase REST server.</description>
+ </property>
+ <property>
+ <name>hbase.rest.readonly</name>
+ <value>false</value>
+ <description>Defines the mode the REST server will be started in. Possible values are:
+ false: All HTTP methods are permitted - GET/PUT/POST/DELETE.
+ true: Only the GET method is permitted.</description>
+ </property>
+ <property>
+ <name>hbase.rest.threads.max</name>
+ <value>100</value>
+ <description>The maximum number of threads of the REST server thread pool.
+ Threads in the pool are reused to process REST requests. This
+ controls the maximum number of requests processed concurrently.
+ It may help to control the memory used by the REST server to
+ avoid OOM issues. If the thread pool is full, incoming requests
+ will be queued up and wait for some free threads.</description>
+ </property>
+ <property>
+ <name>hbase.rest.threads.min</name>
+ <value>2</value>
+ <description>The minimum number of threads of the REST server thread pool.
+ The thread pool always has at least these number of threads so
+ the REST server is ready to serve incoming requests.</description>
+ </property>
+ <property>
+ <name>hbase.rest.support.proxyuser</name>
+ <value>false</value>
+ <description>Enables running the REST server to support proxy-user mode.</description>
+ </property>
+ <property>
+ <name>hbase.defaults.for.version.skip</name>
+ <value>true</value>
+ <description>Set to true to skip the 'hbase.defaults.for.version' check.
+ Setting this to true can be useful in contexts other than
+ the other side of a maven generation; i.e. running in an
+ ide. You'll want to set this boolean to true to avoid
+ seeing the RuntimException complaint: "hbase-default.xml file
+ seems to be for and old version of HBase (\${hbase.version}), this
+ version is X.X.X-SNAPSHOT"</description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.abortonerror</name>
+ <value>true</value>
+ <description>Set to true to cause the hosting server (master or regionserver)
+ to abort if a coprocessor fails to load, fails to initialize, or throws an
+ unexpected Throwable object. Setting this to false will allow the server to
+ continue execution but the system wide state of the coprocessor in question
+ will become inconsistent as it will be properly executing in only a subset
+ of servers, so this is most useful for debugging only.</description>
+ </property>
+ <property>
+ <name>hbase.online.schema.update.enable</name>
+ <value>true</value>
+ <description>Set true to enable online schema changes.</description>
+ </property>
+ <property>
+ <name>hbase.table.lock.enable</name>
+ <value>true</value>
+ <description>Set to true to enable locking the table in zookeeper for schema change operations.
+ Table locking from master prevents concurrent schema modifications to corrupt table
+ state.</description>
+ </property>
+ <property>
+ <name>hbase.table.max.rowsize</name>
+ <value>1073741824</value>
+ <description>
+ Maximum size of single row in bytes (default is 1 Gb) for Get'ting
+ or Scan'ning without in-row scan flag set. If row size exceeds this limit
+ RowTooBigException is thrown to client.
+ </description>
+ </property>
+ <property>
+ <name>hbase.thrift.minWorkerThreads</name>
+ <value>16</value>
+ <description>The "core size" of the thread pool. New threads are created on every
+ connection until this many threads are created.</description>
+ </property>
+ <property>
+ <name>hbase.thrift.maxWorkerThreads</name>
+ <value>1000</value>
+ <description>The maximum size of the thread pool. When the pending request queue
+ overflows, new threads are created until their number reaches this number.
+ After that, the server starts dropping connections.</description>
+ </property>
+ <property>
+ <name>hbase.thrift.maxQueuedRequests</name>
+ <value>1000</value>
+ <description>The maximum number of pending Thrift connections waiting in the queue. If
+ there are no idle threads in the pool, the server queues requests. Only
+ when the queue overflows, new threads are added, up to
+ hbase.thrift.maxQueuedRequests threads.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.thrift.framed</name>
+ <value>false</value>
+ <description>Use Thrift TFramedTransport on the server side.
+ This is the recommended transport for thrift servers and requires a similar setting
+ on the client side. Changing this to false will select the default transport,
+ vulnerable to DoS when malformed requests are issued due to THRIFT-601.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.thrift.framed.max_frame_size_in_mb</name>
+ <value>2</value>
+ <description>Default frame size when using framed transport</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.thrift.compact</name>
+ <value>false</value>
+ <description>Use Thrift TCompactProtocol binary serialization protocol.</description>
+ </property>
+ <property>
+ <name>hbase.rootdir.perms</name>
+ <value>700</value>
+ <description>FS Permissions for the root directory in a secure(kerberos) setup.
+ When master starts, it creates the rootdir with this permissions or sets the permissions
+ if it does not match.</description>
+ </property>
+ <property>
+ <name>hbase.wal.dir.perms</name>
+ <value>700</value>
+ <description>FS Permissions for the root WAL directory in a secure(kerberos) setup.
+ When master starts, it creates the WAL dir with this permissions or sets the permissions
+ if it does not match.</description>
+ </property>
+ <property>
+ <name>hbase.data.umask.enable</name>
+ <value>false</value>
+ <description>Enable, if true, that file permissions should be assigned
+ to the files written by the regionserver</description>
+ </property>
+ <property>
+ <name>hbase.data.umask</name>
+ <value>000</value>
+ <description>File permissions that should be used to write data
+ files when hbase.data.umask.enable is true</description>
+ </property>
+ <property>
+ <name>hbase.snapshot.enabled</name>
+ <value>true</value>
+ <description>Set to true to allow snapshots to be taken / restored / cloned.</description>
+ </property>
+ <property>
+ <name>hbase.snapshot.restore.take.failsafe.snapshot</name>
+ <value>true</value>
+ <description>Set to true to take a snapshot before the restore operation.
+ The snapshot taken will be used in case of failure, to restore the previous state.
+ At the end of the restore operation this snapshot will be deleted</description>
+ </property>
+ <property>
+ <name>hbase.snapshot.restore.failsafe.name</name>
+ <value>hbase-failsafe-{snapshot.name}-{restore.timestamp}</value>
+ <description>Name of the failsafe snapshot taken by the restore operation.
+ You can use the {snapshot.name}, {table.name} and {restore.timestamp} variables
+ to create a name based on what you are restoring.</description>
+ </property>
+ <property>
+ <name>hbase.server.compactchecker.interval.multiplier</name>
+ <value>1000</value>
+ <description>The number that determines how often we scan to see if compaction is necessary.
+ Normally, compactions are done after some events (such as memstore flush), but if
+ region didn't receive a lot of writes for some time, or due to different compaction
+ policies, it may be necessary to check it periodically. The interval between checks is
+ hbase.server.compactchecker.interval.multiplier multiplied by
+ hbase.server.thread.wakefrequency.</description>
+ </property>
+ <property>
+ <name>hbase.lease.recovery.timeout</name>
+ <value>900000</value>
+ <description>How long we wait on dfs lease recovery in total before giving up.</description>
+ </property>
+ <property>
+ <name>hbase.lease.recovery.dfs.timeout</name>
+ <value>64000</value>
+ <description>How long between dfs recover lease invocations. Should be larger than the sum of
+ the time it takes for the namenode to issue a block recovery command as part of
+ datanode; dfs.heartbeat.interval and the time it takes for the primary
+ datanode, performing block recovery to timeout on a dead datanode; usually
+ dfs.client.socket-timeout. See the end of HBASE-8389 for more.</description>
+ </property>
+ <property>
+ <name>hbase.column.max.version</name>
+ <value>1</value>
+ <description>New column family descriptors will use this value as the default number of versions
+ to keep.</description>
+ </property>
+ <property>
+ <name>hbase.dfs.client.read.shortcircuit.buffer.size</name>
+ <value>131072</value>
+ <description>If the DFSClient configuration
+ dfs.client.read.shortcircuit.buffer.size is unset, we will
+ use what is configured here as the short circuit read default
+ direct byte buffer size. DFSClient native default is 1MB; HBase
+ keeps its HDFS files open so number of file blocks * 1MB soon
+ starts to add up and threaten OOME because of a shortage of
+ direct memory. So, we set it down from the default. Make
+ it > the default hbase block size set in the HColumnDescriptor
+ which is usually 64k.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.checksum.verify</name>
+ <value>true</value>
+ <description>
+ If set to true (the default), HBase verifies the checksums for hfile
+ blocks. HBase writes checksums inline with the data when it writes out
+ hfiles. HDFS (as of this writing) writes checksums to a separate file
+ than the data file necessitating extra seeks. Setting this flag saves
+ some on i/o. Checksum verification by HDFS will be internally disabled
+ on hfile streams when this flag is set. If the hbase-checksum verification
+ fails, we will switch back to using HDFS checksums (so do not disable HDFS
+ checksums! And besides this feature applies to hfiles only, not to WALs).
+ If this parameter is set to false, then hbase will not verify any checksums,
+ instead it will depend on checksum verification being done in the HDFS client.
+ </description>
+ </property>
+ <property>
+ <name>hbase.hstore.bytes.per.checksum</name>
+ <value>16384</value>
+ <description>
+ Number of bytes in a newly created checksum chunk for HBase-level
+ checksums in hfile blocks.
+ </description>
+ </property>
+ <property>
+ <name>hbase.hstore.checksum.algorithm</name>
+ <value>CRC32C</value>
+ <description>
+ Name of an algorithm that is used to compute checksums. Possible values
+ are NULL, CRC32, CRC32C.
+ </description>
+ </property>
+
+ <property>
+ <name>hbase.client.scanner.max.result.size</name>
+ <value>2097152</value>
+ <description>Maximum number of bytes returned when calling a scanner's next method.
+ Note that when a single row is larger than this limit the row is still returned completely.
+ The default value is 2MB, which is good for 1ge networks.
+ With faster and/or high latency networks this value should be increased.
+ </description>
+ </property>
+
+ <property>
+ <name>hbase.server.scanner.max.result.size</name>
+ <value>104857600</value>
+ <description>Maximum number of bytes returned when calling a scanner's next method.
+ Note that when a single row is larger than this limit the row is still returned completely.
+ The default value is 100MB.
+ This is a safety setting to protect the server from OOM situations.
+ </description>
+ </property>
+
+ <property>
+ <name>hbase.status.published</name>
+ <value>false</value>
+ <description>
+ This setting activates the publication by the master of the status of the region server.
+ When a region server dies and its recovery starts, the master will push this information
+ to the client application, to let them cut the connection immediately instead of waiting
+ for a timeout.
+ </description>
+ </property>
Review comment:
Is this file comes from `hbase-common-1.4.3.jar` ? I can not align the line number, we should ensure this file is same with the counterpart in `hbase-common-1.4.3.jar`.
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,13 @@
+flink-sql-connector-hbase
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.hbase:hbase-server:1.4.3
+- org.apache.zookeeper:zookeeper:3.4.10
+- org.apache.htrace:htrace-core:3.1.0-incubating
Review comment:
Looks like here we missed many dependencies.
> All bundled dependencies must be listed in NOTICE, grouped by license type, using standard maven syntax (groupId:artifactId:version).
[1] https://cwiki.apache.org/confluence/display/FLINK/Licensing
##########
File path: flink-connectors/flink-sql-connector-hbase/pom.xml
##########
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <name>flink-sql-connector-hbase</name>
+
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.flink:flink-connector-hbase_${scala.binary.version}</include>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.zookeeper:zookeeper</include>
+ <include>org.apache.htrace:htrace-core</include>
+ <include>com.google.guava:guava</include>
+ <include>com.google.protobuf:protobuf-java</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>commons-logging:commons-logging</include>
+ <include>commons-lang:commons-lang</include>
+ <include>commons-configuration:commons-configuration</include>
+ <include>commons-codec:commons-codec</include>
+ <include>io.netty:netty-all</include>
+ </includes>
+ <excludes>
+ <exclude>org.apache.hbase:hbase-metrics*</exclude>
+ <exclude>org.apache.hbase:hbase-server*</exclude>
+ </excludes>
+ </artifactSet>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/services/com.fasterxml.**</exclude>
+ <exclude>META-INF/services/org.apache.hadoop.**</exclude>
+ <exclude>META-INF/services/javax.**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <!-- Force relocation of all HBase dependencies. -->
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.htrace</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.htrace</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.yammer.metrics</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-logging</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-logging</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-lang</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-lang</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-configuration</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-configuration</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-codec</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-codec</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty:netty-all</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.hbase</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.hbase</shadedPattern>
Review comment:
Add note to explain why we need to exclude `Codec`.
```
<!-- HBase client uses shaded KeyValueCodec to encode data and put the class name in
the header of request, the HBase region server can not load the shaded
KeyValueCodec class when decode the data, so we exclude them here. -->
```
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/pom.xml
##########
@@ -0,0 +1,101 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-end-to-end-tests</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-end-to-end-tests-hbase</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-end-to-end-tests-common</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils-junit</artifactId>
+ <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ </dependency>
+
+ <!--using hbase shade jar to execute end-to-end test-->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-sql-client-test</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy</id>
+ <phase>pre-integration-test</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-sql-client-test</artifactId>
+ <version>${project.version}</version>
+ <destFileName>SqlToolbox.jar</destFileName>
+ <type>jar</type>
+ <outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <destFileName>SqlConnectorHbase.jar</destFileName>
Review comment:
```suggestion
<destFileName>sql-hbase.jar</destFileName>
```
just keep the code style
##########
File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/hbase-default.xml
##########
@@ -0,0 +1,1442 @@
+<?xml version="1.0"?>
+<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<!--
+OVERVIEW
+The important configs. are listed near the top. You should change
+at least the setting for hbase.tmp.dir. Other settings will change
+dependent on whether you are running hbase in standalone mode or
+distributed. See the hbase reference guide for requirements and
+guidance making configuration.
+This file does not contain all possible configurations. The file would be
+much larger if it carried everything. The absent configurations will only be
+found through source code reading. The idea is that such configurations are
+exotic and only those who would go to the trouble of reading a particular
+section in the code would be knowledgeable or invested enough in ever wanting
+to alter such configurations, so we do not list them here. Listing all
+possible configurations would overwhelm and obscure the important.
+-->
+
+<configuration>
+ <!--Configs you will likely change are listed here at the top of the file.
+ -->
+ <property>
+ <name>hbase.tmp.dir</name>
+ <value>${java.io.tmpdir}/hbase-${user.name}</value>
+ <description>Temporary directory on the local filesystem.
+ Change this setting to point to a location more permanent
+ than '/tmp', the usual resolve for java.io.tmpdir, as the
+ '/tmp' directory is cleared on machine restart.</description>
+ </property>
+ <property>
+ <name>hbase.rootdir</name>
+ <value>${hbase.tmp.dir}/hbase</value>
+ <description>The directory shared by region servers and into
+ which HBase persists. The URL should be 'fully-qualified'
+ to include the filesystem scheme. For example, to specify the
+ HDFS directory '/hbase' where the HDFS instance's namenode is
+ running at namenode.example.org on port 9000, set this value to:
+ hdfs://namenode.example.org:9000/hbase. By default, we write
+ to whatever ${hbase.tmp.dir} is set too -- usually /tmp --
+ so change this configuration or else all data will be lost on
+ machine restart.</description>
+ </property>
+ <property >
+ <name>hbase.fs.tmp.dir</name>
+ <value>/user/${user.name}/hbase-staging</value>
+ <description>A staging directory in default file system (HDFS)
+ for keeping temporary data.
+ </description>
+ </property>
+ <property >
+ <name>hbase.bulkload.staging.dir</name>
+ <value>${hbase.fs.tmp.dir}</value>
+ <description>A staging directory in default file system (HDFS)
+ for bulk loading.
+ </description>
+ </property>
+ <property >
+ <name>hbase.cluster.distributed</name>
+ <value>false</value>
+ <description>The mode the cluster will be in. Possible values are
+ false for standalone mode and true for distributed mode. If
+ false, startup will run all HBase and ZooKeeper daemons together
+ in the one JVM.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.quorum</name>
+ <value>localhost</value>
+ <description>Comma separated list of servers in the ZooKeeper ensemble
+ (This config. should have been named hbase.zookeeper.ensemble).
+ For example, "host1.mydomain.com,host2.mydomain.com,host3.mydomain.com".
+ By default this is set to localhost for local and pseudo-distributed modes
+ of operation. For a fully-distributed setup, this should be set to a full
+ list of ZooKeeper ensemble servers. If HBASE_MANAGES_ZK is set in hbase-env.sh
+ this is the list of servers which hbase will start/stop ZooKeeper on as
+ part of cluster start/stop. Client-side, we will take this list of
+ ensemble members and put it together with the hbase.zookeeper.clientPort
+ config. and pass it into zookeeper constructor as the connectString
+ parameter.</description>
+ </property>
+ <!--The above are the important configurations for getting hbase up
+ and running -->
+
+ <property>
+ <name>zookeeper.recovery.retry.maxsleeptime</name>
+ <value>60000</value>
+ <description>Max sleep time before retry zookeeper operations in milliseconds,
+ a max time is needed here so that sleep time won't grow unboundedly
+ </description>
+ </property>
+ <property>
+ <name>hbase.local.dir</name>
+ <value>${hbase.tmp.dir}/local/</value>
+ <description>Directory on the local filesystem to be used
+ as a local storage.</description>
+ </property>
+
+ <!--Master configurations-->
+ <property >
+ <name>hbase.master.port</name>
+ <value>16000</value>
+ <description>The port the HBase Master should bind to.</description>
+ </property>
+ <property>
+ <name>hbase.master.info.port</name>
+ <value>16010</value>
+ <description>The port for the HBase Master web UI.
+ Set to -1 if you do not want a UI instance run.</description>
+ </property>
+ <property>
+ <name>hbase.master.info.bindAddress</name>
+ <value>0.0.0.0</value>
+ <description>The bind address for the HBase Master web UI
+ </description>
+ </property>
+ <property>
+ <name>hbase.master.logcleaner.ttl</name>
+ <value>600000</value>
+ <description>Maximum time a WAL can stay in the .oldlogdir directory,
+ after which it will be cleaned by a Master thread.</description>
+ </property>
+ <property>
+ <name>hbase.master.infoserver.redirect</name>
+ <value>true</value>
+ <description>Whether or not the Master listens to the Master web
+ UI port (hbase.master.info.port) and redirects requests to the web
+ UI server shared by the Master and RegionServer.</description>
+ </property>
+
+ <!--RegionServer configurations-->
+ <property>
+ <name>hbase.regionserver.port</name>
+ <value>16020</value>
+ <description>The port the HBase RegionServer binds to.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.info.port</name>
+ <value>16030</value>
+ <description>The port for the HBase RegionServer web UI
+ Set to -1 if you do not want the RegionServer UI to run.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.info.bindAddress</name>
+ <value>0.0.0.0</value>
+ <description>The address for the HBase RegionServer web UI</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.info.port.auto</name>
+ <value>false</value>
+ <description>Whether or not the Master or RegionServer
+ UI should search for a port to bind to. Enables automatic port
+ search if hbase.regionserver.info.port is already in use.
+ Useful for testing, turned off by default.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.handler.count</name>
+ <value>30</value>
+ <description>Count of RPC Listener instances spun up on RegionServers.
+ Same property is used by the Master for count of master handlers.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.callqueue.handler.factor</name>
+ <value>0.1</value>
+ <description>Factor to determine the number of call queues.
+ A value of 0 means a single queue shared between all the handlers.
+ A value of 1 means that each handler has its own queue.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.callqueue.read.ratio</name>
+ <value>0</value>
+ <description>Split the call queues into read and write queues.
+ The specified interval (which should be between 0.0 and 1.0)
+ will be multiplied by the number of call queues.
+ A value of 0 indicate to not split the call queues, meaning that both read and write
+ requests will be pushed to the same set of queues.
+ A value lower than 0.5 means that there will be less read queues than write queues.
+ A value of 0.5 means there will be the same number of read and write queues.
+ A value greater than 0.5 means that there will be more read queues than write queues.
+ A value of 1.0 means that all the queues except one are used to dispatch read requests.
+
+ Example: Given the total number of call queues being 10
+ a read.ratio of 0 means that: the 10 queues will contain both read/write requests.
+ a read.ratio of 0.3 means that: 3 queues will contain only read requests
+ and 7 queues will contain only write requests.
+ a read.ratio of 0.5 means that: 5 queues will contain only read requests
+ and 5 queues will contain only write requests.
+ a read.ratio of 0.8 means that: 8 queues will contain only read requests
+ and 2 queues will contain only write requests.
+ a read.ratio of 1 means that: 9 queues will contain only read requests
+ and 1 queues will contain only write requests.
+ </description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.callqueue.scan.ratio</name>
+ <value>0</value>
+ <description>Given the number of read call queues, calculated from the total number
+ of call queues multiplied by the callqueue.read.ratio, the scan.ratio property
+ will split the read call queues into small-read and long-read queues.
+ A value lower than 0.5 means that there will be less long-read queues than short-read queues.
+ A value of 0.5 means that there will be the same number of short-read and long-read queues.
+ A value greater than 0.5 means that there will be more long-read queues than short-read queues
+ A value of 0 or 1 indicate to use the same set of queues for gets and scans.
+
+ Example: Given the total number of read call queues being 8
+ a scan.ratio of 0 or 1 means that: 8 queues will contain both long and short read requests.
+ a scan.ratio of 0.3 means that: 2 queues will contain only long-read requests
+ and 6 queues will contain only short-read requests.
+ a scan.ratio of 0.5 means that: 4 queues will contain only long-read requests
+ and 4 queues will contain only short-read requests.
+ a scan.ratio of 0.8 means that: 6 queues will contain only long-read requests
+ and 2 queues will contain only short-read requests.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.msginterval</name>
+ <value>3000</value>
+ <description>Interval between messages from the RegionServer to Master
+ in milliseconds.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.logroll.period</name>
+ <value>3600000</value>
+ <description>Period at which we will roll the commit log regardless
+ of how many edits it has.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.logroll.errors.tolerated</name>
+ <value>2</value>
+ <description>The number of consecutive WAL close errors we will allow
+ before triggering a server abort. A setting of 0 will cause the
+ region server to abort if closing the current WAL writer fails during
+ log rolling. Even a small value (2 or 3) will allow a region server
+ to ride over transient HDFS errors.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.global.memstore.size</name>
+ <value></value>
+ <description>Maximum size of all memstores in a region server before new
+ updates are blocked and flushes are forced. Defaults to 40% of heap (0.4).
+ Updates are blocked and flushes are forced until size of all memstores
+ in a region server hits hbase.regionserver.global.memstore.size.lower.limit.
+ The default value in this configuration has been intentionally left emtpy in order to
+ honor the old hbase.regionserver.global.memstore.upperLimit property if present.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.global.memstore.size.lower.limit</name>
+ <value></value>
+ <description>Maximum size of all memstores in a region server before flushes are forced.
+ Defaults to 95% of hbase.regionserver.global.memstore.size (0.95).
+ A 100% value for this value causes the minimum possible flushing to occur when updates are
+ blocked due to memstore limiting.
+ The default value in this configuration has been intentionally left emtpy in order to
+ honor the old hbase.regionserver.global.memstore.lowerLimit property if present.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.optionalcacheflushinterval</name>
+ <value>3600000</value>
+ <description>
+ Maximum amount of time an edit lives in memory before being automatically flushed.
+ Default 1 hour. Set it to 0 to disable automatic flushing.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.dns.interface</name>
+ <value>default</value>
+ <description>The name of the Network Interface from which a region server
+ should report its IP address.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.dns.nameserver</name>
+ <value>default</value>
+ <description>The host name or IP address of the name server (DNS)
+ which a region server should use to determine the host name used by the
+ master for communication and display purposes.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.regionSplitLimit</name>
+ <value>1000</value>
+ <description>
+ Limit for the number of regions after which no more region splitting should take place.
+ This is not hard limit for the number of regions but acts as a guideline for the regionserver
+ to stop splitting after a certain limit. Default is set to 1000.
+ </description>
+ </property>
+
+ <!--ZooKeeper configuration-->
+ <property>
+ <name>zookeeper.session.timeout</name>
+ <value>90000</value>
+ <description>ZooKeeper session timeout in milliseconds. It is used in two different ways.
+ First, this value is used in the ZK client that HBase uses to connect to the ensemble.
+ It is also used by HBase when it starts a ZK server and it is passed as the 'maxSessionTimeout'. See
+ http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#ch_zkSessions.
+ For example, if a HBase region server connects to a ZK ensemble that's also managed by HBase, then the
+ session timeout will be the one specified by this configuration. But, a region server that connects
+ to an ensemble managed with a different configuration will be subjected that ensemble's maxSessionTimeout. So,
+ even though HBase might propose using 90 seconds, the ensemble can have a max timeout lower than this and
+ it will take precedence. The current default that ZK ships with is 40 seconds, which is lower than HBase's.
+ </description>
+ </property>
+ <property>
+ <name>zookeeper.znode.parent</name>
+ <value>/hbase</value>
+ <description>Root ZNode for HBase in ZooKeeper. All of HBase's ZooKeeper
+ files that are configured with a relative path will go under this node.
+ By default, all of HBase's ZooKeeper file path are configured with a
+ relative path, so they will all go under this directory unless changed.</description>
+ </property>
+ <property>
+ <name>zookeeper.znode.acl.parent</name>
+ <value>acl</value>
+ <description>Root ZNode for access control lists.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.dns.interface</name>
+ <value>default</value>
+ <description>The name of the Network Interface from which a ZooKeeper server
+ should report its IP address.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.dns.nameserver</name>
+ <value>default</value>
+ <description>The host name or IP address of the name server (DNS)
+ which a ZooKeeper server should use to determine the host name used by the
+ master for communication and display purposes.</description>
+ </property>
+ <!--
+ The following three properties are used together to create the list of
+ host:peer_port:leader_port quorum servers for ZooKeeper.
+ -->
+ <property>
+ <name>hbase.zookeeper.peerport</name>
+ <value>2888</value>
+ <description>Port used by ZooKeeper peers to talk to each other.
+ See http://hadoop.apache.org/zookeeper/docs/r3.1.1/zookeeperStarted.html#sc_RunningReplicatedZooKeeper
+ for more information.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.leaderport</name>
+ <value>3888</value>
+ <description>Port used by ZooKeeper for leader election.
+ See http://hadoop.apache.org/zookeeper/docs/r3.1.1/zookeeperStarted.html#sc_RunningReplicatedZooKeeper
+ for more information.</description>
+ </property>
+ <!-- End of properties used to generate ZooKeeper host:port quorum list. -->
+ <property>
+ <name>hbase.zookeeper.useMulti</name>
+ <value>true</value>
+ <description>Instructs HBase to make use of ZooKeeper's multi-update functionality.
+ This allows certain ZooKeeper operations to complete more quickly and prevents some issues
+ with rare Replication failure scenarios (see the release note of HBASE-2611 for an example).
+ IMPORTANT: only set this to true if all ZooKeeper servers in the cluster are on version 3.4+
+ and will not be downgraded. ZooKeeper versions before 3.4 do not support multi-update and
+ will not fail gracefully if multi-update is invoked (see ZOOKEEPER-1495).</description>
+ </property>
+ <property>
+ <name>hbase.config.read.zookeeper.config</name>
+ <value>false</value>
+ <description>
+ Set to true to allow HBaseConfiguration to read the
+ zoo.cfg file for ZooKeeper properties. Switching this to true
+ is not recommended, since the functionality of reading ZK
+ properties from a zoo.cfg file has been deprecated.</description>
+ </property>
+ <!--
+ Beginning of properties that are directly mapped from ZooKeeper's zoo.cfg.
+ All properties with an "hbase.zookeeper.property." prefix are converted for
+ ZooKeeper's configuration. Hence, if you want to add an option from zoo.cfg,
+ e.g. "initLimit=10" you would append the following to your configuration:
+ <property>
+ <name>hbase.zookeeper.property.initLimit</name>
+ <value>10</value>
+ </property>
+ -->
+ <property>
+ <name>hbase.zookeeper.property.initLimit</name>
+ <value>10</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The number of ticks that the initial synchronization phase can take.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.syncLimit</name>
+ <value>5</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The number of ticks that can pass between sending a request and getting an
+ acknowledgment.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.dataDir</name>
+ <value>${hbase.tmp.dir}/zookeeper</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The directory where the snapshot is stored.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.clientPort</name>
+ <value>2181</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ The port at which the clients will connect.</description>
+ </property>
+ <property>
+ <name>hbase.zookeeper.property.maxClientCnxns</name>
+ <value>300</value>
+ <description>Property from ZooKeeper's config zoo.cfg.
+ Limit on number of concurrent connections (at the socket level) that a
+ single client, identified by IP address, may make to a single member of
+ the ZooKeeper ensemble. Set high to avoid zk connection issues running
+ standalone and pseudo-distributed.</description>
+ </property>
+ <!-- End of properties that are directly mapped from ZooKeeper's zoo.cfg -->
+
+ <!--Client configurations-->
+ <property>
+ <name>hbase.client.write.buffer</name>
+ <value>2097152</value>
+ <description>Default size of the HTable client write buffer in bytes.
+ A bigger buffer takes more memory -- on both the client and server
+ side since server instantiates the passed write buffer to process
+ it -- but a larger buffer size reduces the number of RPCs made.
+ For an estimate of server-side memory-used, evaluate
+ hbase.client.write.buffer * hbase.regionserver.handler.count</description>
+ </property>
+ <property>
+ <name>hbase.client.pause</name>
+ <value>100</value>
+ <description>General client pause value. Used mostly as value to wait
+ before running a retry of a failed get, region lookup, etc.
+ See hbase.client.retries.number for description of how we backoff from
+ this initial pause amount and how this pause works w/ retries.</description>
+ </property>
+ <property>
+ <name>hbase.client.pause.cqtbe</name>
+ <value></value>
+ <description>Whether or not to use a special client pause for
+ CallQueueTooBigException (cqtbe). Set this property to a higher value
+ than hbase.client.pause if you observe frequent CQTBE from the same
+ RegionServer and the call queue there keeps full</description>
+ </property>
+ <property>
+ <name>hbase.client.retries.number</name>
+ <value>35</value>
+ <description>Maximum retries. Used as maximum for all retryable
+ operations such as the getting of a cell's value, starting a row update,
+ etc. Retry interval is a rough function based on hbase.client.pause. At
+ first we retry at this interval but then with backoff, we pretty quickly reach
+ retrying every ten seconds. See HConstants#RETRY_BACKOFF for how the backup
+ ramps up. Change this setting and hbase.client.pause to suit your workload.</description>
+ </property>
+ <property>
+ <name>hbase.client.max.total.tasks</name>
+ <value>100</value>
+ <description>The maximum number of concurrent mutation tasks a single HTable instance will
+ send to the cluster.</description>
+ </property>
+ <property>
+ <name>hbase.client.max.perserver.tasks</name>
+ <value>5</value>
+ <description>The maximum number of concurrent mutation tasks a single HTable instance will
+ send to a single region server.</description>
+ </property>
+ <property>
+ <name>hbase.client.max.perregion.tasks</name>
+ <value>1</value>
+ <description>The maximum number of concurrent mutation tasks the client will
+ maintain to a single Region. That is, if there is already
+ hbase.client.max.perregion.tasks writes in progress for this region, new puts
+ won't be sent to this region until some writes finishes.</description>
+ </property>
+ <property>
+ <name>hbase.client.perserver.requests.threshold</name>
+ <value>2147483647</value>
+ <description>The max number of concurrent pending requests for one server in all client threads
+ (process level). Exceeding requests will be thrown ServerTooBusyException immediately to prevent
+ user's threads being occupied and blocked by only one slow region server. If you use a fix
+ number of threads to access HBase in a synchronous way, set this to a suitable value which is
+ related to the number of threads will help you. See
+ https://issues.apache.org/jira/browse/HBASE-16388 for details.</description>
+ </property>
+ <property>
+ <name>hbase.client.scanner.caching</name>
+ <value>2147483647</value>
+ <description>Number of rows that we try to fetch when calling next
+ on a scanner if it is not served from (local, client) memory. This configuration
+ works together with hbase.client.scanner.max.result.size to try and use the
+ network efficiently. The default value is Integer.MAX_VALUE by default so that
+ the network will fill the chunk size defined by hbase.client.scanner.max.result.size
+ rather than be limited by a particular number of rows since the size of rows varies
+ table to table. If you know ahead of time that you will not require more than a certain
+ number of rows from a scan, this configuration should be set to that row limit via
+ Scan#setCaching. Higher caching values will enable faster scanners but will eat up more
+ memory and some calls of next may take longer and longer times when the cache is empty.
+ Do not set this value such that the time between invocations is greater than the scanner
+ timeout; i.e. hbase.client.scanner.timeout.period</description>
+ </property>
+ <property>
+ <name>hbase.client.keyvalue.maxsize</name>
+ <value>10485760</value>
+ <description>Specifies the combined maximum allowed size of a KeyValue
+ instance. This is to set an upper boundary for a single entry saved in a
+ storage file. Since they cannot be split it helps avoiding that a region
+ cannot be split any further because the data is too large. It seems wise
+ to set this to a fraction of the maximum region size. Setting it to zero
+ or less disables the check.</description>
+ </property>
+ <property>
+ <name>hbase.server.keyvalue.maxsize</name>
+ <value>10485760</value>
+ <description>Maximum allowed size of an individual cell, inclusive of value and all key
+ components. A value of 0 or less disables the check.
+ The default value is 10MB.
+ This is a safety setting to protect the server from OOM situations.
+ </description>
+ </property>
+ <property>
+ <name>hbase.client.scanner.timeout.period</name>
+ <value>60000</value>
+ <description>Client scanner lease period in milliseconds.</description>
+ </property>
+ <property>
+ <name>hbase.client.localityCheck.threadPoolSize</name>
+ <value>2</value>
+ </property>
+
+ <!--Miscellaneous configuration-->
+ <property>
+ <name>hbase.bulkload.retries.number</name>
+ <value>10</value>
+ <description>Maximum retries. This is maximum number of iterations
+ to atomic bulk loads are attempted in the face of splitting operations
+ 0 means never give up.</description>
+ </property>
+ <property>
+ <name>hbase.master.balancer.maxRitPercent</name>
+ <value>1.0</value>
+ <description>The max percent of regions in transition when balancing.
+ The default value is 1.0. So there are no balancer throttling. If set this config to 0.01,
+ It means that there are at most 1% regions in transition when balancing.
+ Then the cluster's availability is at least 99% when balancing.</description>
+ </property>
+ <property>
+ <name>hbase.balancer.period
+ </name>
+ <value>300000</value>
+ <description>Period at which the region balancer runs in the Master.</description>
+ </property>
+ <property>
+ <name>hbase.normalizer.period</name>
+ <value>1800000</value>
+ <description>Period at which the region normalizer runs in the Master.</description>
+ </property>
+ <property>
+ <name>hbase.regions.slop</name>
+ <value>0.001</value>
+ <description>Rebalance if any regionserver has average + (average * slop) regions.
+ The default value of this parameter is 0.001 in StochasticLoadBalancer (the default load balancer),
+ while the default is 0.2 in other load balancers (i.e., SimpleLoadBalancer).</description>
+ </property>
+ <property>
+ <name>hbase.server.thread.wakefrequency</name>
+ <value>10000</value>
+ <description>Time to sleep in between searches for work (in milliseconds).
+ Used as sleep interval by service threads such as log roller.</description>
+ </property>
+ <property>
+ <name>hbase.server.versionfile.writeattempts</name>
+ <value>3</value>
+ <description>
+ How many time to retry attempting to write a version file
+ before just aborting. Each attempt is seperated by the
+ hbase.server.thread.wakefrequency milliseconds.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.memstore.flush.size</name>
+ <value>134217728</value>
+ <description>
+ Memstore will be flushed to disk if size of the memstore
+ exceeds this number of bytes. Value is checked by a thread that runs
+ every hbase.server.thread.wakefrequency.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.percolumnfamilyflush.size.lower.bound</name>
+ <value>16777216</value>
+ <description>
+ If FlushLargeStoresPolicy is used, then every time that we hit the
+ total memstore limit, we find out all the column families whose memstores
+ exceed this value, and only flush them, while retaining the others whose
+ memstores are lower than this limit. If none of the families have their
+ memstore size more than this, all the memstores will be flushed
+ (just as usual). This value should be less than half of the total memstore
+ threshold (hbase.hregion.memstore.flush.size).
+ </description>
+ </property>
+ <property>
+ <name>hbase.hregion.preclose.flush.size</name>
+ <value>5242880</value>
+ <description>
+ If the memstores in a region are this size or larger when we go
+ to close, run a "pre-flush" to clear out memstores before we put up
+ the region closed flag and take the region offline. On close,
+ a flush is run under the close flag to empty memory. During
+ this time the region is offline and we are not taking on any writes.
+ If the memstore content is large, this flush could take a long time to
+ complete. The preflush is meant to clean out the bulk of the memstore
+ before putting up the close flag and taking the region offline so the
+ flush that runs under the close flag has little to do.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.memstore.block.multiplier</name>
+ <value>4</value>
+ <description>
+ Block updates if memstore has hbase.hregion.memstore.block.multiplier
+ times hbase.hregion.memstore.flush.size bytes. Useful preventing
+ runaway memstore during spikes in update traffic. Without an
+ upper-bound, memstore fills such that when it flushes the
+ resultant flush files take a long time to compact or split, or
+ worse, we OOME.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.memstore.mslab.enabled</name>
+ <value>true</value>
+ <description>
+ Enables the MemStore-Local Allocation Buffer,
+ a feature which works to prevent heap fragmentation under
+ heavy write loads. This can reduce the frequency of stop-the-world
+ GC pauses on large heaps.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.max.filesize</name>
+ <value>10737418240</value>
+ <description>
+ Maximum HStoreFile size. If any one of a column families' HStoreFiles has
+ grown to exceed this value, the hosting HRegion is split in two.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.majorcompaction</name>
+ <value>604800000</value>
+ <description>The time (in miliseconds) between 'major' compactions of all
+ HStoreFiles in a region. Default: Set to 7 days. Major compactions tend to
+ happen exactly when you need them least so enable them such that they run at
+ off-peak for your deploy; or, since this setting is on a periodicity that is
+ unlikely to match your loading, run the compactions via an external
+ invocation out of a cron job or some such.</description>
+ </property>
+ <property>
+ <name>hbase.hregion.majorcompaction.jitter</name>
+ <value>0.50</value>
+ <description>Jitter outer bound for major compactions.
+ On each regionserver, we multiply the hbase.region.majorcompaction
+ interval by some random fraction that is inside the bounds of this
+ maximum. We then add this + or - product to when the next
+ major compaction is to run. The idea is that major compaction
+ does happen on every regionserver at exactly the same time. The
+ smaller this number, the closer the compactions come together.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.compactionThreshold</name>
+ <value>3</value>
+ <description>
+ If more than this number of HStoreFiles in any one HStore
+ (one HStoreFile is written per flush of memstore) then a compaction
+ is run to rewrite all HStoreFiles files as one. Larger numbers
+ put off compaction but when it runs, it takes longer to complete.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.flusher.count</name>
+ <value>2</value>
+ <description>
+ The number of flush threads. With less threads, the memstore flushes will be queued. With
+ more threads, the flush will be executed in parallel, increasing the hdfs load. This can
+ lead as well to more compactions.
+ </description>
+ </property>
+ <property>
+ <name>hbase.hstore.blockingStoreFiles</name>
+ <value>10</value>
+ <description>
+ If more than this number of StoreFiles in any one Store
+ (one StoreFile is written per flush of MemStore) then updates are
+ blocked for this HRegion until a compaction is completed, or
+ until hbase.hstore.blockingWaitTime has been exceeded.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.blockingWaitTime</name>
+ <value>90000</value>
+ <description>
+ The time an HRegion will block updates for after hitting the StoreFile
+ limit defined by hbase.hstore.blockingStoreFiles.
+ After this time has elapsed, the HRegion will stop blocking updates even
+ if a compaction has not been completed.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.compaction.max</name>
+ <value>10</value>
+ <description>Max number of HStoreFiles to compact per 'minor' compaction.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.compaction.kv.max</name>
+ <value>10</value>
+ <description>How many KeyValues to read and then write in a batch when flushing
+ or compacting. Do less if big KeyValues and problems with OOME.
+ Do more if wide, small rows.</description>
+ </property>
+ <property>
+ <name>hbase.hstore.time.to.purge.deletes</name>
+ <value>0</value>
+ <description>The amount of time to delay purging of delete markers with future timestamps. If
+ unset, or set to 0, all delete markers, including those with future timestamps, are purged
+ during the next major compaction. Otherwise, a delete marker is kept until the major compaction
+ which occurs after the marker's timestamp plus the value of this setting, in milliseconds.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.majorcompaction.pagecache.drop</name>
+ <value>true</value>
+ <description>Specifies whether to drop pages read/written into the system page cache by
+ major compactions. Setting it to true helps prevent major compactions from
+ polluting the page cache, which is almost always required, especially for clusters
+ with low/moderate memory to storage ratio.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.minorcompaction.pagecache.drop</name>
+ <value>true</value>
+ <description>Specifies whether to drop pages read/written into the system page cache by
+ minor compactions. Setting it to true helps prevent minor compactions from
+ polluting the page cache, which is most beneficial on clusters with low
+ memory to storage ratio or very write heavy clusters. You may want to set it to
+ false under moderate to low write workload when bulk of the reads are
+ on the most recently written data.</description>
+ </property>
+ <property>
+ <name>hbase.storescanner.parallel.seek.enable</name>
+ <value>false</value>
+ <description>
+ Enables StoreFileScanner parallel-seeking in StoreScanner,
+ a feature which can reduce response latency under special conditions.</description>
+ </property>
+ <property>
+ <name>hbase.storescanner.parallel.seek.threads</name>
+ <value>10</value>
+ <description>
+ The default thread pool size if parallel-seeking feature enabled.</description>
+ </property>
+ <property>
+ <name>hfile.block.cache.size</name>
+ <value>0.4</value>
+ <description>Percentage of maximum heap (-Xmx setting) to allocate to block cache
+ used by HFile/StoreFile. Default of 0.4 means allocate 40%.
+ Set to 0 to disable but it's not recommended; you need at least
+ enough cache to hold the storefile indices.</description>
+ </property>
+ <property>
+ <name>hfile.block.index.cacheonwrite</name>
+ <value>false</value>
+ <description>This allows to put non-root multi-level index blocks into the block
+ cache at the time the index is being written.</description>
+ </property>
+ <property>
+ <name>hfile.index.block.max.size</name>
+ <value>131072</value>
+ <description>When the size of a leaf-level, intermediate-level, or root-level
+ index block in a multi-level block index grows to this size, the
+ block is written out and a new block is started.</description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.ioengine</name>
+ <value></value>
+ <description>Where to store the contents of the bucketcache. One of: heap,
+ offheap, or file. If a file, set it to file:PATH_TO_FILE. See
+ http://hbase.apache.org/book.html#offheap.blockcache for more information.
+ </description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.combinedcache.enabled</name>
+ <value>true</value>
+ <description>Whether or not the bucketcache is used in league with the LRU
+ on-heap block cache. In this mode, indices and blooms are kept in the LRU
+ blockcache and the data blocks are kept in the bucketcache.</description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.size</name>
+ <value></value>
+ <description>A float that EITHER represents a percentage of total heap memory
+ size to give to the cache (if < 1.0) OR, it is the total capacity in
+ megabytes of BucketCache. Default: 0.0</description>
+ </property>
+ <property>
+ <name>hbase.bucketcache.bucket.sizes</name>
+ <value></value>
+ <description>A comma-separated list of sizes for buckets for the bucketcache.
+ Can be multiple sizes. List block sizes in order from smallest to largest.
+ The sizes you use will depend on your data access patterns.
+ Must be a multiple of 256 else you will run into
+ 'java.io.IOException: Invalid HFile block magic' when you go to read from cache.
+ If you specify no values here, then you pick up the default bucketsizes set
+ in code (See BucketAllocator#DEFAULT_BUCKET_SIZES).
+ </description>
+ </property>
+ <property>
+ <name>hfile.format.version</name>
+ <value>3</value>
+ <description>The HFile format version to use for new files.
+ Version 3 adds support for tags in hfiles (See http://hbase.apache.org/book.html#hbase.tags).
+ Distributed Log Replay requires that tags are enabled. Also see the configuration
+ 'hbase.replication.rpc.codec'.
+ </description>
+ </property>
+ <property>
+ <name>hfile.block.bloom.cacheonwrite</name>
+ <value>false</value>
+ <description>Enables cache-on-write for inline blocks of a compound Bloom filter.</description>
+ </property>
+ <property>
+ <name>io.storefile.bloom.block.size</name>
+ <value>131072</value>
+ <description>The size in bytes of a single block ("chunk") of a compound Bloom
+ filter. This size is approximate, because Bloom blocks can only be
+ inserted at data block boundaries, and the number of keys per data
+ block varies.</description>
+ </property>
+ <property>
+ <name>hbase.rs.cacheblocksonwrite</name>
+ <value>false</value>
+ <description>Whether an HFile block should be added to the block cache when the
+ block is finished.</description>
+ </property>
+ <property>
+ <name>hbase.rpc.timeout</name>
+ <value>60000</value>
+ <description>This is for the RPC layer to define how long (millisecond) HBase client applications
+ take for a remote call to time out. It uses pings to check connections
+ but will eventually throw a TimeoutException.</description>
+ </property>
+ <property>
+ <name>hbase.client.operation.timeout</name>
+ <value>1200000</value>
+ <description>Operation timeout is a top-level restriction (millisecond) that makes sure a
+ blocking operation in Table will not be blocked more than this. In each operation, if rpc
+ request fails because of timeout or other reason, it will retry until success or throw
+ RetriesExhaustedException. But if the total time being blocking reach the operation timeout
+ before retries exhausted, it will break early and throw SocketTimeoutException.</description>
+ </property>
+ <property>
+ <name>hbase.cells.scanned.per.heartbeat.check</name>
+ <value>10000</value>
+ <description>The number of cells scanned in between heartbeat checks. Heartbeat
+ checks occur during the processing of scans to determine whether or not the
+ server should stop scanning in order to send back a heartbeat message to the
+ client. Heartbeat messages are used to keep the client-server connection alive
+ during long running scans. Small values mean that the heartbeat checks will
+ occur more often and thus will provide a tighter bound on the execution time of
+ the scan. Larger values mean that the heartbeat checks occur less frequently
+ </description>
+ </property>
+ <property>
+ <name>hbase.rpc.shortoperation.timeout</name>
+ <value>10000</value>
+ <description>This is another version of "hbase.rpc.timeout". For those RPC operation
+ within cluster, we rely on this configuration to set a short timeout limitation
+ for short operation. For example, short rpc timeout for region server's trying
+ to report to active master can benefit quicker master failover process.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.client.tcpnodelay</name>
+ <value>true</value>
+ <description>Set no delay on rpc socket connections. See
+ http://docs.oracle.com/javase/1.5.0/docs/api/java/net/Socket.html#getTcpNoDelay()</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.hostname</name>
+ <value></value>
+ <description>This config is for experts: don't set its value unless you really know what you are doing.
+ When set to a non-empty value, this represents the (external facing) hostname for the underlying server.
+ See https://issues.apache.org/jira/browse/HBASE-12954 for details.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.hostname.disable.master.reversedns</name>
+ <value>false</value>
+ <description>This config is for experts: don't set its value unless you really know what you are doing.
+ When set to true, regionserver will use the current node hostname for the servername and HMaster will
+ skip reverse DNS lookup and use the hostname sent by regionserver instead. Note that this config and
+ hbase.regionserver.hostname are mutually exclusive. See https://issues.apache.org/jira/browse/HBASE-18226
+ for more details.</description>
+ </property>
+ <!-- The following properties configure authentication information for
+ HBase processes when using Kerberos security. There are no default
+ values, included here for documentation purposes -->
+ <property>
+ <name>hbase.master.keytab.file</name>
+ <value></value>
+ <description>Full path to the kerberos keytab file to use for logging in
+ the configured HMaster server principal.</description>
+ </property>
+ <property>
+ <name>hbase.master.kerberos.principal</name>
+ <value></value>
+ <description>Ex. "hbase/_HOST@EXAMPLE.COM". The kerberos principal name
+ that should be used to run the HMaster process. The principal name should
+ be in the form: user/hostname@DOMAIN. If "_HOST" is used as the hostname
+ portion, it will be replaced with the actual hostname of the running
+ instance.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.keytab.file</name>
+ <value></value>
+ <description>Full path to the kerberos keytab file to use for logging in
+ the configured HRegionServer server principal.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.kerberos.principal</name>
+ <value></value>
+ <description>Ex. "hbase/_HOST@EXAMPLE.COM". The kerberos principal name
+ that should be used to run the HRegionServer process. The principal name
+ should be in the form: user/hostname@DOMAIN. If "_HOST" is used as the
+ hostname portion, it will be replaced with the actual hostname of the
+ running instance. An entry for this principal must exist in the file
+ specified in hbase.regionserver.keytab.file</description>
+ </property>
+ <!-- Additional configuration specific to HBase security -->
+ <property>
+ <name>hadoop.policy.file</name>
+ <value>hbase-policy.xml</value>
+ <description>The policy configuration file used by RPC servers to make
+ authorization decisions on client requests. Only used when HBase
+ security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.superuser</name>
+ <value></value>
+ <description>List of users or groups (comma-separated), who are allowed
+ full privileges, regardless of stored ACLs, across the cluster.
+ Only used when HBase security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.auth.key.update.interval</name>
+ <value>86400000</value>
+ <description>The update interval for master key for authentication tokens
+ in servers in milliseconds. Only used when HBase security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.auth.token.max.lifetime</name>
+ <value>604800000</value>
+ <description>The maximum lifetime in milliseconds after which an
+ authentication token expires. Only used when HBase security is enabled.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.client.fallback-to-simple-auth-allowed</name>
+ <value>false</value>
+ <description>When a client is configured to attempt a secure connection, but attempts to
+ connect to an insecure server, that server may instruct the client to
+ switch to SASL SIMPLE (unsecure) authentication. This setting controls
+ whether or not the client will accept this instruction from the server.
+ When false (the default), the client will not allow the fallback to SIMPLE
+ authentication, and will abort the connection.</description>
+ </property>
+ <property>
+ <name>hbase.ipc.server.fallback-to-simple-auth-allowed</name>
+ <value>false</value>
+ <description>When a server is configured to require secure connections, it will
+ reject connection attempts from clients using SASL SIMPLE (unsecure) authentication.
+ This setting allows secure servers to accept SASL SIMPLE connections from clients
+ when the client requests. When false (the default), the server will not allow the fallback
+ to SIMPLE authentication, and will reject the connection. WARNING: This setting should ONLY
+ be used as a temporary measure while converting clients over to secure authentication. It
+ MUST BE DISABLED for secure operation.</description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.enabled</name>
+ <value>true</value>
+ <description>Enables or disables coprocessor loading. If 'false'
+ (disabled), any other coprocessor related configuration will be ignored.
+ </description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.user.enabled</name>
+ <value>true</value>
+ <description>Enables or disables user (aka. table) coprocessor loading.
+ If 'false' (disabled), any table coprocessor attributes in table
+ descriptors will be ignored. If "hbase.coprocessor.enabled" is 'false'
+ this setting has no effect.
+ </description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.region.classes</name>
+ <value></value>
+ <description>A comma-separated list of Coprocessors that are loaded by
+ default on all tables. For any override coprocessor method, these classes
+ will be called in order. After implementing your own Coprocessor, just put
+ it in HBase's classpath and add the fully qualified class name here.
+ A coprocessor can also be loaded on demand by setting HTableDescriptor.</description>
+ </property>
+ <property>
+ <name>hbase.rest.port</name>
+ <value>8080</value>
+ <description>The port for the HBase REST server.</description>
+ </property>
+ <property>
+ <name>hbase.rest.readonly</name>
+ <value>false</value>
+ <description>Defines the mode the REST server will be started in. Possible values are:
+ false: All HTTP methods are permitted - GET/PUT/POST/DELETE.
+ true: Only the GET method is permitted.</description>
+ </property>
+ <property>
+ <name>hbase.rest.threads.max</name>
+ <value>100</value>
+ <description>The maximum number of threads of the REST server thread pool.
+ Threads in the pool are reused to process REST requests. This
+ controls the maximum number of requests processed concurrently.
+ It may help to control the memory used by the REST server to
+ avoid OOM issues. If the thread pool is full, incoming requests
+ will be queued up and wait for some free threads.</description>
+ </property>
+ <property>
+ <name>hbase.rest.threads.min</name>
+ <value>2</value>
+ <description>The minimum number of threads of the REST server thread pool.
+ The thread pool always has at least these number of threads so
+ the REST server is ready to serve incoming requests.</description>
+ </property>
+ <property>
+ <name>hbase.rest.support.proxyuser</name>
+ <value>false</value>
+ <description>Enables running the REST server to support proxy-user mode.</description>
+ </property>
+ <property>
+ <name>hbase.defaults.for.version.skip</name>
+ <value>true</value>
+ <description>Set to true to skip the 'hbase.defaults.for.version' check.
+ Setting this to true can be useful in contexts other than
+ the other side of a maven generation; i.e. running in an
+ ide. You'll want to set this boolean to true to avoid
+ seeing the RuntimException complaint: "hbase-default.xml file
+ seems to be for and old version of HBase (\${hbase.version}), this
+ version is X.X.X-SNAPSHOT"</description>
+ </property>
+ <property>
+ <name>hbase.coprocessor.abortonerror</name>
+ <value>true</value>
+ <description>Set to true to cause the hosting server (master or regionserver)
+ to abort if a coprocessor fails to load, fails to initialize, or throws an
+ unexpected Throwable object. Setting this to false will allow the server to
+ continue execution but the system wide state of the coprocessor in question
+ will become inconsistent as it will be properly executing in only a subset
+ of servers, so this is most useful for debugging only.</description>
+ </property>
+ <property>
+ <name>hbase.online.schema.update.enable</name>
+ <value>true</value>
+ <description>Set true to enable online schema changes.</description>
+ </property>
+ <property>
+ <name>hbase.table.lock.enable</name>
+ <value>true</value>
+ <description>Set to true to enable locking the table in zookeeper for schema change operations.
+ Table locking from master prevents concurrent schema modifications to corrupt table
+ state.</description>
+ </property>
+ <property>
+ <name>hbase.table.max.rowsize</name>
+ <value>1073741824</value>
+ <description>
+ Maximum size of single row in bytes (default is 1 Gb) for Get'ting
+ or Scan'ning without in-row scan flag set. If row size exceeds this limit
+ RowTooBigException is thrown to client.
+ </description>
+ </property>
+ <property>
+ <name>hbase.thrift.minWorkerThreads</name>
+ <value>16</value>
+ <description>The "core size" of the thread pool. New threads are created on every
+ connection until this many threads are created.</description>
+ </property>
+ <property>
+ <name>hbase.thrift.maxWorkerThreads</name>
+ <value>1000</value>
+ <description>The maximum size of the thread pool. When the pending request queue
+ overflows, new threads are created until their number reaches this number.
+ After that, the server starts dropping connections.</description>
+ </property>
+ <property>
+ <name>hbase.thrift.maxQueuedRequests</name>
+ <value>1000</value>
+ <description>The maximum number of pending Thrift connections waiting in the queue. If
+ there are no idle threads in the pool, the server queues requests. Only
+ when the queue overflows, new threads are added, up to
+ hbase.thrift.maxQueuedRequests threads.</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.thrift.framed</name>
+ <value>false</value>
+ <description>Use Thrift TFramedTransport on the server side.
+ This is the recommended transport for thrift servers and requires a similar setting
+ on the client side. Changing this to false will select the default transport,
+ vulnerable to DoS when malformed requests are issued due to THRIFT-601.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.thrift.framed.max_frame_size_in_mb</name>
+ <value>2</value>
+ <description>Default frame size when using framed transport</description>
+ </property>
+ <property>
+ <name>hbase.regionserver.thrift.compact</name>
+ <value>false</value>
+ <description>Use Thrift TCompactProtocol binary serialization protocol.</description>
+ </property>
+ <property>
+ <name>hbase.rootdir.perms</name>
+ <value>700</value>
+ <description>FS Permissions for the root directory in a secure(kerberos) setup.
+ When master starts, it creates the rootdir with this permissions or sets the permissions
+ if it does not match.</description>
+ </property>
+ <property>
+ <name>hbase.wal.dir.perms</name>
+ <value>700</value>
+ <description>FS Permissions for the root WAL directory in a secure(kerberos) setup.
+ When master starts, it creates the WAL dir with this permissions or sets the permissions
+ if it does not match.</description>
+ </property>
+ <property>
+ <name>hbase.data.umask.enable</name>
+ <value>false</value>
+ <description>Enable, if true, that file permissions should be assigned
+ to the files written by the regionserver</description>
+ </property>
+ <property>
+ <name>hbase.data.umask</name>
+ <value>000</value>
+ <description>File permissions that should be used to write data
+ files when hbase.data.umask.enable is true</description>
+ </property>
+ <property>
+ <name>hbase.snapshot.enabled</name>
+ <value>true</value>
+ <description>Set to true to allow snapshots to be taken / restored / cloned.</description>
+ </property>
+ <property>
+ <name>hbase.snapshot.restore.take.failsafe.snapshot</name>
+ <value>true</value>
+ <description>Set to true to take a snapshot before the restore operation.
+ The snapshot taken will be used in case of failure, to restore the previous state.
+ At the end of the restore operation this snapshot will be deleted</description>
+ </property>
+ <property>
+ <name>hbase.snapshot.restore.failsafe.name</name>
+ <value>hbase-failsafe-{snapshot.name}-{restore.timestamp}</value>
+ <description>Name of the failsafe snapshot taken by the restore operation.
+ You can use the {snapshot.name}, {table.name} and {restore.timestamp} variables
+ to create a name based on what you are restoring.</description>
+ </property>
+ <property>
+ <name>hbase.server.compactchecker.interval.multiplier</name>
+ <value>1000</value>
+ <description>The number that determines how often we scan to see if compaction is necessary.
+ Normally, compactions are done after some events (such as memstore flush), but if
+ region didn't receive a lot of writes for some time, or due to different compaction
+ policies, it may be necessary to check it periodically. The interval between checks is
+ hbase.server.compactchecker.interval.multiplier multiplied by
+ hbase.server.thread.wakefrequency.</description>
+ </property>
+ <property>
+ <name>hbase.lease.recovery.timeout</name>
+ <value>900000</value>
+ <description>How long we wait on dfs lease recovery in total before giving up.</description>
+ </property>
+ <property>
+ <name>hbase.lease.recovery.dfs.timeout</name>
+ <value>64000</value>
+ <description>How long between dfs recover lease invocations. Should be larger than the sum of
+ the time it takes for the namenode to issue a block recovery command as part of
+ datanode; dfs.heartbeat.interval and the time it takes for the primary
+ datanode, performing block recovery to timeout on a dead datanode; usually
+ dfs.client.socket-timeout. See the end of HBASE-8389 for more.</description>
+ </property>
+ <property>
+ <name>hbase.column.max.version</name>
+ <value>1</value>
+ <description>New column family descriptors will use this value as the default number of versions
+ to keep.</description>
+ </property>
+ <property>
+ <name>hbase.dfs.client.read.shortcircuit.buffer.size</name>
+ <value>131072</value>
+ <description>If the DFSClient configuration
+ dfs.client.read.shortcircuit.buffer.size is unset, we will
+ use what is configured here as the short circuit read default
+ direct byte buffer size. DFSClient native default is 1MB; HBase
+ keeps its HDFS files open so number of file blocks * 1MB soon
+ starts to add up and threaten OOME because of a shortage of
+ direct memory. So, we set it down from the default. Make
+ it > the default hbase block size set in the HColumnDescriptor
+ which is usually 64k.
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.checksum.verify</name>
+ <value>true</value>
+ <description>
+ If set to true (the default), HBase verifies the checksums for hfile
+ blocks. HBase writes checksums inline with the data when it writes out
+ hfiles. HDFS (as of this writing) writes checksums to a separate file
+ than the data file necessitating extra seeks. Setting this flag saves
+ some on i/o. Checksum verification by HDFS will be internally disabled
+ on hfile streams when this flag is set. If the hbase-checksum verification
+ fails, we will switch back to using HDFS checksums (so do not disable HDFS
+ checksums! And besides this feature applies to hfiles only, not to WALs).
+ If this parameter is set to false, then hbase will not verify any checksums,
+ instead it will depend on checksum verification being done in the HDFS client.
+ </description>
+ </property>
+ <property>
+ <name>hbase.hstore.bytes.per.checksum</name>
+ <value>16384</value>
+ <description>
+ Number of bytes in a newly created checksum chunk for HBase-level
+ checksums in hfile blocks.
+ </description>
+ </property>
+ <property>
+ <name>hbase.hstore.checksum.algorithm</name>
+ <value>CRC32C</value>
+ <description>
+ Name of an algorithm that is used to compute checksums. Possible values
+ are NULL, CRC32, CRC32C.
+ </description>
+ </property>
+
+ <property>
+ <name>hbase.client.scanner.max.result.size</name>
+ <value>2097152</value>
+ <description>Maximum number of bytes returned when calling a scanner's next method.
+ Note that when a single row is larger than this limit the row is still returned completely.
+ The default value is 2MB, which is good for 1ge networks.
+ With faster and/or high latency networks this value should be increased.
+ </description>
+ </property>
+
+ <property>
+ <name>hbase.server.scanner.max.result.size</name>
+ <value>104857600</value>
+ <description>Maximum number of bytes returned when calling a scanner's next method.
+ Note that when a single row is larger than this limit the row is still returned completely.
+ The default value is 100MB.
+ This is a safety setting to protect the server from OOM situations.
+ </description>
+ </property>
+
+ <property>
+ <name>hbase.status.published</name>
+ <value>false</value>
+ <description>
+ This setting activates the publication by the master of the status of the region server.
+ When a region server dies and its recovery starts, the master will push this information
+ to the client application, to let them cut the connection immediately instead of waiting
+ for a timeout.
+ </description>
+ </property>
Review comment:
I think we should keep the following properties but note them and add some explanations
```
<!-- Note xxx -->
<!-- <property>-->
<!-- <name>hbase.status.publisher.class</name>-->
<!-- <value>org.apache.hadoop.hbase.master.ClusterStatusPublisher$MulticastPublisher</value>-->
<!-- <description>-->
<!-- Implementation of the status publication with a multicast message.-->
<!-- </description>-->
<!-- </property>-->
<!-- <property>-->
<!-- <name>hbase.status.listener.class</name>-->
<!-- <value>org.apache.hadoop.hbase.client.ClusterStatusListener$MulticastListener</value>-->
<!-- <description>-->
<!-- Implementation of the status listener with a multicast message.-->
<!-- </description>-->
<!-- </property>-->
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08539af1e82e9ef40d9814fc4c787c9f66d3f33e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423)
* 923273e1eed813d62522fb270c250d207ce2a389 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r439920051
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*hbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
+ "https://repo.maven.apache.org/maven2/org/apache/flink/flink-shaded-hadoop-2-uber/2.4.1-10.0/flink-shaded-hadoop-2-uber-2.4.1-10.0.jar", tmpPath);
+ }
+
+ @Test
+ public void testHBase() throws Exception {
+ try (ClusterController clusterController = flink.startCluster(2)) {
+ // Create table and put data
+ hbase.createTable("source_table", "a", "b");
+ hbase.createTable("sink_table", "a", "b");
+ hbase.putData("source_table", "row1", "a", "c1", "v1");
+ hbase.putData("source_table", "row1", "b", "c1", "v2");
+ hbase.putData("source_table", "row2", "a", "c1", "v3");
+ hbase.putData("source_table", "row2", "b", "c1", "v4");
+
+ // Initialize the SQL client session configuration file
+ String schemaContent = initializeSessionYaml();
+ Files.write(this.sqlClientSessionConf,
+ schemaContent.getBytes(Charsets.UTF_8),
+ StandardOpenOption.CREATE,
+ StandardOpenOption.WRITE);
+
+ // Executing SQL: read the data from HBase source_table and then write into HBase sink_table
+ insertIntoHBaseTable(clusterController);
+
+ LOG.info("Verify the sink_table result.");
+ final List<String> result = hbase.scanTable("sink_table");
+ assertThat(
+ result.toArray(new String[0]),
+ arrayContainingInAnyOrder(
+ containsString("value=v1"),
+ containsString("value=v2"),
+ containsString("value=v3"),
+ containsString("value=v4")
+ ));
+ LOG.info("The HBase SQL client test run successfully.");
+ }
+
+ }
+
+ private String initializeSessionYaml() throws IOException {
+ URL url = SQLClientHBaseITCase.class.getClassLoader().getResource(HBASE_SOURCE_SINK_SCHEMA);
+ if (url == null) {
+ throw new FileNotFoundException(HBASE_SOURCE_SINK_SCHEMA);
+ }
+
+ return FileUtils.readFileUtf8(new File(url.getFile()));
+ }
+
+ private void insertIntoHBaseTable(ClusterController clusterController) throws IOException {
+ LOG.info("Executing SQL: HBase source_table -> HBase sink_table");
+ String sqlStatement = "INSERT INTO MyHBaseSink\n" +
+ " SELECT rowkey, a, b from MyHBaseSource";
Review comment:
Could you update this to a more complex query? e.g.
```sql
SELECT rowkey, a, ROW(RegReplace(a.c1, 'v', 'value')) from MyHBaseSource";
```
It uses udf and ROW to construct column family. We need to register the UDF RegReplace then.
```yaml
functions:
- name: RegReplace
from: class
class: org.apache.flink.table.toolbox.StringRegexReplaceFunction
```
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*hbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
+ "https://repo.maven.apache.org/maven2/org/apache/flink/flink-shaded-hadoop-2-uber/2.4.1-10.0/flink-shaded-hadoop-2-uber-2.4.1-10.0.jar", tmpPath);
+ }
+
+ @Test
+ public void testHBase() throws Exception {
+ try (ClusterController clusterController = flink.startCluster(2)) {
+ // Create table and put data
+ hbase.createTable("source_table", "a", "b");
+ hbase.createTable("sink_table", "a", "b");
+ hbase.putData("source_table", "row1", "a", "c1", "v1");
+ hbase.putData("source_table", "row1", "b", "c1", "v2");
+ hbase.putData("source_table", "row2", "a", "c1", "v3");
+ hbase.putData("source_table", "row2", "b", "c1", "v4");
+
+ // Initialize the SQL client session configuration file
+ String schemaContent = initializeSessionYaml();
+ Files.write(this.sqlClientSessionConf,
+ schemaContent.getBytes(Charsets.UTF_8),
+ StandardOpenOption.CREATE,
+ StandardOpenOption.WRITE);
+
+ // Executing SQL: read the data from HBase source_table and then write into HBase sink_table
+ insertIntoHBaseTable(clusterController);
+
+ LOG.info("Verify the sink_table result.");
+ final List<String> result = hbase.scanTable("sink_table");
+ assertThat(
+ result.toArray(new String[0]),
+ arrayContainingInAnyOrder(
+ containsString("value=v1"),
Review comment:
Can we match more information here? e.g. rowkey, family name and qualifier name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12369: Flink 17678
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635081028
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f49fb611425fd075c0818233472ece2a4a824d71 (Thu May 28 03:52:33 UTC 2020)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r437978305
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hbase;
+
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.cache.DownloadCache;
+import org.apache.flink.tests.util.categories.PreCommit;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.FlinkResourceSetup;
+import org.apache.flink.tests.util.flink.LocalStandaloneFlinkResourceFactory;
+import org.apache.flink.tests.util.flink.SQLJobSubmission;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.guava18.com.google.common.base.Charsets;
+
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
+import java.util.List;
+
+import static org.hamcrest.Matchers.arrayContainingInAnyOrder;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+/**
+ * End-to-end test for the HBase connectors.
+ */
+@Category(value = {TravisGroup1.class, PreCommit.class})
+public class SQLClientHBaseITCase extends TestLogger {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SQLClientHBaseITCase.class);
+
+ private static final String HBASE_SOURCE_SINK_SCHEMA = "hbase_source_sink_schema.yaml";
+
+ @Rule
+ public final HBaseResource hbase;
+
+ @Rule
+ public final FlinkResource flink = new LocalStandaloneFlinkResourceFactory()
+ .create(FlinkResourceSetup.builder().build());
+
+ @Rule
+ public final TemporaryFolder tmp = new TemporaryFolder();
+
+ @ClassRule
+ public static final DownloadCache DOWNLOAD_CACHE = DownloadCache.get();
+
+ private static final Path sqlToolBoxJar = TestUtils.getResourceJar(".*SqlToolbox.jar");
+ private static final Path sqlConnectorHBaseJar = TestUtils.getResourceJar(".*SqlConnectorHbase.jar");
+ private Path shadedHadoopJar;
+ private Path sqlClientSessionConf;
+
+ public SQLClientHBaseITCase() {
+ this.hbase = HBaseResource.get();
+ }
+
+ @Before
+ public void before() throws Exception {
+ DOWNLOAD_CACHE.before();
+ Path tmpPath = tmp.getRoot().toPath();
+ LOG.info("The current temporary path: {}", tmpPath);
+ this.sqlClientSessionConf = tmpPath.resolve("sql-client-session.conf");
+
+ //download flink shaded hadoop jar for hbase e2e test using
+ shadedHadoopJar = DOWNLOAD_CACHE.getOrDownload(
Review comment:
@leonardBang ,Thks for ur advice. But I encountered a problem that I can't setup HADOOP_CLASSPATH before running sql-client.sh. Could you give me some suggestion. What I have done is below:
```java
AtomicReference<String> atomicHadoopClasspath = new AtomicReference<>("");
AutoClosableProcess.create(
hadoopDir.resolve(Paths.get("bin", "hadoop")).toString(), "classpath")
.setStdoutProcessor(atomicHadoopClasspath::set)
.runBlocking();
final String hadoopClasspath = atomicHadoopClasspath.get();
LOG.info("Hadoop Classpath: {}", hadoopClasspath);
// how to setup HADOOP_CLASSPATH?
// I tried using AutoClosableProcess to run export HADOOP_CLASSPATH=<hadoopClasssPath>, but it doesn't work.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438129997
##########
File path: flink-connectors/flink-sql-connector-hbase/pom.xml
##########
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <name>flink-sql-connector-hbase</name>
+
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.flink:flink-connector-hbase_${scala.binary.version}</include>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.zookeeper:zookeeper</include>
+ <include>org.apache.htrace:htrace-core</include>
+ <include>com.google.guava:guava</include>
+ <include>com.google.protobuf:protobuf-java</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>commons-logging:commons-logging</include>
+ <include>commons-lang:commons-lang</include>
+ <include>commons-configuration:commons-configuration</include>
+ <include>commons-codec:commons-codec</include>
+ <include>io.netty:netty-all</include>
+ </includes>
+ <excludes>
+ <exclude>org.apache.hbase:hbase-metrics*</exclude>
+ <exclude>org.apache.hbase:hbase-server*</exclude>
+ </excludes>
+ </artifactSet>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/services/com.fasterxml.**</exclude>
+ <exclude>META-INF/services/org.apache.hadoop.**</exclude>
+ <exclude>META-INF/services/javax.**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <!-- Force relocation of all HBase dependencies. -->
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.htrace</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.htrace</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.yammer.metrics</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-logging</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-logging</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-lang</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-lang</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-configuration</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-configuration</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-codec</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-codec</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty:netty-all</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.hbase</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.hbase</shadedPattern>
Review comment:
@openinx according the current logic of e2e test, I just download the hbase tarball and unarchive it, there is no shade hbase jar exists in the classpath of hbase server. I think perhaps the problem you meet is caused by the hbase version. Which version of hbase do you use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on a change in pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on a change in pull request #12369:
URL: https://github.com/apache/flink/pull/12369#discussion_r438129997
##########
File path: flink-connectors/flink-sql-connector-hbase/pom.xml
##########
@@ -0,0 +1,140 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.12-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-hbase_${scala.binary.version}</artifactId>
+ <name>flink-sql-connector-hbase</name>
+
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-hbase_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.flink:flink-connector-hbase_${scala.binary.version}</include>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.zookeeper:zookeeper</include>
+ <include>org.apache.htrace:htrace-core</include>
+ <include>com.google.guava:guava</include>
+ <include>com.google.protobuf:protobuf-java</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>commons-logging:commons-logging</include>
+ <include>commons-lang:commons-lang</include>
+ <include>commons-configuration:commons-configuration</include>
+ <include>commons-codec:commons-codec</include>
+ <include>io.netty:netty-all</include>
+ </includes>
+ <excludes>
+ <exclude>org.apache.hbase:hbase-metrics*</exclude>
+ <exclude>org.apache.hbase:hbase-server*</exclude>
+ </excludes>
+ </artifactSet>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/services/com.fasterxml.**</exclude>
+ <exclude>META-INF/services/org.apache.hadoop.**</exclude>
+ <exclude>META-INF/services/javax.**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <!-- Force relocation of all HBase dependencies. -->
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.htrace</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.htrace</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.google</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.yammer.metrics</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-logging</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-logging</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-lang</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-lang</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-configuration</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-configuration</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>commons-codec</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.commons-codec</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty:netty-all</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.com.yammer.metrics</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.hbase</pattern>
+ <shadedPattern>org.apache.flink.hbase.shaded.org.apache.hbase</shadedPattern>
Review comment:
@openinx according the current logic of e2e test, I just download the hbase tarball and unarchive it, there is no shade hbase jar exists in the classpath of hbase server. How can I reappear this problem within e2e test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
DashShen commented on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-639203949
@rmetzger CI test was successfully passed, cloud you assignee someone to review my code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f49fb611425fd075c0818233472ece2a4a824d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2324",
"triggerID" : "f49fb611425fd075c0818233472ece2a4a824d71",
"triggerType" : "PUSH"
}, {
"hash" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2333",
"triggerID" : "518368f03c225bf1cdc2065382539f7f49f6c4e7",
"triggerType" : "PUSH"
}, {
"hash" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2386",
"triggerID" : "5e812cd62bcab9b71b1cb0fd1d86a10bb9795178",
"triggerType" : "PUSH"
}, {
"hash" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2415",
"triggerID" : "21da7909b9b5bf9fd4963d592da500752ab7c295",
"triggerType" : "PUSH"
}, {
"hash" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2423",
"triggerID" : "08539af1e82e9ef40d9814fc4c787c9f66d3f33e",
"triggerType" : "PUSH"
}, {
"hash" : "923273e1eed813d62522fb270c250d207ce2a389",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2620",
"triggerID" : "923273e1eed813d62522fb270c250d207ce2a389",
"triggerType" : "PUSH"
}, {
"hash" : "39607521051aea24e2f4805a428bb1469745287d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2642",
"triggerID" : "39607521051aea24e2f4805a428bb1469745287d",
"triggerType" : "PUSH"
}, {
"hash" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009",
"triggerID" : "7e9def2db9b7b755f7b048e4ee99339a509e390b",
"triggerType" : "PUSH"
}, {
"hash" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "586cad86df6ee5de33537f735fa5c65cabebe260",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e9def2db9b7b755f7b048e4ee99339a509e390b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009)
* 586cad86df6ee5de33537f735fa5c65cabebe260 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org