You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/14 12:57:24 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3580: ARTEMIS-3297 Historic Journal Backup

clebertsuconic commented on a change in pull request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632508629



##########
File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml
##########
@@ -406,6 +406,9 @@
       <page-max-concurrent-io>17</page-max-concurrent-io>
       <read-whole-page>true</read-whole-page>
       <journal-directory>somedir2</journal-directory>
+      <journal-history-directory>history</journal-history-directory>

Review comment:
       @gtully I thought about using max-files for such cases.. Humans are usually slow to react... ..
   
   perhaps we could have this
   
   <journal-retention period-type="days|files|hours" period="Number" folder="data/history"/>




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org