You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/10 09:06:08 UTC
Review Request 37282: Maintenance Primitives: Added InverseOffer to
V1 API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
src/internal/devolve.hpp b9a854a5e2454a4c3f2b85032b928b2cbc0b000c
src/internal/devolve.cpp be74a26e9a194a8d969c667fdc084964939dfdb7
src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7
src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review96916
-----------------------------------------------------------
Maybe you can kill this entire review however given my comments below?
src/internal/evolve.cpp (lines 162 - 163)
<https://reviews.apache.org/r/37282/#comment152610>
See comment below.
src/messages/messages.proto (line 171)
<https://reviews.apache.org/r/37282/#comment152609>
Let's not add this yet.
- Benjamin Hindman
On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 2:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review96923
-----------------------------------------------------------
Ship it!
Looks like this stuff is actually needed for https://reviews.apache.org/r/37180. But can we add a comment in ResourcesOffersMessage that explains that we've added the InverseOffer field because that's what we use in master.cpp but we HAVE NOT fully implemented this yet so don't expect it blah blah blah so that people don't go down a rat hole and then get mad at us for stuff not working. Thanks!
- Benjamin Hindman
On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 2:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review98181
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Sept. 3, 2015, 3:32 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2015, 3:32 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:54 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Added new-line.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review98802
-----------------------------------------------------------
Ship it!
Still a Ship It, just a minor nit.
src/messages/messages.proto (line 171)
<https://reviews.apache.org/r/37282/#comment155397>
Can we put a newline above this please? Thanks!
- Benjamin Hindman
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:33 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:32 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 10:48 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review96382
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 2:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review96284
-----------------------------------------------------------
include/mesos/v1/mesos.proto (line 907)
<https://reviews.apache.org/r/37282/#comment151616>
There is a patch for non V1 API here: https://reviews.apache.org/r/36321/diff/10#index_header
I think that here should be "which framework" but not "which agent"?
One question want to get your confirm: In V1 api, we changed SlaveId to AgentId, right?
- Guangya Liu
On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 2:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
> src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
> src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
> src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
> src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 6:58 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6
src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9
src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9
src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
Diff: https://reviews.apache.org/r/37282/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer
to V1 API.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review95179
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:06 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37282/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 12:06 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
> src/internal/devolve.hpp b9a854a5e2454a4c3f2b85032b928b2cbc0b000c
> src/internal/devolve.cpp be74a26e9a194a8d969c667fdc084964939dfdb7
> src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7
> src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc
>
> Diff: https://reviews.apache.org/r/37282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>