You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/09/12 13:48:00 UTC

(commons-jxpath) 21/27: Convert cascading if-else to switch

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jxpath.git

commit e150aca7784232ad03f4891221f4bf0c2cb0b4aa
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Sep 12 09:46:17 2024 -0400

    Convert cascading if-else to switch
---
 .../jxpath/ri/model/dynabeans/TestDynaBeanFactory.java        | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/test/java/org/apache/commons/jxpath/ri/model/dynabeans/TestDynaBeanFactory.java b/src/test/java/org/apache/commons/jxpath/ri/model/dynabeans/TestDynaBeanFactory.java
index a16eb10..856cc28 100644
--- a/src/test/java/org/apache/commons/jxpath/ri/model/dynabeans/TestDynaBeanFactory.java
+++ b/src/test/java/org/apache/commons/jxpath/ri/model/dynabeans/TestDynaBeanFactory.java
@@ -37,13 +37,13 @@ public class TestDynaBeanFactory extends AbstractFactory {
         final String name,
         final int index)
     {
-        if (name.equals("nestedBean")) {
+        switch (name) {
+        case "nestedBean":
             ((DynaBean) parent).set(
                 "nestedBean",
                 new NestedTestBean("newName"));
             return true;
-        }
-        else if (name.equals("beans")) {
+        case "beans": {
             final DynaBean bean = (DynaBean) parent;
             Object beans[] = (Object[]) bean.get("beans");
             if (beans == null || index >= beans.length) {
@@ -53,11 +53,14 @@ public class TestDynaBeanFactory extends AbstractFactory {
             beans[index] = new NestedTestBean("newName");
             return true;
         }
-        else if (name.equals("integers")) {
+        case "integers": {
             final DynaBean bean = (DynaBean) parent;
             bean.set("integers", index, Integer.valueOf(0));
             return true;
         }
+        default:
+            break;
+        }
         return false;
     }