You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/13 15:27:45 UTC

[GitHub] [ignite] korlov42 commented on pull request #8629: IGNITE-13915

korlov42 commented on pull request #8629:
URL: https://github.com/apache/ignite/pull/8629#issuecomment-759522279


   @zstan, everything looks good to me except changes in the `testCountWithJoin`. Comparing results of both engines (old engine on top of H2 and new powered by Calcite one) is not related to the topic of the original ticket. Also there is no need in [loop](https://github.com/apache/ignite/pull/8629/files#diff-7f67fe5196d271b967e3320aac6546521d70c369a42fa352e7bc603a7a850befR145)  in such kind of tests. Thus I think it's better to revert these changes for now.
   
   WDYT?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org