You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/22 00:03:42 UTC

[GitHub] [fineract] vorburger opened a new pull request #1464: Add new ImageTest (FINERACT-1218)

vorburger opened a new pull request #1464:
URL: https://github.com/apache/fineract/pull/1464


   see FINERACT-1218


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] ptuomola merged pull request #1464: Add new ImageTest (FINERACT-1218)

Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1464:
URL: https://github.com/apache/fineract/pull/1464


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] vidakovic commented on a change in pull request #1464: Add new ImageTest (FINERACT-1218)

Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1464:
URL: https://github.com/apache/fineract/pull/1464#discussion_r511590309



##########
File path: fineract-client/src/main/java/org/apache/fineract/client/util/FineractClient.java
##########
@@ -31,6 +31,7 @@
 import okhttp3.OkHttpClient;
 import okhttp3.logging.HttpLoggingInterceptor;
 import okhttp3.logging.HttpLoggingInterceptor.Level;
+import org.apache.fineract.client.ApiClient;

Review comment:
       @vorburger  This import seems to fail




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] vidakovic commented on pull request #1464: Add new ImageTest (FINERACT-1218)

Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1464:
URL: https://github.com/apache/fineract/pull/1464#issuecomment-716139854


   @vorburger there seems to be an import error?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] vorburger edited a comment on pull request #1464: Add new ImageTest (FINERACT-1218)

Posted by GitBox <gi...@apache.org>.
vorburger edited a comment on pull request #1464:
URL: https://github.com/apache/fineract/pull/1464#issuecomment-716121125


   @vidakovic @ptuomola this one is next.. do you both want to review and LGTM this, and the 2nd one merges when good?
   
   PS: This will conclude & resolve FINERACT-1218!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] vorburger commented on pull request #1464: Add new ImageTest (FINERACT-1218)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1464:
URL: https://github.com/apache/fineract/pull/1464#issuecomment-716121125


   @vidakovic @ptuomola this one is next.. do you both want to review and LGTM this, and the 2nd one merges when good?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] vorburger commented on pull request #1464: Add new ImageTest (FINERACT-1218)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1464:
URL: https://github.com/apache/fineract/pull/1464#issuecomment-716768386


   @vidakovic @ptuomola review this one? Finally green build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [fineract] vorburger commented on pull request #1464: Add new ImageTest (FINERACT-1218)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1464:
URL: https://github.com/apache/fineract/pull/1464#issuecomment-716212748


   > @vorburger there seems to be an import error?
   
   Fixed that, but I expect that this will now fail due to FINERACT-1242... hereby calling out looking for anyone willing to fix that!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org